RecentListens will soon need a refactor. infact our whole react codebase needs little polish
2020-09-12 25627, 2020
pristine___
shivam-kapila: if that number would have been big maybe 2k or even bigger, then storing every thing in listen array would have been a bad idea no? Causing lag or something
2020-09-12 25615, 2020
shivam-kapila
if you render only 25 then wont affect much
2020-09-12 25650, 2020
pristine___
> RecentListens will soon need a refactor. infact our whole react codebase needs little polish
2020-09-12 25608, 2020
iliekcomputers
What's wrong with the react codebase?
2020-09-12 25628, 2020
pristine___
shivam-kapila: I just want to merge this PR then I will be writing a recommendation component at least.
2020-09-12 25659, 2020
shivam-kapila
iliekcomputers: just segregation. like the stats portion is proper but earlier code is little mixed up
2020-09-12 25609, 2020
shivam-kapila
pristine___: gotcha
2020-09-12 25633, 2020
yokel joined the channel
2020-09-12 25605, 2020
iliekcomputers
Earlier code is mostly RecentListens :)
2020-09-12 25624, 2020
pristine___
shivam-kapila: so will try this next/previous thing. I will surely mess up. May need you again :p
2020-09-12 25645, 2020
shivam-kapila
no issues at all
2020-09-12 25643, 2020
sumedh has quit
2020-09-12 25638, 2020
sumedh joined the channel
2020-09-12 25638, 2020
yokel has quit
2020-09-12 25613, 2020
pristine___
ruaok: labs api for recording mbid loopkup return 200 for an empty response. Is this desirable? Shouldn't it be 204?
2020-09-12 25614, 2020
yokel joined the channel
2020-09-12 25610, 2020
pristine___
> Store the listens you're displaying in the state
yvanzo, the reason the queue is smaller is because I created a new VM with fixed disk instead of dynamic and it's on a new ssd.
2020-09-12 25641, 2020
nelgin
If I was to do this again, I think I would do it natively on my linux box rather than using docker, if that was at all possible.
2020-09-12 25603, 2020
nelgin
I'm sure the disk speed is suffering due to the virtualization layer.
2020-09-12 25646, 2020
yokel has quit
2020-09-12 25629, 2020
yokel joined the channel
2020-09-12 25641, 2020
BrainzGit
[critiquebrainz] amCap1712 opened pull request #300 (master…CB-361): CB-361: Group member list shows None if relationship has end date and no start date https://github.com/metabrainz/critiquebrainz/pull…
shivam-kapila: next/prev buttons and everything is working as expected :)
2020-09-12 25633, 2020
pristine___
Thanksssss
2020-09-12 25650, 2020
nelgin
yvanzo, in 11 hours I'm down to 109848 from 142387. After the next replication, if it's not caught up, I'm going to turn off the live indexing until you come up with something that's more suitable for mirror servers that don't have as many resources. Feel free to reach out to me if you want me to try something.
2020-09-12 25655, 2020
v6lur has quit
2020-09-12 25654, 2020
v6lur joined the channel
2020-09-12 25609, 2020
yvanzo
nelgin: thanks for your feedback
2020-09-12 25622, 2020
_lucifer
yvanzo: reosarevok: are broadcasts shown in release groups or not?
