RecentListens will soon need a refactor. infact our whole react codebase needs little polish
pristine___
shivam-kapila: if that number would have been big maybe 2k or even bigger, then storing every thing in listen array would have been a bad idea no? Causing lag or something
shivam-kapila
if you render only 25 then wont affect much
pristine___
> RecentListens will soon need a refactor. infact our whole react codebase needs little polish
iliekcomputers
What's wrong with the react codebase?
pristine___
shivam-kapila: I just want to merge this PR then I will be writing a recommendation component at least.
shivam-kapila
iliekcomputers: just segregation. like the stats portion is proper but earlier code is little mixed up
pristine___: gotcha
yokel joined the channel
iliekcomputers
Earlier code is mostly RecentListens :)
pristine___
shivam-kapila: so will try this next/previous thing. I will surely mess up. May need you again :p
shivam-kapila
no issues at all
sumedh has quit
sumedh joined the channel
yokel has quit
pristine___
ruaok: labs api for recording mbid loopkup return 200 for an empty response. Is this desirable? Shouldn't it be 204?
yokel joined the channel
> Store the listens you're displaying in the state
yvanzo, the reason the queue is smaller is because I created a new VM with fixed disk instead of dynamic and it's on a new ssd.
If I was to do this again, I think I would do it natively on my linux box rather than using docker, if that was at all possible.
I'm sure the disk speed is suffering due to the virtualization layer.
yokel has quit
yokel joined the channel
BrainzGit
[critiquebrainz] amCap1712 opened pull request #300 (master…CB-361): CB-361: Group member list shows None if relationship has end date and no start date https://github.com/metabrainz/critiquebrainz/pu...
shivam-kapila: next/prev buttons and everything is working as expected :)
Thanksssss
nelgin
yvanzo, in 11 hours I'm down to 109848 from 142387. After the next replication, if it's not caught up, I'm going to turn off the live indexing until you come up with something that's more suitable for mirror servers that don't have as many resources. Feel free to reach out to me if you want me to try something.
v6lur has quit
v6lur joined the channel
yvanzo
nelgin: thanks for your feedback
_lucifer
yvanzo: reosarevok: are broadcasts shown in release groups or not?