#metabrainz

its not a question about the tests themselves, but about where you spend your time.

ruaok: yeah. Got that. I saw the comment on the PR so thought I need to take an actual. Aaaaaaaaaaaaaaaah. Forget all this confusion. Lol

Action*

just more learning. being an engineer means balancing all sort of things and that takes time.

wow... laarge PR

after working on MB for 20 years now, I kinda feel like I finally have a bit of a clue as to what is going on.

Right. Time is limited. Should be used wisely.

ruaok: yeah, of course. 20 years <3

ruaok: On a side note, I spent like 5 days on this. Of these 5 days, i spent, 3.5/4 on the react stuff.

which isn't bad for someone who has never coded in react. well done.

FE devs. Kudos.

pristine___: tbh you did awesome... switching from BE to FE is far more difficult than from FE to BE

Thanks. Wouldn't be possible without shivam-kapila. Thanks.

Now just refactor RecentListens, kthx bye

oooo swag

iliekcomputers: for sure and do review 1042 when you get the time :)

Hah

I feel that BE is a lot more difficult, but maybe that's just the Perl

what is BE and FE

backend frontend

reosarevok: I meant switching

pristine___: reviews

given

[mb-solr] yvanzo merged pull request #36 (master…master): SEARCH 593: Update MB Solr tests to work with 3.1 https://github.com/metabrainz/mb-solr/pull/36

shivam-kapila: thanks. Fill have a look after dinner.

:(

:) *

[musicbrainz-server] yvanzo merged pull request #1691 (master…MBS-11069-whitespace-diff): MBS-11069: Fix diff highlighting of white spaces https://github.com/metabrainz/musicbrainz-serve...

MBS-11069: Diff highlighting not visible for certain display resolutions https://tickets.metabrainz.org/browse/MBS-11069

man, i hope we find life on venus

we're gonna need it soon.

Was there a idea called ReadBrainz or something?

An*

if we find life on venus and it's anything like life here, it'd be so mind blowing

Why sudden interest on interplanet life/extraterrestrial life?

iliekcomputers: I would prefer it to be better than here.

cuz here sucks right now

Crazy, elon's next agenda

ruaok: i meant, if it was dna based or something like that

:)

the theories! maybe there was an industrial civilization that led to global warming on venus which is why it's so hellish now

discovering life on other planets would make up the rest of 2020 for me tbh

(that sounds more insensitive than i meant)

ruaok: you have a second to chat about the feed i'm building?

in a minute.

cool.

i'll type it out for when you're back.

k

so i want to build a page with a list of listens for all users you're following

it's essentially the same thing as the my listens page but it's a list of users instead of a single user

in terms of API endpoints, i'm thinking of a `/feed` somewhere which takes the same params, has the same behaviour as the `/user/listens` endpoint.

so essentially, i'd change this line https://github.com/metabrainz/listenbrainz-serv... to be `username in user_list` and the timescale query would remain the same

the /feed endpoint would pass `[user for user in following]` while the /user/listens endpoint would pass in `[user]`

does that sound reasonable?

[17:44] <iliekcomputers> discovering life on other planets would make up the rest of 2020 for me tbh

[17:44] <iliekcomputers> (that sounds more insensitive than i meant)

but dude I totes agree with youl ike.

iliekcomputers: sounds straightforward and sane, yes.

cool! i'll go ahead and do the API endpoint first, and then frontend in a followup

👍

iliekcomputers: can we have playing now below an user's name in the feed?

and then an option to join the party maybe

[listenbrainz-server] paramsingh merged pull request #1087 (master…follow-button-animation): Animate the follow button https://github.com/metabrainz/listenbrainz-serv...

Mr_Monkey: Hey, did the idea of making ReadBrianz ever occur? what are your thoughts on it?

something similar to what discord does

What would ReadBrainz be?

[listenbrainz-server] paramsingh merged pull request #1088 (master…spark-config-update): Update spark config values to try and avoid RPC client error https://github.com/metabrainz/listenbrainz-serv...

like LB for BB

instead of spotify we connect it to goodreads

Well, the hope is that the combination of the new user collections and future integration with CritiqueBrainz will give us what we need for that feature, maybe with some minimal "follow user" features.

As for integration with other services, I suppose if the community pushes for it it could be a project

if CB and something like ReadBrainz is completed we will have the user in a complete MeB ecosystem.

like apple ecosystem. That person won't leave our suite of services

[listenbrainz-server] paramsingh merged pull request #1082 (master…ishaan/artist-map-listen-count): Show listen count on Artist Origin map (Backend) https://github.com/metabrainz/listenbrainz-serv...

naming things is hard

Yup, adding those 2 features will solve the problem ig.

I think the about of BB is misleading after adding User collection feature.

BookBrainz is a project to create an online database of information about every single book, magazine, journal and other publication ever written. We make all the data that we collect available to the whole world to consume and use as they see fit.

this only suggests the site is used to maintain a online transparent database of books

[listenbrainz-server] release v-2020-09-14.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-serv...

Freso: please call me last today, running (well, cycling) late

[listenbrainz-server] ishaanshah opened pull request #1089 (master…ishaan/store-import-id): Make sure incremental dump import is not skipped if RC crashes https://github.com/metabrainz/listenbrainz-serv...

iliekcomputers: Can you take a look once, will proceed to write tests tomorrow

pristine___: I will have a look at the PR tomorrow morning :)

it’s quiet monday…

i didn't receive any mailed in reviews for today, so…

people up: bitmap, zas, yvanzo, ruaok, Freso, alastairp, Mr_Monkey, jmp_music, diru1100, CatQuest, shivam-kapila, _lucifer, Cyna, reosarevok

bitmap go

hey

I mostly worked on https://github.com/metabrainz/musicbrainz-serve... which resolves some non-critical security issues in our OAuth implementation and sets Content-Security-Policy headers in a bunch of places

also worked a bit on the React timeline graph rewrite (the rate of change graph mostly) and did a bit of code review

I think that's about it! zas?

Or maybe…

yvanzo: go

Hi!

Last week I released a new version of MBS followed with hotfixes.

zas: ping?

Most prominent event was the search server hacking Thursday.

Thanks to alastairp and _lucifer for joining the party.

I'm here

Plus usual support and PR reviews.

Finito, it’s your turn zas! :)

Hey

(people up: ruaok, Freso, alastairp, Mr_Monkey, jmp_music, diru1100, CatQuest, shivam-kapila, _lucifer, Cyna, reosarevok – anyone else who want to give review, let me know when you can ❤️ )

This week I worked on Picard, PR reviews and patches

plus I fixed a bunch of dashboards in grafana

plus usual stuff, maintenance, upgrades, user support

that's it for me. fin. ruaok ?

hi

last week was a terrible week for me with allergies here in BCN. I barely held it together and got the most critical things done... and not much more.

:(

get well soon

there was a lot of fussing about t-shirts and summit t-shirts and the usual PR reviews and MeB background noise.

shivam-kapila: thanks. this week is already a little better.

Gezundheit!

and I oked at various projects here and there, but in the end wasn't much use.

fin. Mr_Monkey, go!

*poked

peek a boo!

ruaok: nice to hear that

Last week I worked on the BB database dumps to exclude private collections. Made some progress, got reviewed, found out there's a bunch of issues, and continued today to rewrite good bits of it

Some LB PR reviews and discussions

Did a quick PR to animate the new LB follow user button

Fixed a bug in BB where annotations were simply deleted during merge operations (eek!)

And worked on the summit t-shirt design

And dfinally, started implementing CatQuest's updated relationships for BB

Your turn reosarevok !

I’m not sure reosarevok is home yet.