Hey y'all. I can't seem to get registered for bookbrainz. I get to the display name screen, press "looks good sign me up" and it just spins. (MB username: bricas)
[listenbrainz-server] AbhinavOhri closed pull request #1048 (master…trailing-slash): LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://github.com/metabrainz/listenbrainz-server…
[listenbrainz-server] AbhinavOhri reopened pull request #1048 (master…trailing-slash): LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://github.com/metabrainz/listenbrainz-server…
yvanzo: can we have PRs in troi-recommendation-playground interact with LB- issues on jira?
2020-10-21 29535, 2020
alastairp
one final comment on that PR, otherwise it's good
2020-10-21 29555, 2020
ruaok
fixed.
2020-10-21 29510, 2020
ruaok
alastairp: so, what error catching strategy should we go with? I'm learning towards a policy that says: If an error is encountered by the pipeline it should throw an informative RuntimeError exception and then main block should catch and display those without a stack trace. And I should remove the blanket Exception catch and add more detailed try blocks for other cases. (e.g. the stacktrace you showed in the bug)
2020-10-21 29503, 2020
ruaok
this should avoid obscuring real bugs and their stacktraces. while showing errors in the pipeline in a sane fashion that doesn't throw a stacktrace in the users face.
2020-10-21 29537, 2020
alastairp
right. If an element wants to report an error that means it can't continue, it should definitely report that as a specific exception. This will mean that the pipeline will quit, right?
2020-10-21 29555, 2020
ruaok
yes.
2020-10-21 29500, 2020
alastairp
if it's a programming error then yeah, there should be a stacktrace (and explosion, I guess)
2020-10-21 29516, 2020
ruaok
should we continue to use RuntimeError or define a custom exception for pipeline errors?
2020-10-21 29545, 2020
alastairp
it might be a good idea to make a troi-specific subclass of runtime error, just to be able to differentiate them
also, when I was in Sitges this past weekend, the internet was quite poor.
2020-10-21 29508, 2020
ruaok
and BrainzPlayer just continually shat itself. :(
2020-10-21 29515, 2020
Mr_Monkey
For the next button, there's no code to hide it, so I have no idea what's happening here. Rendering error? Can you try resizing your browser window to a small width and back to normal and see if it rerenders?
LB-743: Some exception handling swallows traceback
2020-10-21 29524, 2020
yvanzo
I just undid the transition to the status "in progress"
2020-10-21 29550, 2020
Mr_Monkey
No objection
2020-10-21 29552, 2020
yvanzo
it should be available from "resolve issue"
2020-10-21 29540, 2020
MajorLurker has quit
2020-10-21 29511, 2020
ruaok
how does one do that?
2020-10-21 29500, 2020
ruaok
its in progress, but resolve issue does not give me the option to set "in review"
2020-10-21 29512, 2020
yvanzo
I just tried, it actually transitions to "in review"
2020-10-21 29533, 2020
yvanzo
This has probably been configured intentionally.
2020-10-21 29552, 2020
yvanzo
MB workflow is more explicit, it has a "in review" button, but it also has "in beta testing" (for beta branch) and "in development branch" (for master branch, as opposed to production).
I wasn't certain if the patches dir should be in the project or not -- given the pip install goal.
2020-10-21 29505, 2020
alastairp
yeah, right. because ideally people would be able to write patches with a set of pre-written elements, right?
2020-10-21 29516, 2020
alastairp
so they'd need a place to be able to put their own patche
2020-10-21 29533, 2020
ruaok
yes.
2020-10-21 29544, 2020
ruaok
and I suppose we want to ship some default patches as well.
2020-10-21 29508, 2020
ruaok
I guess it makes sense to put the batteries included patches into the project itself.
2020-10-21 29500, 2020
alastairp
right, we could have the built-in patches plus a way of adding your own ones as well
2020-10-21 29515, 2020
ruaok
yep.
2020-10-21 29525, 2020
ruaok
then what form does troi.py take?
2020-10-21 29533, 2020
alastairp
I guess the workflow for that would be something like "start a new project, pip install troi, and then put files somewhere special (or some kind of configuration)"
2020-10-21 29543, 2020
alastairp
it could be `python -m troi <whatever>`
2020-10-21 29502, 2020
v6lur has quit
2020-10-21 29505, 2020
alastairp
keep in mind that setup.py can install a cli tool too, which just points to a python module somewhere
2020-10-21 29514, 2020
alastairp
so it could be `troi <whatever>`
2020-10-21 29533, 2020
ruaok
that sounds good.
2020-10-21 29504, 2020
alastairp
so the `troi` executable could be the `troi.cli` module
2020-10-21 29529, 2020
ruaok
so do we move troi.py to troi/troi-main.py and then install troy-main.py as troi ?
2020-10-21 29538, 2020
ruaok
s/-/_/
2020-10-21 29540, 2020
alastairp
yes, I think so
2020-10-21 29558, 2020
alastairp
(or cli.py...)
2020-10-21 29506, 2020
ruaok
ok, makes sense to me.
2020-10-21 29522, 2020
alastairp
and put default patches in troi/patches?
2020-10-21 29526, 2020
ruaok
I'm not a fan of cli.py because it doesn't give you a clue at all which package it belongs to
2020-10-21 29531, 2020
ruaok
yes
2020-10-21 29559, 2020
alastairp
I mean troi/cli.py, is that still problematic to you?
2020-10-21 29518, 2020
ruaok
that's fine -- that comment was more about the install name.
