Hey y'all. I can't seem to get registered for bookbrainz. I get to the display name screen, press "looks good sign me up" and it just spins. (MB username: bricas)
[listenbrainz-server] AbhinavOhri closed pull request #1048 (master…trailing-slash): LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://github.com/metabrainz/listenbrainz-serv...
[listenbrainz-server] AbhinavOhri reopened pull request #1048 (master…trailing-slash): LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://github.com/metabrainz/listenbrainz-serv...
yvanzo: can we have PRs in troi-recommendation-playground interact with LB- issues on jira?
one final comment on that PR, otherwise it's good
ruaok
fixed.
alastairp: so, what error catching strategy should we go with? I'm learning towards a policy that says: If an error is encountered by the pipeline it should throw an informative RuntimeError exception and then main block should catch and display those without a stack trace. And I should remove the blanket Exception catch and add more detailed try blocks for other cases. (e.g. the stacktrace you showed in the bug)
this should avoid obscuring real bugs and their stacktraces. while showing errors in the pipeline in a sane fashion that doesn't throw a stacktrace in the users face.
alastairp
right. If an element wants to report an error that means it can't continue, it should definitely report that as a specific exception. This will mean that the pipeline will quit, right?
ruaok
yes.
alastairp
if it's a programming error then yeah, there should be a stacktrace (and explosion, I guess)
ruaok
should we continue to use RuntimeError or define a custom exception for pipeline errors?
alastairp
it might be a good idea to make a troi-specific subclass of runtime error, just to be able to differentiate them
also, when I was in Sitges this past weekend, the internet was quite poor.
and BrainzPlayer just continually shat itself. :(
Mr_Monkey
For the next button, there's no code to hide it, so I have no idea what's happening here. Rendering error? Can you try resizing your browser window to a small width and back to normal and see if it rerenders?
LB-743: Some exception handling swallows traceback
yvanzo
I just undid the transition to the status "in progress"
Mr_Monkey
No objection
yvanzo
it should be available from "resolve issue"
MajorLurker has quit
ruaok
how does one do that?
its in progress, but resolve issue does not give me the option to set "in review"
yvanzo
I just tried, it actually transitions to "in review"
This has probably been configured intentionally.
MB workflow is more explicit, it has a "in review" button, but it also has "in beta testing" (for beta branch) and "in development branch" (for master branch, as opposed to production).
I wasn't certain if the patches dir should be in the project or not -- given the pip install goal.
alastairp
yeah, right. because ideally people would be able to write patches with a set of pre-written elements, right?
so they'd need a place to be able to put their own patche
ruaok
yes.
and I suppose we want to ship some default patches as well.
I guess it makes sense to put the batteries included patches into the project itself.
alastairp
right, we could have the built-in patches plus a way of adding your own ones as well
ruaok
yep.
then what form does troi.py take?
alastairp
I guess the workflow for that would be something like "start a new project, pip install troi, and then put files somewhere special (or some kind of configuration)"
it could be `python -m troi <whatever>`
v6lur has quit
keep in mind that setup.py can install a cli tool too, which just points to a python module somewhere
so it could be `troi <whatever>`
ruaok
that sounds good.
alastairp
so the `troi` executable could be the `troi.cli` module
ruaok
so do we move troi.py to troi/troi-main.py and then install troy-main.py as troi ?
s/-/_/
alastairp
yes, I think so
(or cli.py...)
ruaok
ok, makes sense to me.
alastairp
and put default patches in troi/patches?
ruaok
I'm not a fan of cli.py because it doesn't give you a clue at all which package it belongs to
yes
alastairp
I mean troi/cli.py, is that still problematic to you?
ruaok
that's fine -- that comment was more about the install name.