[musicbrainz-server] reosarevok opened pull request #1850 (master…MBS-11303): MBS-11303 (I): Use React.useContext in more places rather than passing $c around https://github.com/metabrainz/musicbrainz-server/…
[musicbrainz-server] reosarevok merged pull request #1826 (master…MBS-8169): MBS-8169 / MBS-11274: Add a link to the timeline for individual statistics https://github.com/metabrainz/musicbrainz-server/…
alastairp: I was looking into the editor tests. The extension you linked for transactional tests in the PR is a flask-sqlalchemy one but in BU we are only using sqlalchemy. Any ideas on how to approach this?
2021-01-05 00529, 2021
alastairp
hi
2021-01-05 00533, 2021
alastairp
interesting question
2021-01-05 00553, 2021
alastairp
right, because we need to actually insert data into the database and then clear it after the test?
2021-01-05 00511, 2021
alastairp
are there any editors in the database currently?
2021-01-05 00530, 2021
_lucifer
alastairp: hi! yes, we need to roll back db changes after tests. there are existing editors in the db but some fields like bio, dob, so on are
2021-01-05 00530, 2021
_lucifer
absent and last login date will almost always change between dumps
2021-01-05 00510, 2021
_lucifer
i was thinking if we took the current dump and included that in the test db image
2021-01-05 00519, 2021
_lucifer
so that the dump data is fixed and we do not need to change the tests often.
2021-01-05 00557, 2021
devorizon joined the channel
2021-01-05 00520, 2021
v6lur_ has quit
2021-01-05 00515, 2021
ishaanshah
Hi devorizon, I was taking a look at PR 1214
2021-01-05 00536, 2021
ishaanshah
Most of it looks good but I found out a regression
2021-01-05 00506, 2021
ishaanshah
The importer doesnt report an error if the username is invalid, which it should
2021-01-05 00520, 2021
ishaanshah
can you take a look at that?
2021-01-05 00540, 2021
devorizon
sure ishaanshah
2021-01-05 00554, 2021
ishaanshah
Also the page freezes if there is an network error
2021-01-05 00551, 2021
d4rkie joined the channel
2021-01-05 00502, 2021
D4RK-PH0_ has quit
2021-01-05 00555, 2021
BrainzGit
[listenbrainz-server] ishaanshah opened pull request #1228 (master…listening-activity-test-bug): LB-781 - Fix failure in UserListeningActivity.test.tsx due to new year https://github.com/metabrainz/listenbrainz-server…
2021-01-05 00526, 2021
ishaanshah
Mr_Monkey:
2021-01-05 00545, 2021
ishaanshah
I opened a PR for LB-781, please have a look when you are free
So there shouldn't be an issue even if the input file is updated in the future
2021-01-05 00532, 2021
alastairp
right, so you have the mocked api result
2021-01-05 00525, 2021
alastairp
I wonder if we could make this simpler by improving the API content - if the API returned counts for all items in the range, then the frontend wouldn't even need to get the current year
7:22 PM <ishaanshah> Also the page freezes if there is an network error
2021-01-05 00557, 2021
devorizon
ishaanshah i have resolved the invalid username error issue.. but can you explain more how the page freezes ? I turned off my internet and the page is working fine in my system
[musicbrainz-server] reosarevok merged pull request #1830 (master…MBS-11181): MBS-11181 / MBS-11281: Improvements to date merging in the relationship editor https://github.com/metabrainz/musicbrainz-server/…
