[musicbrainz-server] reosarevok opened pull request #1850 (master…MBS-11303): MBS-11303 (I): Use React.useContext in more places rather than passing $c around https://github.com/metabrainz/musicbrainz-serve...
[musicbrainz-server] reosarevok merged pull request #1826 (master…MBS-8169): MBS-8169 / MBS-11274: Add a link to the timeline for individual statistics https://github.com/metabrainz/musicbrainz-serve...
alastairp: I was looking into the editor tests. The extension you linked for transactional tests in the PR is a flask-sqlalchemy one but in BU we are only using sqlalchemy. Any ideas on how to approach this?
alastairp
hi
interesting question
right, because we need to actually insert data into the database and then clear it after the test?
are there any editors in the database currently?
_lucifer
alastairp: hi! yes, we need to roll back db changes after tests. there are existing editors in the db but some fields like bio, dob, so on are
absent and last login date will almost always change between dumps
i was thinking if we took the current dump and included that in the test db image
so that the dump data is fixed and we do not need to change the tests often.
devorizon joined the channel
v6lur_ has quit
ishaanshah
Hi devorizon, I was taking a look at PR 1214
Most of it looks good but I found out a regression
The importer doesnt report an error if the username is invalid, which it should
can you take a look at that?
devorizon
sure ishaanshah
ishaanshah
Also the page freezes if there is an network error
d4rkie joined the channel
D4RK-PH0_ has quit
BrainzGit
[listenbrainz-server] ishaanshah opened pull request #1228 (master…listening-activity-test-bug): LB-781 - Fix failure in UserListeningActivity.test.tsx due to new year https://github.com/metabrainz/listenbrainz-serv...
ishaanshah
Mr_Monkey:
I opened a PR for LB-781, please have a look when you are free
So there shouldn't be an issue even if the input file is updated in the future
alastairp
right, so you have the mocked api result
I wonder if we could make this simpler by improving the API content - if the API returned counts for all items in the range, then the frontend wouldn't even need to get the current year
7:22 PM <ishaanshah> Also the page freezes if there is an network error
ishaanshah i have resolved the invalid username error issue.. but can you explain more how the page freezes ? I turned off my internet and the page is working fine in my system
[musicbrainz-server] reosarevok merged pull request #1830 (master…MBS-11181): MBS-11181 / MBS-11281: Improvements to date merging in the relationship editor https://github.com/metabrainz/musicbrainz-serve...