(Only myself and _lucifer still left on my list (diru1100 seems to not be around); last call for anyone else who may want to give review!)
2021-02-15 04604, 2021
CatQuest
!m bitmap
2021-02-15 04604, 2021
BrainzBot
You're doing good work, bitmap!
2021-02-15 04609, 2021
bitmap
also made some improvements to the relationship dialog, mostly related to MBS-7582 and switching the relationship type dropdown to use the autocomplete component
(which also has the nice benefit of showing recently-used rel types there)
2021-02-15 04656, 2021
bitmap
mostly just fixing a ton of bugs in the branch otherwise and writing commit messages
2021-02-15 04614, 2021
reosarevok
Whee
2021-02-15 04624, 2021
reosarevok still waiting for this for further React work
2021-02-15 04627, 2021
reosarevok
No pressure
2021-02-15 04630, 2021
bitmap
besides that, we discussed updates to the gsoc ideas list, & reosarevok & yvanzo did all the work of actually writing the changes (thanks to both of you)
2021-02-15 04601, 2021
bitmap
I also started a doc with small schema change ideas (i.e. nothing that requires big UI changes) and did a small amount of code review
2021-02-15 04613, 2021
reosarevok
Schema change: drop the DB
2021-02-15 04621, 2021
bitmap
fin! Freso go
2021-02-15 04628, 2021
CatQuest
sush reo
2021-02-15 04633, 2021
Freso
Dropping the db? Finally!
2021-02-15 04637, 2021
reosarevok
CatQuest: eh, imagine, you could do easy edits again!
2021-02-15 04647, 2021
CatQuest
nei
2021-02-15 04654, 2021
Freso
o/
2021-02-15 04659, 2021
reosarevok
Ok, ok, let's let Freso talk
2021-02-15 04638, 2021
yvanzo
radical nosql ^^
2021-02-15 04659, 2021
Freso
Not much to talk about, tbh. :\ Another quiet, lurky week from me. Did poke a teeny bit at some reports.
2021-02-15 04609, 2021
Freso
fin.
2021-02-15 04614, 2021
Freso
_lucifer: Take it away.
2021-02-15 04622, 2021
_lucifer
Hi all!
2021-02-15 04633, 2021
CatQuest
hi!
2021-02-15 04657, 2021
_lucifer
As alastairp mentioned, I worked with him on testing BU with downstream apps.
2021-02-15 04659, 2021
_lucifer
I also worked on some PRs to improve the cache module and another one for fixing a bug in LB recent listens page.
2021-02-15 04629, 2021
_lucifer
Futher, I am familiarizing myself with the LB spark infrastructure to contribute to it in the near future.
2021-02-15 04633, 2021
_lucifer
That's it for me.
2021-02-15 04637, 2021
ruaok
!m _lucifer
2021-02-15 04637, 2021
BrainzBot
You're doing good work, _lucifer!
2021-02-15 04643, 2021
Freso
Alrighty-o.
2021-02-15 04652, 2021
Freso
That wraps up the Reviews section.
2021-02-15 04630, 2021
Freso
I removed topics from ruaok and reosarevok because I think those were old and just didn’t get removed from last week, if not, please let me know (or just readd them yourselves).
2021-02-15 04639, 2021
Freso
But there is still one more topic on the agenda…
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, CB-408 (alastair), GSoC (ruaok)
2021-02-15 04658, 2021
ruaok
which is why I didn't remove it.
2021-02-15 04615, 2021
Freso
alastairp: ^
2021-02-15 04633, 2021
alastairp
hi. I was looking at some bugs that I had opened on CB, and some associated PRs. trying to work out why things work the way that it does
2021-02-15 04606, 2021
alastairp
I took a further look at it, and as far as I can tell, there is support in CB to continue showing reviews even if the underlying item in MB has been deleted
Hmm. If something has been deleted, do you have any data left other than an MBID?
2021-02-15 04625, 2021
alastairp
well, we have the contents of the review
2021-02-15 04628, 2021
alastairp
but not any other metadata
2021-02-15 04633, 2021
reosarevok
Sure, but anything that lets you map it to something
2021-02-15 04634, 2021
reosarevok
Hmm
2021-02-15 04637, 2021
reosarevok
Then I'd at least hide them
2021-02-15 04658, 2021
reosarevok
Might not drop them, and tell the user "hey, your review X is of an item now deleted, see if you want to copy it to a different, existing item?"
2021-02-15 04607, 2021
alastairp
I don't know exactly what the reasoning behind this was
2021-02-15 04618, 2021
alastairp
yeah, if it was to ensure that we don't remove reviews?
2021-02-15 04620, 2021
CatQuest
i like reo's idea
2021-02-15 04621, 2021
reosarevok
Was it intentionally done that you can tell?
2021-02-15 04638, 2021
reosarevok
Maybe nobody thought of items getting deleted
2021-02-15 04655, 2021
alastairp
I can dig into the history to see if I can work that out. From what I can see in the existing code it was intentional, and this is the only motivation for doing it that I can think of
2021-02-15 04616, 2021
reosarevok
I think it's sensible to not remove reviews due to something the reviewer has no control over
2021-02-15 04621, 2021
alastairp
however, there's been a _lot_ of copy/paste code as we've been adding new entities, and it's not been copied correctly
2021-02-15 04624, 2021
reosarevok
But showing it with no metadata is useless
2021-02-15 04631, 2021
CatQuest
i'd sure has hell get annoyed if a thoguht out review of mine were removed jsut becasue whatever it was would be
2021-02-15 04643, 2021
reosarevok
So yeah, IMO keep it but hidden and let the reviewer do something with it
2021-02-15 04653, 2021
ruaok
I have a vague recollection of discussing this with gentlecat, but no real substance behind it.
2021-02-15 04602, 2021
reosarevok
Whether pick a new entity if that's something you want to support, or just copy-paste it elsewhere by hand
2021-02-15 04604, 2021
alastairp
yes, right. I'm unsure about copying further metadata over though, because the whole point of MB database integration was so that we didn't have to do this
2021-02-15 04610, 2021
reosarevok
Agreed
2021-02-15 04614, 2021
alastairp
the main question I want to ask is:
2021-02-15 04629, 2021
reosarevok
If they can't figure out from the review what it was, it's probably not worth keeping for them anyway :D
2021-02-15 04630, 2021
alastairp
does it make sense to remove all of this special-casing code for "unknown entities"?
2021-02-15 04648, 2021
alastairp
as a part of this we can add the ability for people to re-assign reviews to new entities if required
2021-02-15 04656, 2021
_lucifer
I think yeah we should do that.
2021-02-15 04612, 2021
reosarevok
That seems sensible to me
2021-02-15 04613, 2021
CatQuest
> add the ability for people to re-assign reviews to new entities
2021-02-15 04613, 2021
CatQuest
oh yes!
2021-02-15 04617, 2021
reosarevok
If someone screams, you have git history
2021-02-15 04625, 2021
reosarevok
(they likely won't)
2021-02-15 04628, 2021
alastairp
ok, thanks. thatll help some reviews go more cleanly
2021-02-15 04629, 2021
alastairp
thanks
2021-02-15 04635, 2021
ruaok
+1
2021-02-15 04640, 2021
alastairp
CatQuest: though, only in the special case that the entity has been deleted from MB
2021-02-15 04644, 2021
alastairp
thanks. Freso: next?
2021-02-15 04644, 2021
yvanzo
if removing this code solves current problems, yes.
2021-02-15 04651, 2021
CatQuest
alastairp: hmm
2021-02-15 04651, 2021
Freso
Thanks alastairp :)
2021-02-15 04655, 2021
Freso
ruaok: GSoC
2021-02-15 04602, 2021
ruaok
there were strange things in CB I couldn't dissuade genlecat from.
2021-02-15 04625, 2021
ruaok
so, gsoc: thanks to Mr_Monkey and reosarevok for working up MB and BB's ideas pages. great!
2021-02-15 04641, 2021
alastairp
ruaok: yeah, I think that's the case in some things. It _could_ happen so we have to support it. when it turns out that just manually fixing something when it comes up 3 times a decade is enough
2021-02-15 04654, 2021
ruaok
outsidecontext will work on the picard page this week, which leaves alastairp to promise again this week that he will do it this week.
2021-02-15 04607, 2021
alastairp
I've been drafting some tasks last week. I didn't mention it in reviews sorry
2021-02-15 04626, 2021
ruaok
alastairp: the deadline is on the 19th, so can you please make the page at least believable for the time being?
2021-02-15 04633, 2021
ruaok
doesn't have to be super fleshed out.
2021-02-15 04642, 2021
reosarevok
Who is doing the applying? Freso?
2021-02-15 04643, 2021
alastairp
yep, will copy my draft ideas over tomoorow
2021-02-15 04651, 2021
Freso
reosarevok: I assume ruaok.
2021-02-15 04653, 2021
ruaok
reosarevok: I am.
2021-02-15 04654, 2021
reosarevok
Oh, ok
2021-02-15 04657, 2021
ruaok
alastairp: great, thanks
2021-02-15 04600, 2021
reosarevok
I always forget that bit
2021-02-15 04601, 2021
ruaok
fin, freso.
2021-02-15 04609, 2021
_lucifer
regarding MusicBrainz Android, I have received a few queries on my email. I have redirected them to the channel. I do now have any particular ideas to make a suitable GSoC project but I'll be happy to mentor if any of the applicants come up with one.
2021-02-15 04616, 2021
reosarevok
We'll have a couple more ideas but it seems fine IMO
2021-02-15 04625, 2021
_lucifer
*do not
2021-02-15 04628, 2021
Freso
Alright, that wraps up today’s meeting!
2021-02-15 04637, 2021
ruaok
_lucifer: you're still a student, yes?
2021-02-15 04653, 2021
Freso
Thanks to everyone who gave reviews and participated in topic discussions!
