#metabrainz

what*

🤞

Other than that I tried to contribute towards reviews

Today I started with my pending LB tasks

Thats it for me. ruaok go!

k

as Mr_Monkey and alastairp already suggested, there was a lot of LB and general infrastructure improvements.

improving LB dumps, fixing stats for some users, moving jenkins off cage, renaming badly named containers.

Also reviews and loads of little things here and there. getting lots done, but not making much progress on my goals, lol.

hopefully we an put a lot of this infrastructure hacking to bed soon and get back to wasting time on other projects. :)

not much on the MeB front, nice and quiet for a change.

fin. zas?

hey

among notable things, I fixed a mailing issue on discourse

(People still up: Freso, yvanzo, bitmap, diru1100, _lucifer – anyone else who wants to give review, let me know ASAP!)

after an upgrade emails were stuck in queue due to a small (incompatible) change in discourse

I also identified the problem with trille, it seems it's a kernel issue, related to cpu control, all are stuck at lowest speed

a reboot is required, yvanzo is working on making it possible

Also worked on git2consul alternative, I have something working, not production ready yet thouh

!m yvanzo

You're doing good work, yvanzo!

thanks for taking that on

I also fixed an issue with our blacklist / ipset stuff, where whitelisted IPs could actually be blocked in rare cases

that's it for me. yvanzo?

thanks!

hi all!

ohh, neat!

re: trille

Last week Ir eviewed some PRs for beta.

As reosarevok mentioned it, also investigated GSoC ideas: There are some more yet to be finalized and published.

As zas mentioned it, lately I resumed migrating RabbitMQ instance to lighten load on trille.

It should also allow to ease further migrations (for either update or server change).

Fin, go bitmap!

hey!

last week I worked a lot more on the relationship editor code

I added support for the "recent entities" list to the new Autocomplete component, which was missing when compared to the old one

this new implementation fixes issues like MBS-10498, where the stored entity info becomes stale (or the format breaks)

MBS-10498: The cached recent entities shown in the autocomplete can contain merged or removed entities that break edit submissions https://tickets.metabrainz.org/browse/MBS-10498

(Only myself and _lucifer still left on my list (diru1100 seems to not be around); last call for anyone else who may want to give review!)

!m bitmap

You're doing good work, bitmap!

also made some improvements to the relationship dialog, mostly related to MBS-7582 and switching the relationship type dropdown to use the autocomplete component

MBS-7582: add relationship: ask for entity type *before* asking for AR (sub)type https://tickets.metabrainz.org/browse/MBS-7582

(which also has the nice benefit of showing recently-used rel types there)

mostly just fixing a ton of bugs in the branch otherwise and writing commit messages

Whee

No pressure

besides that, we discussed updates to the gsoc ideas list, & reosarevok & yvanzo did all the work of actually writing the changes (thanks to both of you)

I also started a doc with small schema change ideas (i.e. nothing that requires big UI changes) and did a small amount of code review

Schema change: drop the DB

fin! Freso go

sush reo

Dropping the db? Finally!

CatQuest: eh, imagine, you could do easy edits again!

nei

o/

Ok, ok, let's let Freso talk

radical nosql ^^

Not much to talk about, tbh. :\ Another quiet, lurky week from me. Did poke a teeny bit at some reports.

fin.

_lucifer: Take it away.

Hi all!

hi!

As alastairp mentioned, I worked with him on testing BU with downstream apps.

I also worked on some PRs to improve the cache module and another one for fixing a bug in LB recent listens page.

Futher, I am familiarizing myself with the LB spark infrastructure to contribute to it in the near future.

That's it for me.

!m _lucifer

You're doing good work, _lucifer!

Alrighty-o.

That wraps up the Reviews section.

I removed topics from ruaok and reosarevok because I think those were old and just didn’t get removed from last week, if not, please let me know (or just readd them yourselves).

But there is still one more topic on the agenda…

Which was my probably old topic? :D

well, it was actually current

(GSoC)

alastair: CB-408

CB-408: Decide what to do if we have reviews of items deleted from the MB database https://tickets.metabrainz.org/browse/CB-408

(gsoc might still need to be talked in any case)

Oh, the google one? Yeah, done

which is why I didn't remove it.

alastairp: ^

hi. I was looking at some bugs that I had opened on CB, and some associated PRs. trying to work out why things work the way that it does

I took a further look at it, and as far as I can tell, there is support in CB to continue showing reviews even if the underlying item in MB has been deleted

see for example https://critiquebrainz.org/release-group/cccccc...

Hmm. If something has been deleted, do you have any data left other than an MBID?

well, we have the contents of the review

but not any other metadata

Sure, but anything that lets you map it to something

Hmm

Then I'd at least hide them

Might not drop them, and tell the user "hey, your review X is of an item now deleted, see if you want to copy it to a different, existing item?"

I don't know exactly what the reasoning behind this was

yeah, if it was to ensure that we don't remove reviews?

i like reo's idea

Was it intentionally done that you can tell?

Maybe nobody thought of items getting deleted

I can dig into the history to see if I can work that out. From what I can see in the existing code it was intentional, and this is the only motivation for doing it that I can think of

I think it's sensible to not remove reviews due to something the reviewer has no control over

however, there's been a _lot_ of copy/paste code as we've been adding new entities, and it's not been copied correctly

But showing it with no metadata is useless

i'd sure has hell get annoyed if a thoguht out review of mine were removed jsut becasue whatever it was would be

So yeah, IMO keep it but hidden and let the reviewer do something with it

Whether pick a new entity if that's something you want to support, or just copy-paste it elsewhere by hand

yes, right. I'm unsure about copying further metadata over though, because the whole point of MB database integration was so that we didn't have to do this

Agreed

the main question I want to ask is:

If they can't figure out from the review what it was, it's probably not worth keeping for them anyway :D

does it make sense to remove all of this special-casing code for "unknown entities"?

as a part of this we can add the ability for people to re-assign reviews to new entities if required

I think yeah we should do that.

That seems sensible to me

> add the ability for people to re-assign reviews to new entities

oh yes!

If someone screams, you have git history

(they likely won't)

ok, thanks. thatll help some reviews go more cleanly

thanks

+1

CatQuest: though, only in the special case that the entity has been deleted from MB

thanks. Freso: next?

if removing this code solves current problems, yes.

alastairp: hmm

Thanks alastairp :)

ruaok: GSoC

there were strange things in CB I couldn't dissuade genlecat from.

so, gsoc: thanks to Mr_Monkey and reosarevok for working up MB and BB's ideas pages. great!

ruaok: yeah, I think that's the case in some things. It _could_ happen so we have to support it. when it turns out that just manually fixing something when it comes up 3 times a decade is enough

outsidecontext will work on the picard page this week, which leaves alastairp to promise again this week that he will do it this week.

I've been drafting some tasks last week. I didn't mention it in reviews sorry

alastairp: the deadline is on the 19th, so can you please make the page at least believable for the time being?

doesn't have to be super fleshed out.

Who is doing the applying? Freso?

yep, will copy my draft ideas over tomoorow

reosarevok: I assume ruaok.

reosarevok: I am.

Oh, ok

alastairp: great, thanks

I always forget that bit

fin, freso.

regarding MusicBrainz Android, I have received a few queries on my email. I have redirected them to the channel. I do now have any particular ideas to make a suitable GSoC project but I'll be happy to mentor if any of the applicants come up with one.

We'll have a couple more ideas but it seems fine IMO

*do not

Alright, that wraps up today’s meeting!

_lucifer: you're still a student, yes?

Thanks to everyone who gave reviews and participated in topic discussions!