ok. fixed and deployed. sentry seems clear. but will need to check the db to confirm if it worked.
2021-03-08 06740, 2021
sumedh joined the channel
2021-03-08 06714, 2021
sampsyo has quit
2021-03-08 06745, 2021
sampsyo joined the channel
2021-03-08 06725, 2021
ruaok
Mooin!
2021-03-08 06745, 2021
ruaok
_lucifer: i will check once I am in BCN again, this afternoon.
2021-03-08 06702, 2021
ruaok
Do you have stuff to work on in the meantime?
2021-03-08 06715, 2021
_lucifer
great, thanks!
2021-03-08 06732, 2021
_lucifer
yes need to resolve the merge conflicts on the follow feature PR
2021-03-08 06750, 2021
ruaok
Ok
2021-03-08 06725, 2021
_lucifer
also, amending tests that are using hardcoded values so that we can restrict searching listens to the last 6 months and not go to the medivial times :p
2021-03-08 06752, 2021
yvanzo
good time of the day
2021-03-08 06752, 2021
CatQuest has quit
2021-03-08 06727, 2021
CatQuest joined the channel
2021-03-08 06727, 2021
CatQuest has quit
2021-03-08 06727, 2021
CatQuest joined the channel
2021-03-08 06700, 2021
MajorLurker joined the channel
2021-03-08 06727, 2021
MajorLurker has quit
2021-03-08 06729, 2021
pristine___
ruaok: hey
2021-03-08 06703, 2021
_lucifer
Mr_Monkey: I have fixed the conflicts. The RecentListens.tsx file had a few conflicts. Can you please take a look at that file again?
2021-03-08 06714, 2021
Mr_Monkey
Hiya !
2021-03-08 06741, 2021
Mr_Monkey
Yes, I was actually looking at 1296 as we speak, thanks for cleaning it up !
ruaok: alastairp: iliekcomputers: Mr_Monkey: how about doing a release today? we have a ws bugfix, ui improvements for timestamp and follow feature removal. plus i can test my changes in spotify reader ;).
2021-03-08 06725, 2021
Mr_Monkey
I'm all for it
2021-03-08 06700, 2021
iliekcomputers
sounds good to me
2021-03-08 06703, 2021
alastairp
nice, sure thing
2021-03-08 06743, 2021
alastairp
_lucifer: depending on what your plans are, and what you've discussed with ruaok, you and I can have a bit of a chat about AB today too
2021-03-08 06706, 2021
ruaok
All good by me. If you want help doing that, I'll be fully online in 2-3 hours.
2021-03-08 06740, 2021
_lucifer
awesome, i'll get to it soon.
2021-03-08 06733, 2021
_lucifer
alastairp: we didn't discuss anythin in particular about AB. but I think the starting would to improve MeB admin interface?
ah, yeah. when we met in the office last Monday we talked about a lot of things, including the admin interface, and the plans for api keys and auth - that kind of merged into the oauth document that I started. later this afternoon we can straighten out all of the plans
ruaok: I think that prototyping the oauth could be a neat idea
2021-03-08 06718, 2021
ruaok
But easier to define things for meb could be tackled. E.g update node and python dependencies.
2021-03-08 06751, 2021
ruaok
alastairp: I'm fine with that, but am trying to address your lament that AB gets little love.
2021-03-08 06705, 2021
ruaok
Doing oauth is good for everyone, though.
2021-03-08 06707, 2021
alastairp
I'm planning on doing AB from next week anyway
2021-03-08 06715, 2021
ruaok
Ok, kewl.
2021-03-08 06727, 2021
alastairp
so I'm happy to get _lucifer working on it at a later stage
2021-03-08 06738, 2021
ruaok
_lucifer: you could work on the node upgrade when you have some spare time.
2021-03-08 06718, 2021
alastairp
for me, the oauth stuff is still full of a lot of unknowns, but I think having a prototype will help us work out what works and what needs to be revisited
2021-03-08 06722, 2021
ruaok
Ok, sounds like a rough plan for the week.
2021-03-08 06723, 2021
_lucifer
sure
2021-03-08 06726, 2021
alastairp
_lucifer: ever worked with oauth before? :)
2021-03-08 06741, 2021
ruaok
Agreed, on prototype.
2021-03-08 06757, 2021
_lucifer
not much, only what we have in the android app, alastairp
2021-03-08 06748, 2021
alastairp
feel free to add questions to that document. let's talk about it in ~2 hours
_lucifer: yes, right. as I said, I'll start looking at AB stuff next week too. There are 4-5 half-finished projects that I want to get released in the next 3 months
2021-03-08 06710, 2021
alastairp
as you can see, there are lots of projects, lots of ideas, and not many programmers :) you're a great asset to help us get through these plans...
2021-03-08 06734, 2021
_lucifer
:-D
2021-03-08 06711, 2021
_lucifer
alastairp: regarding the release, should i tag before or after merging master into production or does it not matter?
2021-03-08 06757, 2021
alastairp
I've not really thought about that much before. theoretically it should be the same
2021-03-08 06714, 2021
alastairp
(unless for some reason production has some other commits or weird commit order that master doesn't have)
this is for an earlier release. i can update it or open a new one
2021-03-08 06730, 2021
_lucifer
we updated dependencies so i think it makes sense to restart all services except cron. excluding spark reader as well because that is running a different branch currently.
2021-03-08 06731, 2021
alastairp
just approved 140, let's merge that and then do another one for this release
2021-03-08 06739, 2021
_lucifer
👍
2021-03-08 06710, 2021
alastairp
sounds fine to me to update all of those services. why do you not want to upgrade cron?
2021-03-08 06738, 2021
alastairp
when do you think that we'll be able to merge the spark reader branch?
2021-03-08 06758, 2021
_lucifer
no changes to cron so i thought no need to update that
2021-03-08 06725, 2021
_lucifer
hopefully sometime later this week. ruaok can probably provide a better estimate on that
2021-03-08 06710, 2021
alastairp
ok, no problem. If this is going to be a common occurrence going forward maybe we need to think about splitting some things into separate images. Let's not worry about it for now
