akshaaatt[m]: Yes, I would say the tagger fix alone itself is enough for a release. Regarding obfuscation, the application is only ~10-15MB currently, we can try it but I would say it is not a priority.
Lartza has left the channel
sumedh joined the channel
akshaaatt[m]
<_lucifer "akshaaatt: Yes, I would say the "> Right!
sumedh has quit
_lucifer: Any final opinions on my proposal? Since it's my first time in GSoC, I want to be extra cautious 😇
akshaaatt[m]: a lil suggestion. For the sear h page revamp icons it would be great if we can use an icon pack which can match the color scheme of the app or metabrainz in general. Currently they look a lil different from each other
akshaaatt[m]
<shivam-kapila "akshaaatt: a lil suggestion. For"> Right, I get that! Will make sure I discuss about the relevant icons and implementation while working on the project then 😇 Thanks for the suggestion!
akshaaatt[m]: The proposal looks good to me. No further suggestions.
akshaaatt[m]
hahaha XD I just googled this and landed on bitly.com Thanks, will tend to use this in future 😀
<_lucifer "akshaaatt: The proposal looks go"> Thankyou! 😇
_lucifer: Two more questions, while testing the CollectionViewModel, should I test all the possible scenarios as given here https://musicbrainz.org/doc/MusicBrainz_API under the collections entity? Secondly, How do I check whether my tests are working/fine or not?
_lucifer
akshaaatt[m]: for now, one public and one private is enough. i do not understand the second question, if the tests pass they should be working fine?
also in case you get some weird errors try replacing `runBlockingTest` with `runBlocking` and see if that helps.
akshaaatt[m]
Okaaay! I'll work on it a bit more and in case I run into issues then, will let you know 🙂