#metabrainz

yvanzo your upgrade instructions are bad

musicbrainz@wibble:/restore/musicbrainz/musicbrainz-docker$ admin/setup-admin-triggers clean

-bash: admin/setup-admin-triggers: No such file or directory

I'm on v-2021-04-19 currently

Is that setup-admin-triggers supposed to be setup-amqp-triggers ?

Does JIRA still support login with Musicbrainz? I didn't see the button that used to be there...

musicbrainz@wibble:/restore/musicbrainz/musicbrainz-docker$ admin/configure add admin/lib/upgrade-db-schema/musicbrainz-stopped.sql

configure: unknown file/handle: 'admin/lib/upgrade-db-schema/musicbrainz-stopped.sql'

Try 'configure help' for usage.

Another failure. So much for testing stuff.

Maybe you mean musicbrainz-stopped-yml ?

Nah, it's fuxed.

ruaok: alastairp: i guess you already got the mail :). i looked into it. the dump happened but could not get copied to ftp folder.

mkdir: cannot create directory ‘/home/lbdumps/ftp/incremental/listenbrainz-dump-441-20210520-000002-incremental’: Permission denied

i checked and found that `/home/lbdumps/ftp/incremental/` is owned by the root user

https://github.com/metabrainz/listenbrainz-serv... , it failed while creating the directory.

i think we created the ftp directory with wrong permissions during recovering the dumps after lemmy went down.

nelgin: Fixed these two typos

yyoung: Yes, it is still supported, along with Sign in with GitHub.

yyoung: That might be a display issue if you don’t see the “MusicBrainz” and “GitHub” buttons. Can you please make a screenshot?

yvanzo: Here it is: https://imgur.com/a/o04jdhs

yyoung: and if you click on the “Log In” button at the top left?

top right, sorry :)

Seems the same: https://imgur.com/a/YpAs9mH

yyoung: might it be some javascript is blocked by your webbrowser?

IIRC it was fine before and I didn't change anything since then, I'll have a look

yyoung: The script batch.js must be able to query getconfig to retrieve the extra buttons.

yvanzo: It works fine under Chrome incognito mode, in normal mode I can still see a successful request to getconfig, but there's a "RPC: request rejected (bad origin): https://tickets.metabrainz.org"; message in the console

yyoung: might be caused by an add-on that is enabled in normal mode only, try disabling it if possible.

yvanzo: Yes, I'll have a check, thank you

OK, let me take a look

hi _lucifer

cool, so we know that the email works, and we know that the dump works with the storage box

yvanzo, vacuuming db is running now.

Hi alastairp!

yes, right.

_lucifer: I'm just reading the dump file again. so it did the dump to the temp directory, and then copied it to the backup dir, then failed to copy it again to the ftp dir?

ah yes, I see the incremental dump in the backups directory

I see the permissions on ftp directory being owned by root. that's interesting.

alastairp: yes. it failed while trying to create a directory under ftp.

so yes, I think it makes sense to change that back, I'll run through the dump process again to check

right my guess is that this got mixed when lemmy went down and dumps were recovered.

there are two additional changes we could make: 1) add some explicit checks at the beginning of the dump like we do for tmp location - check that the permissions of all dump locations are correct and that we can expect to continue

2) integrate sentry bash so that in case of an error we get an explicit notification instead of having to go back and look through the logs

Thu 20 May 2021 06:53:36 AM UTC : UPDATE THE DB_SCHEMA_SEQUENCE IN DBDefs.pm TO 26 !

Very good.,

Can't locate List/AllUtils.pm in @INC (you may need to install the List::AllUtils module) (@INC contains: /musicbrainz-server/admin/../lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base)

at ./admin/BuildMaterializedTables line 10.

BEGIN failed--compilation aborted at ./admin/BuildMaterializedTables line 10.

Looks like a new dependency?

Looks like the docker is missing liblist-allutils-perl - How do I install it?

yvanzo that was trying to run "sudo docker-compose exec musicbrainz ./admin/BuildMaterializedTables --database=MAINTENANCE all" btw

nelgin: sudo docker-compose exec musicbrainz bash -c "./admin/BuildMaterializedTables --database=MAINTENANCE all" # instead

alastairp: +1 to adding sentry. regarding permission checks, we do have https://github.com/metabrainz/listenbrainz-serv... , we probably want to improve this check.

not sure what chown does for a non-existent directory. so just rearranging the checks probably won't be enough.

(This isn’t a new dependency, rather an environment issue.)

_lucifer: the problem is that this script runs as `lbdumps`, so if the ftp dir is owned by root, lbdumps can't do anything

which is interesting... maybe we could have a discussion to see if we run this as _root_, then we could make all of the necessary permission changes if needed. We can force the python scripts to run as a particular user if we want

let me put it on th elist

makes sense.

for now, we change the owner of the ftp manually ?

yeah, I'll double-check that today

cool, thanks!

ruaok, _lucifer (if you get support emails): see the latest email re: LB

What happens if someone was to recreate their MB account with the same username? Would their LB account work again?

(if they have removed their MB account in the meantime)

no, I do not get support emails. i am not sure if deleting MB account also leads to deletion of LB account?

if no, then LB account would work again.

yvanzo ok that seems to be working.

Trying to update my container too, it's failing at step 22, trying to update yarn keys. Any thoughts?

This is the error: https://paste.debian.net/1198204/

Connection reset by peer, an issue at the remote server?

Getting different errors each time. As far as I can tell my network connection is Ok.

nelgin: Did you manage to complete the upgrade?

adhawkins: that happens when building 'musicbrainz' image?

That's correct yvanzo.

Actually, let me just double check.

Yes, the error is 'service musicbrainz failed to build'

You can see that in the pastebin: https://paste.debian.net/1198204/

I'm getting a slightly different error now: curl: (18) transfer closed with 19745107 bytes remaining to read

I’m rebuilding it just in case that is a new yarn issue but that is more likely a transient network/load keyserver issue.

I thought it was a transient issue too, but it seems fairly repeatable here.

adhawkins: I have no issue here.

:(

This is the command that's failing: curl -sSLO --retry 5 https://deb.nodesource.com/node_16.x/pool/main/...

ok

[listenbrainz-server] amCap1712 closed pull request #1463 (master…master): Use docker buildx to build production images https://github.com/metabrainz/listenbrainz-serv...

So why won't it run inside docker? It's worked in the past...

Grrr...

it should eventually work inside the build

does it reliably work from the host, or maybe you were lucky?

do you use the same curl command from the host,

?

Yes, it works reliably on the host, and is now seemingly quicker.

I copied the command from the 'RUN' line echo'd during the build, and just replaced the NODE_VERSION variable with 1.16.0

16.1.0

Good spot. Just re-trying.

That works. It's slow again though.

When I say it works, I mean I can execute the curl command in the host.

adhawkins: two potential workarounds: either add options (--retry 10 --speed-limit 30 --speed-time 60 ) to that curl command, or copy the file you already download to build resources.

Already tried with retries 50, will add the speed ones too.

That is the main issue: Speed is too slow for you when downloading from nodesource.com.

Not sure what you mean about copying to build resources?

Speed switches didn't help.

This is definitely a load issue, your IP might not be redirected to the same nodesource server as we do.

nodejs_16.1.0-deb-1nodesource1_amd64.deb

cp nodejs_16.1.0-deb-1nodesource1_amd64.deb

To where?

cp nodejs_16.1.0-deb-1nodesource1_amd64.deb build/musicbrainz/

But the curl command still runs?

that is not all :)

Ah :)

in build/musicbrainz/Dockerfile, line 58, insert: COPY nodejs_16.1.0-deb-1nodesource1_amd64.deb /

Think I worked that out. Need to be copied to /tmp though.

Ok, it's got past that stage now.

Odd.

remove the line 87 (or 88 now) with the curl command

Yep, seems to have sorted it. At least, that section :)

Build continuing now.

/tmp or . would work too I guess :)