baniket: First off, your proposal was very well presented, with good quality mockups, which I appreciate. It was a good sign of your affinity with design.
2019-05-06 12614, 2019
Mr_Monkey
baniket: I'm late for dinner, but I'll answer tomorrow!
2019-04-11 10124, 2019
Freso
baniket: "Should I add some comments and send a pull request?" Go for it! :)
2019-04-09 09926, 2019
Mr_Monkey
spellew, letaiv, baniket: I can confirm your final proposals are submitted
2019-04-08 09808, 2019
Mr_Monkey
baniket: I just want to see it first; i'll let you estimate the time you need
2019-04-08 09802, 2019
Freso
baniket: If you want to.
2019-04-08 09828, 2019
Mr_Monkey
baniket: That's better. If the table describes items in a collection rather than a list, then collection_item might be better?
2019-04-01 09150, 2019
Mr_Monkey
Sure baniket
2019-04-01 09106, 2019
Mr_Monkey
Hi baniket! I was actually having a look at it :)
2019-03-29 08810, 2019
Mr_Monkey
Hi baniket ! I'm not forgetting you. I started noting down some thoughts and finishing it is on my list for today :)
baniket: I'm OK with that. Maybe a searchable dropdown would be more appropriate for the collection selection?
2019-03-23 08243, 2019
Mr_Monkey
baniket: I think both would work, to be honest. The background for the modal would definitely need to be transparent. That's currently the case on the website, though, I don't know why you're seeing it differently. Try editing an entity an clicking on"add relationship", for an example of modal: https://test.bookbrainz.org/creator/9091bf36-a9dc…
2019-03-21 08056, 2019
Mr_Monkey
baniket: An "add to collection" button there definitely a good idea. I would go for only one button, and clicking on it would open a component to let you choose which collection to add to or optionally create a new one.
2019-03-21 08055, 2019
Mr_Monkey
baniket: Sorry I just saw your earlier question. In short, "the codebase was like this when I found it" :p , but personally I think it's a good idea to have to think consciously about what `this`refers to in the context of function. That being said, declaring class functions with arrow notation is fine by me
baniket, Mr_Monkey: I'm not the one running the project of course, but I feel what we have in MB (a few default collections such as "attending" and "maybe attending" for events, but letting the user make as many collections of their choice as possible) would make sense
2019-03-18 07741, 2019
Mr_Monkey
baniket: sure I'll look for it. As for the syntax, it is a mix between object destructuring and the type-checker Flow: `const {orm} = my.object` is equivalent to `const orm = my.object.orm. That's object destructuring in ES6. The `: {orm:any}` is a type annotation for Flow
2019-03-18 07720, 2019
Mr_Monkey
baniket: You're spot on
2019-03-18 07738, 2019
Mr_Monkey
baniket: Great, I'm here if you have more questions.
baniket: You’re on the right track, and I think you understand how things work despite it being more complex than react-router. The component is loaded in the backend with props fetched from the database (using the ORM you can find in the bookbrainz-data-js repo). Using those props, the component is rendered as html and sent to the client.
2019-03-18 07703, 2019
Mr_Monkey
Hi baniket! Sorry I didn't see your messages earlier. let me try and answer your questions
2019-03-14 07349, 2019
Mr_Monkey
Good luck baniket !
2019-03-14 07319, 2019
Mr_Monkey
Hi baniket ! I think you're the only one to have shown interest in that project so far.
2019-03-08 06723, 2019
Mr_Monkey
baniket: None I can find in my history…
2019-03-08 06728, 2019
Mr_Monkey
baniket: I think tutorials will be better suited for that than starting with th BB codebase, which is fairly complex
2019-03-08 06710, 2019
Mr_Monkey
baniket: In short, the server fetches data from the DB, creates a redux store, passes that store to a component, renders it and sends all that as HTML to the client.
2019-03-08 06704, 2019
Mr_Monkey
baniket: That's a lot to take in, I know, but it will be well worth the effort to have some understanding of how it all fits together.
2019-03-08 06725, 2019
Mr_Monkey
baniket: Ok, that's a bit clearer :) I would recommend having a look at how we load an entity (when you visit, say, an Edition's page).
2019-03-08 06703, 2019
Mr_Monkey
baniket: Storing the redux state? Why?
2019-03-08 06729, 2019
Mr_Monkey
baniket, if you read this in the future, no, that's not expected. Are you seeing any errors in the console when you run develop.sh ?
