#bookbrainz

recently the codebase was migrated from Flow to TypeScript

monkey akashgp09[m] I've created a PR for notification service, I've added subscribe/unsubscribe feature in the entity and collections page

and whenever any change is made in entity or collection an event is emitted and then `notificationsService` adds rows in the notificationTable

you can then check notifications in `editor/:id/notifcations` route

umm if you wanna run it, you'll have to run migration script in the db and also add bookshelf models that I've created in the bookbrainz-data-js repo

Nice prabaaaaal, off the starting blocks with some speed!

That was so quick.

!m prabaaaaal

You're doing good work, prabaaaaal!

:)

xDD

!m prabaaaaal

You're doing good work, prabaaaaal!

does this mean we'll be getting bookbrainz emails soon? :O

That's the idea

sweet!

Well be good to see editors get e-mails for comments like https://bookbrainz.org/revision/13183 ;)

Oh !

Indeed

monkey: i've only added notifications for `entities` and `collections`. But I guess it can be easily extended for `revisions` as well

how about you have a look at it and if the implementation looks alright to you and then I will extend it for revisions or maybe editors as well

Will do

>or maybe editors as well

What do you mean by that?

Extending it to revisions, absolutely, as Freso pointed out it would be nice to get notifications when another user comments on a revision I created or commented on

But editors?

i can get notifications if someone else creates a collection

Ah, yes, I see. Subscribe to a user to get notifications on their activity

akashgp09[m]: I forgot to commit this small refactor before merging PR #626, could you please give me a quick review when you have a minute?

sure thing!

And also since now GSoC results have been announced, congratulations on a successful summer of coding akashgp09[m] !

Thank you monkey 😇

congratulations akashgp09[m]

Thank you prabaaaaal :)

CatQuest: I've improved the detection and validation of ISBNs, which now support dashes, spaces, and formats like ISBN-13: 978-0-596-52068-7 and the badly formatted ISBNs found on the Amazon website like 978-1596875647

Deployed in prod, beta and test; if you encounter an issue with it do let me know !

oooh cool I'll test this