#bookbrainz

/

      • agatzk has quit
      • 2021-12-01 33544, 2021

      • agatzk joined the channel
      • 2021-12-01 33522, 2021

      • CatQuest joined the channel
      • 2021-12-01 33512, 2021

      • Shubh joined the channel
      • 2021-12-01 33541, 2021

      • Shubh has quit
      • 2021-12-01 33530, 2021

      • triten joined the channel
      • 2021-12-01 33556, 2021

      • triten has quit
      • 2021-12-01 33549, 2021

      • triten joined the channel
      • 2021-12-01 33508, 2021

      • triten has quit
      • 2021-12-01 33515, 2021

      • Shubh joined the channel
      • 2021-12-01 33533, 2021

      • Shubh
        BB-616, BB-598 is fixed, right?
      • 2021-12-01 33534, 2021

      • BrainzBot
        BB-616: Allow Searching by ISBN https://tickets.metabrainz.org/browse/BB-616
      • 2021-12-01 33534, 2021

      • BrainzBot
        BB-598: Achievements helpers should be rewritten with async/await syntax https://tickets.metabrainz.org/browse/BB-598
      • 2021-12-01 33541, 2021

      • Shubh has quit
      • 2021-12-01 33558, 2021

      • Shubh joined the channel
      • 2021-12-01 33557, 2021

      • monkey
        Yes, that's correct, closing them
      • 2021-12-01 33539, 2021

      • Shubh has quit
      • 2021-12-01 33537, 2021

      • Shubh joined the channel
      • 2021-12-01 33513, 2021

      • Shubh has quit
      • 2021-12-01 33518, 2021

      • Shubh joined the channel
      • 2021-12-01 33511, 2021

      • Shubh has quit
      • 2021-12-01 33506, 2021

      • Shubhhh joined the channel
      • 2021-12-01 33535, 2021

      • Shubhhh has quit
      • 2021-12-01 33543, 2021

      • Shubhhh joined the channel
      • 2021-12-01 33515, 2021

      • Shubhhh
        Hey monkey , you here?
      • 2021-12-01 33545, 2021

      • monkey
        Yo ! Currently eating, but I'll get back to you right after
      • 2021-12-01 33533, 2021

      • Shubhhh
        enjoy your meal :)
      • 2021-12-01 33550, 2021

      • monkey
        Thanks!
      • 2021-12-01 33555, 2021

      • monkey
        What can I do for you Shubhhh ?
      • 2021-12-01 33539, 2021

      • Shubhhh
        bb docker throwing timeout error at "npm install" , my network is fine. should i try removing its cache ?
      • 2021-12-01 33545, 2021

      • monkey
        I would suggest first to either pull or merge the latest changes from master, I might have fixed that issue yesterday
      • 2021-12-01 33529, 2021

      • monkey
        There is some ongoing NPM issue that we're hitting while installing one of our packages from github: https://github.com/npm/cli/issues/2610
      • 2021-12-01 33527, 2021

      • Shubhhh
        Ahh i pulled the changes today, maybe you change some dependencies in docker file and after that when i run develop.sh script it stuck at step 19 (which is npm install)
      • 2021-12-01 33529, 2021

      • monkey
        I tried something to fix that yesterday, and was able today to build your conflict-error-on-double-delete PR and publish that the test.bookbrainz.org , so I have high hopes that it will be fixed for you too
      • 2021-12-01 33511, 2021

      • monkey
        Ah, so you're hitting the issue after pulling latest changes? Do me a favor and try pulling/updating again just to confirm the current situation is not working. I'll do the same here.
      • 2021-12-01 33552, 2021

      • Shubhhh
        Hmm on it
      • 2021-12-01 33512, 2021

      • monkey
        I'm running this command locally: `docker-compose build --no-cache bookbrainz-site`
      • 2021-12-01 33519, 2021

      • Shubhhh
        and wait i will do the same then
      • 2021-12-01 33509, 2021

      • monkey
        Man, I've got to do something to improve those image build times…
      • 2021-12-01 33526, 2021

      • monkey
        npm install just runs forever…
      • 2021-12-01 33506, 2021

      • Shubhhh
        Yeah, yarn good npm bad
      • 2021-12-01 33528, 2021

      • monkey
        And it errored: errno ERR_SOCKET_TIMEOUT
      • 2021-12-01 33528, 2021

      • monkey
        `npm ERR! request to https://registry.npmjs.org/camelcase/-/camelcase-… failed, reason: Socket timeout`
      • 2021-12-01 33516, 2021

      • Shubhhh
        i got the same error last time :'
      • 2021-12-01 33533, 2021

      • monkey
        For the same package name?
      • 2021-12-01 33555, 2021

      • Shubhhh
        No, not the same package but same socket timeout error
      • 2021-12-01 33513, 2021

      • Shubhhh
        is there any way around this like using yarn or something
      • 2021-12-01 33550, 2021

      • monkey
        Worth a try…
      • 2021-12-01 33555, 2021

      • monkey
        Let me try that quickly
      • 2021-12-01 33524, 2021

      • Shubhhh
        any progress?
      • 2021-12-01 33530, 2021

      • monkey
        Oop, forgot it was running :) Yes, that finished successfully !
      • 2021-12-01 33536, 2021

      • monkey
        And much quicker.
      • 2021-12-01 33550, 2021

      • monkey
        Let me open a PR, and maybe you'd be keen to help me test it out?
      • 2021-12-01 33528, 2021

      • Shubhhh
        Yes i replace npm install with yarn install
      • 2021-12-01 33521, 2021

      • Shubhhh
        yes , i am ready to test it!
      • 2021-12-01 33505, 2021

      • monkey
        PR almost ready
      • 2021-12-01 33500, 2021

      • monkey
      • 2021-12-01 33549, 2021

      • Shubhhh
        Yep!
      • 2021-12-01 33503, 2021

      • monkey
        I still get this message sometimes, but I suspect I do have some internet issues:
      • 2021-12-01 33503, 2021

      • monkey
        > # info There appears to be trouble with your network connection. Retrying...
      • 2021-12-01 33530, 2021

      • Shubhhh
        Yes thats maybe normal with yarn, happend with me several times mostly due to slow internet connection.
      • 2021-12-01 33543, 2021

      • monkey
        But it does succeed. `RUN yarn install 279.7s`
      • 2021-12-01 33544, 2021

      • Shubhhh
        now website is working in my local machine , yarn so good and fast
      • 2021-12-01 33555, 2021

      • monkey
        It is significantly faster, thanks for the suggestion ! I had been on the fence about yarn and hadn't previously seen a lot of difference, good to see it has evolved do much
      • 2021-12-01 33503, 2021

      • monkey
        I'm hitting some linting issues when I build the image for production, but I'm guessing probably because of a newer eslint version (the package-lock.json file is ignored by yarn)
      • 2021-12-01 33517, 2021

      • monkey
        Anyway, nothing insurmountable
      • 2021-12-01 33548, 2021

      • Shubhhh
        Yep!
      • 2021-12-01 33551, 2021

      • Shubhhh has quit
      • 2021-12-01 33508, 2021

      • Shubhhh joined the channel
      • 2021-12-01 33555, 2021

      • Shubhhh has quit
      • 2021-12-01 33528, 2021

      • Shubh joined the channel
      • 2021-12-01 33557, 2021

      • Shubh has quit
      • 2021-12-01 33506, 2021

      • monkey
        OK, well that PR #730 is ready. Shubh, if you find a bit of time I'd appreciate it if you had another check to see if everything build fine for you.