Leftmost: As pointed out this is common issue with identifier editor and regex detection in general, i believe rather than hacking around the regex detection, we should have simple "turn off" checkbox to disable this behavior.
2022-04-01 09159, 2022
Leftmost
Shubh, there are some issues with that, yeah, but I think they're exacerbated by taking automatic action when we detect an ISBN and we should probably be more liberal in deciding when two ISBNs are equal. (If we have 978-0-15-603521-7, we shouldn't add 97806035217.) And I think rather than putting the responsibility on users to disable the behavior, we should probably be checking if something is a valid ISBN rather than
2022-04-01 09159, 2022
Leftmost
relying on regex when ISBNs aren't a regular language.
2022-04-01 09143, 2022
cloverfield joined the channel
2022-04-01 09121, 2022
Shubh
I think we can verify the last digit of ISBN using checksum algorithm when detecting for identifier type
2022-04-01 09149, 2022
Shubh
but that doesn't solve the issue for other types we might have in future...
2022-04-01 09151, 2022
asymmentric joined the channel
2022-04-01 09141, 2022
asymmentric has quit
2022-04-01 09104, 2022
asymmentric joined the channel
2022-04-01 09138, 2022
CatQuest joined the channel
2022-04-01 09117, 2022
CatQuest has quit
2022-04-01 09158, 2022
CatQuest joined the channel
2022-04-01 09105, 2022
asymmentric has quit
2022-04-01 09125, 2022
asymmentric joined the channel
2022-04-01 09157, 2022
kellnerd joined the channel
2022-04-01 09126, 2022
asymmentric has quit
2022-04-01 09126, 2022
Shubh
monkey: i'm facing some issues with adding bookbrainz orm from github branch, any idea on how prabal did it?
But generally, if you have both repos locally, you can run `npm link` in the ORM and then `npm link bookbrainz-data` in bookbrainz-site to use your local version
2022-04-01 09101, 2022
monkey
(note that if you install nay package after that you'll need to re-link)
2022-04-01 09103, 2022
asymmentric joined the channel
2022-04-01 09155, 2022
CandyBrain joined the channel
2022-04-01 09130, 2022
asymmentric11 joined the channel
2022-04-01 09150, 2022
asymmentric11 has quit
2022-04-01 09142, 2022
asymmentric has quit
2022-04-01 09144, 2022
CandyBrain has left the channel
2022-04-01 09108, 2022
agatzk has quit
2022-04-01 09117, 2022
agatzk joined the channel
2022-04-01 09141, 2022
kellnerd has quit
2022-04-01 09135, 2022
agatzk has quit
2022-04-01 09142, 2022
agatzk joined the channel
2022-04-01 09138, 2022
ShivamAwasthi joined the channel
2022-04-01 09138, 2022
ShivamAwasthi
Shubh are you still facing the issue? I always forget to install the dependencies before linking. 👀
