#bookbrainz

/

      • prabaaaaal has quit
      • 2021-09-01 24424, 2021

      • akashgp09[m]
        recently the codebase was migrated from Flow to TypeScript
      • 2021-09-01 24430, 2021

      • akashgp09[m]
      • 2021-09-01 24420, 2021

      • prabaaaaal joined the channel
      • 2021-09-01 24444, 2021

      • prabaaaaal
        monkey akashgp09[m] I've created a PR for notification service, I've added subscribe/unsubscribe feature in the entity and collections page
      • 2021-09-01 24428, 2021

      • prabaaaaal
        and whenever any change is made in entity or collection an event is emitted and then `notificationsService` adds rows in the notificationTable
      • 2021-09-01 24400, 2021

      • prabaaaaal
        you can then check notifications in `editor/:id/notifcations` route
      • 2021-09-01 24422, 2021

      • prabaaaaal
        umm if you wanna run it, you'll have to run migration script in the db and also add bookshelf models that I've created in the bookbrainz-data-js repo
      • 2021-09-01 24434, 2021

      • monkey
        Nice prabaaaaal, off the starting blocks with some speed!
      • 2021-09-01 24426, 2021

      • akashgp09[m]
        That was so quick.
      • 2021-09-01 24431, 2021

      • akashgp09[m]
        !m prabaaaaal
      • 2021-09-01 24432, 2021

      • BrainzBot
        You're doing good work, prabaaaaal!
      • 2021-09-01 24450, 2021

      • prabaaaaal
      • 2021-09-01 24451, 2021

      • prabaaaaal
        :)
      • 2021-09-01 24453, 2021

      • prabaaaaal
        xDD
      • 2021-09-01 24445, 2021

      • monkey
      • 2021-09-01 24452, 2021

      • CatQuest
        !m prabaaaaal
      • 2021-09-01 24452, 2021

      • BrainzBot
        You're doing good work, prabaaaaal!
      • 2021-09-01 24425, 2021

      • CatQuest
        does this mean we'll be getting bookbrainz emails soon? :O
      • 2021-09-01 24440, 2021

      • monkey
        That's the idea
      • 2021-09-01 24445, 2021

      • CatQuest
        sweet!
      • 2021-09-01 24446, 2021

      • Freso
        Well be good to see editors get e-mails for comments like https://bookbrainz.org/revision/13183 ;)
      • 2021-09-01 24451, 2021

      • monkey
        Oh !
      • 2021-09-01 24453, 2021

      • monkey
        Indeed
      • 2021-09-01 24430, 2021

      • prabaaaaal
        monkey: i've only added notifications for `entities` and `collections`. But I guess it can be easily extended for `revisions` as well
      • 2021-09-01 24430, 2021

      • prabaaaaal
        how about you have a look at it and if the implementation looks alright to you and then I will extend it for revisions or maybe editors as well
      • 2021-09-01 24434, 2021

      • monkey
        Will do
      • 2021-09-01 24450, 2021

      • monkey
        >or maybe editors as well
      • 2021-09-01 24450, 2021

      • monkey
        What do you mean by that?
      • 2021-09-01 24438, 2021

      • monkey
        Extending it to revisions, absolutely, as Freso pointed out it would be nice to get notifications when another user comments on a revision I created or commented on
      • 2021-09-01 24444, 2021

      • monkey
        But editors?
      • 2021-09-01 24400, 2021

      • prabaaaaal
        i can get notifications if someone else creates a collection
      • 2021-09-01 24433, 2021

      • monkey
        Ah, yes, I see. Subscribe to a user to get notifications on their activity
      • 2021-09-01 24445, 2021

      • monkey
        akashgp09[m]: I forgot to commit this small refactor before merging PR #626, could you please give me a quick review when you have a minute?
      • 2021-09-01 24449, 2021

      • monkey
      • 2021-09-01 24453, 2021

      • akashgp09[m]
        sure thing!
      • 2021-09-01 24406, 2021

      • monkey
        And also since now GSoC results have been announced, congratulations on a successful summer of coding akashgp09[m] !
      • 2021-09-01 24425, 2021

      • akashgp09[m]
        Thank you monkey 😇
      • 2021-09-01 24419, 2021

      • prabaaaaal
        congratulations akashgp09[m]
      • 2021-09-01 24455, 2021

      • akashgp09[m]
        Thank you prabaaaaal :)
      • 2021-09-01 24414, 2021

      • monkey
        CatQuest: I've improved the detection and validation of ISBNs, which now support dashes, spaces, and formats like ISBN-13: 978-0-596-52068-7 and the badly formatted ISBNs found on the Amazon website like 978-1596875647
      • 2021-09-01 24402, 2021

      • monkey
        Deployed in prod, beta and test; if you encounter an issue with it do let me know !
      • 2021-09-01 24404, 2021

      • CatQuest
        oooh cool I'll test this
      • 2021-09-01 24406, 2021

      • prabaaaaal has quit