#bookbrainz

BB-616, BB-598 is fixed, right?

BB-616: Allow Searching by ISBN https://tickets.metabrainz.org/browse/BB-616

BB-598: Achievements helpers should be rewritten with async/await syntax https://tickets.metabrainz.org/browse/BB-598

Yes, that's correct, closing them

Hey monkey , you here?

Yo ! Currently eating, but I'll get back to you right after

enjoy your meal :)

Thanks!

What can I do for you Shubhhh ?

bb docker throwing timeout error at "npm install" , my network is fine. should i try removing its cache ?

I would suggest first to either pull or merge the latest changes from master, I might have fixed that issue yesterday

There is some ongoing NPM issue that we're hitting while installing one of our packages from github: https://github.com/npm/cli/issues/2610

Ahh i pulled the changes today, maybe you change some dependencies in docker file and after that when i run develop.sh script it stuck at step 19 (which is npm install)

I tried something to fix that yesterday, and was able today to build your conflict-error-on-double-delete PR and publish that the test.bookbrainz.org , so I have high hopes that it will be fixed for you too

Ah, so you're hitting the issue after pulling latest changes? Do me a favor and try pulling/updating again just to confirm the current situation is not working. I'll do the same here.

Hmm on it

I'm running this command locally: `docker-compose build --no-cache bookbrainz-site`

and wait i will do the same then

Man, I've got to do something to improve those image build times…

npm install just runs forever…

Yeah, yarn good npm bad

And it errored: errno ERR_SOCKET_TIMEOUT

`npm ERR! request to https://registry.npmjs.org/camelcase/-/camelcas... failed, reason: Socket timeout`

i got the same error last time :'

For the same package name?

No, not the same package but same socket timeout error

is there any way around this like using yarn or something

Let me try that quickly

any progress?

Oop, forgot it was running :) Yes, that finished successfully !

And much quicker.

Let me open a PR, and maybe you'd be keen to help me test it out?

Yes i replace npm install with yarn install

yes , i am ready to test it!

PR almost ready

Here it is Shubhhh: https://github.com/bookbrainz/bookbrainz-site/p...

Yep!

I still get this message sometimes, but I suspect I do have some internet issues:

> # info There appears to be trouble with your network connection. Retrying...

Yes thats maybe normal with yarn, happend with me several times mostly due to slow internet connection.

But it does succeed. `RUN yarn install 279.7s`

now website is working in my local machine , yarn so good and fast

It is significantly faster, thanks for the suggestion ! I had been on the fence about yarn and hadn't previously seen a lot of difference, good to see it has evolved do much

I'm hitting some linting issues when I build the image for production, but I'm guessing probably because of a newer eslint version (the package-lock.json file is ignored by yarn)

Anyway, nothing insurmountable

Yep!

OK, well that PR #730 is ready. Shubh, if you find a bit of time I'd appreciate it if you had another check to see if everything build fine for you.