#bookbrainz

/

      • Shubh joined the channel
      • 2021-12-02 33612, 2021

      • Shubh
        everything looking good, docker image build with few warnings but much faster than npm .
      • 2021-12-02 33619, 2021

      • Shubh
        i think we should also get rid of npm run in package.json and use yarn run instead ..
      • 2021-12-02 33643, 2021

      • Shubh
        although that should not make any difference but still
      • 2021-12-02 33600, 2021

      • Shubh
        Hey CatQuest
      • 2021-12-02 33623, 2021

      • CatQuest
        hm?
      • 2021-12-02 33637, 2021

      • Shubh
        Would it better if we suggest language based on starting characters , here BB-407
      • 2021-12-02 33638, 2021

      • BrainzBot
        BB-407: Simplify "No linguistic content" selection https://tickets.metabrainz.org/browse/BB-407
      • 2021-12-02 33606, 2021

      • Shubh
        and is it okay if i push the " No Linguistic content " up the options List (which passed down to react-select) manually like below Multi Language
      • 2021-12-02 33611, 2021

      • CatQuest
        uh
      • 2021-12-02 33632, 2021

      • CatQuest
        I'd just want to see it while typing "no"
      • 2021-12-02 33620, 2021

      • CatQuest
        also [multi] should maybe be removed (since we already *can* select several languages) (tho not fortitle, so thatmiht need fixing)
      • 2021-12-02 33632, 2021

      • CatQuest
        also i'd like a listof them ost comonly used (like on mb) and under this [no linguistic], [multiple] (if we keep it) as well as [artificial (other)] since title or language could be in some language that doesn't exist/was created only for this book, and we can't add a one-book language
      • 2021-12-02 33611, 2021

      • Shubh
        Hmm , we can do custom language thing where user can create one if he didn't find desired language in options
      • 2021-12-02 33629, 2021

      • CatQuest
        hahaha no.
      • 2021-12-02 33609, 2021

      • Shubh
        when user type no wouldn't it be good if we suggest him option like north .. , user generally won't search for "no linguistic"
      • 2021-12-02 33634, 2021

      • CatQuest
        of course.
      • 2021-12-02 33645, 2021

      • CatQuest
        usually i type "no" for "norwegian" :D
      • 2021-12-02 33603, 2021

      • CatQuest
        my point is that [no linguistic] should *also* be in the list whne writing "n"
      • 2021-12-02 33614, 2021

      • CatQuest
        erh whne writing "no"
      • 2021-12-02 33639, 2021

      • Shubh
        tnot require to be at top?
      • 2021-12-02 33608, 2021

      • CatQuest
        I'd assume it'll sort the way everything else does
      • 2021-12-02 33621, 2021

      • CatQuest
        so if i type "no li" it shows first
      • 2021-12-02 33655, 2021

      • CatQuest
        but if i type "no" it sorts alphabetically with "north lumbago" "norwegian" and all the other languages with "no"
      • 2021-12-02 33610, 2021

      • Shubh
        and that happens when we suggest user using starting character of word
      • 2021-12-02 33617, 2021

      • CatQuest
        (I made up north lumbago, i don't recall any languages with "north" in it right now)
      • 2021-12-02 33635, 2021

      • CatQuest
        i don't know what to say. have you tried using the interface?
      • 2021-12-02 33646, 2021

      • Shubh
        ha there are some north something
      • 2021-12-02 33600, 2021

      • Shubh
        Yep !
      • 2021-12-02 33658, 2021

      • Shubh
        by default it suggest based on "if that language contain that word" but if we do "if that language starts from that word" then no linguistic would appear on the top
      • 2021-12-02 33606, 2021

      • CatQuest
        again ,i suggest checking how it already works on the site /talk with monkey
      • 2021-12-02 33620, 2021

      • CatQuest
        you wil lsee how it works. it works fine
      • 2021-12-02 33639, 2021

      • CatQuest
        my issue is that "no linguistic" doenst actually show whne it is expected that it should
      • 2021-12-02 33643, 2021

      • Shubh
        it is showing when i type no l..
      • 2021-12-02 33607, 2021

      • Shubh has quit
      • 2021-12-02 33601, 2021

      • Shubh joined the channel
      • 2021-12-02 33618, 2021

      • Shubh has left the channel
      • 2021-12-02 33647, 2021

      • Shubh joined the channel
      • 2021-12-02 33620, 2021

      • jess joined the channel
      • 2021-12-02 33632, 2021

      • Shubh has quit
      • 2021-12-02 33640, 2021

      • Shubh joined the channel
      • 2021-12-02 33630, 2021

      • Shubh
        Hey CatQuest , then what would be best way to show langauge suggestion and that no linguistic thing ..
      • 2021-12-02 33633, 2021

      • Shubh
        monkey ...
      • 2021-12-02 33626, 2021

      • monkey
        Hi Shubh
      • 2021-12-02 33612, 2021

      • Shubh
        about BB-407 , your thoughts please ..
      • 2021-12-02 33613, 2021

      • BrainzBot
        BB-407: Simplify "No linguistic content" selection https://tickets.metabrainz.org/browse/BB-407
      • 2021-12-02 33649, 2021

      • monkey
        So not sure about this one. For starters, "No linguistic content" does show in the search results dropdown when typing "no", so I think that part of the ticket has been fixed.
      • 2021-12-02 33651, 2021

      • monkey
        Agh, messages got lost.
      • 2021-12-02 33620, 2021

      • monkey
        I do think adding brackets would help make it stand out as a special case language like for [Multiple languages]
      • 2021-12-02 33636, 2021

      • monkey
        That's a change that I would have to do in the database
      • 2021-12-02 33645, 2021

      • monkey
        In fact, let me try it out on test.BB.org
      • 2021-12-02 33633, 2021

      • monkey
        Ah, it's a bit more complicated I guess, since we're using MusicBrainz' languages table
      • 2021-12-02 33639, 2021

      • Shubh
        is it better if we put [No linguistic] option below the [Multi .] option
      • 2021-12-02 33608, 2021

      • monkey
        The issue is that we're not really sorting those anywhere in the code
      • 2021-12-02 33629, 2021

      • monkey
        So they get sorted automatically, and "[" comes before "a"
      • 2021-12-02 33636, 2021

      • Shubh
        We can sort like there is custom filter optio for react-select
      • 2021-12-02 33611, 2021

      • monkey
        I'd rather not if we can avoid it
      • 2021-12-02 33643, 2021

      • monkey
        But I can add brackets; this is what it looks like: https://usercontent.irccloud-cdn.com/file/UwWevfF…
      • 2021-12-02 33652, 2021

      • monkey
        CatQuest: Satisfied with this?
      • 2021-12-02 33634, 2021

      • monkey
        I lied, I think there is some form of sorting
      • 2021-12-02 33647, 2021

      • Shubh
        but should we rather suggest Language based on starting character ?
      • 2021-12-02 33606, 2021

      • monkey
        I don't understand
      • 2021-12-02 33636, 2021

      • monkey
        So there is minimal sorting on "frequency" which is defined in the database (basically = most used languages) and then alphabetically.
      • 2021-12-02 33636, 2021

      • monkey
        I don't think "no linguistic content" would make it to the list of most used languages, so I think just adding the brackets is a good solution to mark it out as different.
      • 2021-12-02 33601, 2021

      • monkey
        In short, I think this is probably resolved
      • 2021-12-02 33611, 2021

      • monkey
      • 2021-12-02 33631, 2021

      • Shubh
        i didn't know that there was some sort of sorting mechanism based in options , now it make sense to not use any custom filter ..
      • 2021-12-02 33619, 2021

      • Shubh
        anyway , thanks for clearing the doubts monkey !
      • 2021-12-02 33625, 2021

      • monkey
        No worries !
      • 2021-12-02 33645, 2021

      • monkey
        By the way, I wanted to say you're doing great for your introduction in open source projects ! :)
      • 2021-12-02 33639, 2021

      • Shubh
        not sure about that ...
      • 2021-12-02 33618, 2021

      • monkey
        Well look, you came to us when you had questions setting up, you've been polite and nice, helped me debug what was broken in our setup, opened 5 PRs and helped me review one of mine, all that in the space of a week ! 🚀
      • 2021-12-02 33602, 2021

      • Shubh
        but i couldn't have done this without your help !
      • 2021-12-02 33618, 2021

      • Shubh
        monkey about that input field , showing invalid input for other fields in PR for BB-513
      • 2021-12-02 33619, 2021

      • BrainzBot
        BB-513: Improve "Are we missing an entry?" section. https://tickets.metabrainz.org/browse/BB-513
      • 2021-12-02 33655, 2021

      • monkey
        Do you mean "sort name", language, etc?
      • 2021-12-02 33612, 2021

      • Shubh
        Yes
      • 2021-12-02 33608, 2021

      • monkey
        I think that's fine. We can't fully assume any of those other fields.
      • 2021-12-02 33636, 2021

      • Shubh
        but i did send default values with name field in namesection object , so why it is not validating correctly?
      • 2021-12-02 33614, 2021

      • monkey
        If you mean an empty string, that's not a valid value
      • 2021-12-02 33632, 2021

      • monkey
        i.e. user need to fill in the sort name and languages in order for it to be valid
      • 2021-12-02 33631, 2021

      • Shubh
        but isn't that true when user create new entity or there some kinda check to verify ? btw i made the changes in that PR
      • 2021-12-02 33602, 2021

      • monkey
        I didn't understand the question
      • 2021-12-02 33612, 2021

      • monkey
        If you go to create a new entity on the website now and enter a name, you'll see the same validation mechanism because the other fields are missing: https://usercontent.irccloud-cdn.com/file/Ipt9d5y…
      • 2021-12-02 33607, 2021

      • monkey
        I saw the same thing in your PR, which is what I would expect to happen. We prefill the name, which is the same as if the user typed it. Validation stays the same
      • 2021-12-02 33632, 2021

      • Shubh
        Ohh so validation trigger if user type something , hmmm
      • 2021-12-02 33609, 2021

      • monkey
        sort of. I think validation happens when you load the page, and subsequently when any field is modified
      • 2021-12-02 33634, 2021

      • Shubh
        I have one more question ..
      • 2021-12-02 33621, 2021

      • monkey
      • 2021-12-02 33637, 2021

      • monkey
        So whenever you load the page or change the state validation is run
      • 2021-12-02 33648, 2021

      • monkey
        Shoot your question :)
      • 2021-12-02 33648, 2021

      • Shubh
        why we use react proptypes for type checking rather than TS
      • 2021-12-02 33608, 2021

      • monkey
        They just haven't been updated :)
      • 2021-12-02 33629, 2021

      • monkey
        We only recently moved to using Typescript
      • 2021-12-02 33649, 2021

      • monkey
        So conversion is either a very big job for someone, or modifying little by little
      • 2021-12-02 33655, 2021

      • Shubh
        Hmm TS tooling makes life easier
      • 2021-12-02 33601, 2021

      • monkey
        Agreed
      • 2021-12-02 33615, 2021

      • Shubh
        Hmm baby steps
      • 2021-12-02 33644, 2021

      • monkey
        That :)
      • 2021-12-02 33635, 2021

      • KassOtsimine
        Shubh, monkey : this is what I see https://usercontent.irccloud-cdn.com/file/R3ks0JR…
      • 2021-12-02 33618, 2021

      • Shubh
        Same , as monkey said issue is already fixed
      • 2021-12-02 33620, 2021

      • Shubh has left the channel
      • 2021-12-02 33646, 2021

      • monkey
        KassOtsimine: The result is in there, you have to scroll further down in the list. However if you now try on test.LB you'll see I adde [brackets] and that will put no linguistic content at the top of the not-the-most-used languages
      • 2021-12-02 33659, 2021

      • CatQuest
        oic
      • 2021-12-02 33612, 2021

      • CatQuest
        yea i noticed that it was lower down
      • 2021-12-02 33632, 2021

      • CatQuest
        jup i see it.
      • 2021-12-02 33634, 2021

      • monkey
        Yeah, we do sort more frequent languages above the rest.
      • 2021-12-02 33650, 2021

      • CatQuest
        👍 now it behves as i expect. i'd consider this closed when on beta :D
      • 2021-12-02 33658, 2021

      • monkey
        All righty
      • 2021-12-02 33601, 2021

      • CatQuest
        good good
      • 2021-12-02 33654, 2021

      • monkey
        Wanna try again in a new window in prod? :)
      • 2021-12-02 33605, 2021

      • CatQuest
        oh
      • 2021-12-02 33624, 2021

      • CatQuest
        wait why would you directly to prod? you sohuld only directly to beta :P
      • 2021-12-02 33646, 2021

      • monkey
        It's only a modification of the name of the language in the database
      • 2021-12-02 33607, 2021

      • monkey
        test DB first, and then prod DB (which is also used by beta.BB).
      • 2021-12-02 33639, 2021

      • CatQuest
        :|
      • 2021-12-02 33619, 2021

      • monkey
        ?
      • 2021-12-02 33604, 2021

      • monkey
        There's no code change so I can't deploy anything (whether it's on beta or prod). But we did test the database change on test.BB which uses a test database;
      • 2021-12-02 33602, 2021

      • CatQuest
        i don't really get it :D
      • 2021-12-02 33614, 2021

      • monkey
        I didn't change anything in the code
      • 2021-12-02 33634, 2021

      • CatQuest
        erh ok? i dunno :)
      • 2021-12-02 33644, 2021

      • monkey
        I change the name of the language from "No linguistic content" to "[No linguistic content]" in the database, that's the only thing I changed
      • 2021-12-02 33652, 2021

      • monkey
        No worries :)
      • 2021-12-02 33605, 2021

      • BrainzGit has quit
      • 2021-12-02 33640, 2021

      • jess has quit