monkey, Shubh: how does BB implement languages? Does it take the MB table or?
2022-03-18 07737, 2022
reosarevok
(wondering if you actually have the same "most common / other / hidden" concept as we do)
2022-03-18 07746, 2022
Shubh
Yes from mb
2022-03-18 07727, 2022
reosarevok
I've found the MB way with a dozen or so top languages on top of the list, then the rest underneath, and then the ones that are not (yet) needed hidden not to have 9k entries in the list works fairly well :)
2022-03-18 07759, 2022
reosarevok
(but I dunno if BB would need a different common / other / hidden split or we could just use the same and unlock languages from MB once they're needed for BB)
2022-03-18 07703, 2022
Shubh
we intend to do the same ie. using frequency of a language to sort it in dropdown selection
2022-03-18 07756, 2022
Shubh
although we do currently sort/rank languages on frequency but doesn't hide any, which was the reason we were (still) facing slow dropdowns
2022-03-18 07725, 2022
reosarevok
tbh if you have access to the MB DB list, I'd probably hide all the hidden MB ones
2022-03-18 07744, 2022
reosarevok
(do make a quick DB call to see if you're *using* any of them already, if so, I can unhide them on the MB side too)
2022-03-18 07729, 2022
monkey
Important distinction: we have a *copy* of a couple of tables from the MB db, currently no direct access to MB db
2022-03-18 07747, 2022
reosarevok
Oh
2022-03-18 07702, 2022
reosarevok
So if new languages are added to MB and whatnot, you don't actually get updated
2022-03-18 07708, 2022
reosarevok
Hmm
2022-03-18 07730, 2022
reosarevok
On one hand that's not bad because BB might have slightly different top languages and hidden languages than MB
2022-03-18 07744, 2022
reosarevok
On the other, we probably would want to keep the tables themselves at least in sync...
2022-03-18 07755, 2022
reosarevok
(the languages if not the frequencies)
2022-03-18 07731, 2022
Shubh
Hmm mb would have more data on common languages
2022-03-18 07702, 2022
monkey
The plan is to have a direct DB connection at some point and use the MB tables
2022-03-18 07705, 2022
Shubh
how would we link them with bb tables?
2022-03-18 07729, 2022
monkey
Make a connection to the MB DB and run queries on that db
2022-03-18 07745, 2022
monkey
So possibly some changes in the ORM
2022-03-18 07752, 2022
reosarevok
I guess you could also technically have a second "language_frequency_bookbrainz" table you can join with musicbrainz.language
2022-03-18 07759, 2022
reosarevok
But I dunno how that works with ORMs tbh
2022-03-18 07750, 2022
Shubh
like what about foreign key relations?
2022-03-18 07723, 2022
monkey
I'll be honest, it's not something I've done in the past, so I don't know
2022-03-18 07707, 2022
ShivamAwasthi joined the channel
2022-03-18 07756, 2022
ShivamAwasthi
hey monkey
2022-03-18 07707, 2022
monkey
Hi!
2022-03-18 07713, 2022
ShivamAwasthi
I was thinking that for implementing a simple admin panel page, it should have a user search and then clicking on the users to open a modal which will then allow the admin to perform an action(blocking, making priviliged Editor, unblocking etc)
also, on the project description, it is written that we need new table for attaching roles, but as BenOckmore mentioned we can probably leverage the editor_type table
2022-03-18 07751, 2022
monkey
A button next to the name in the table would probably be sufficient, where a modal might be a bit overkill, but those are just details
2022-03-18 07703, 2022
monkey
Yes, agree editor_type can be used for this purpose
2022-03-18 07754, 2022
ShivamAwasthi
the reason I suggest a modal is because there can be different action_types. It would also allow us to add more fields to an action, such as a 'Note/Reason for blocking a user' which can then be used in the Admin Log
2022-03-18 07714, 2022
monkey
That makes sense
2022-03-18 07742, 2022
ShivamAwasthi has quit
2022-03-18 07750, 2022
EndeavouringCat
oh, I thought the "admin" stuff was related to the relationship editing interface :(
2022-03-18 07749, 2022
BenOckmore
reosarevok, monkey: at some point, we had replication set up, and the language and gender tables were being kept in sync
2022-03-18 07750, 2022
BenOckmore
That's the reason those tables exist in the separate musicbrainz schema in the database
2022-03-18 07722, 2022
ShivamAwasthi joined the channel
2022-03-18 07710, 2022
monkey needs to do so RTFM
2022-03-18 07736, 2022
ShivamAwasthi
EndeavouringCat it is, admins can make certain users as privileged editors. These privileged editors and admins can edit and add relationships and identifiers too.
2022-03-18 07748, 2022
EndeavouringCat
:O
2022-03-18 07750, 2022
EndeavouringCat
omg
2022-03-18 07717, 2022
EndeavouringCat
ShivamAwasthi: so you are going to work on this for gsoc???
2022-03-18 07734, 2022
ShivamAwasthi
I want to apply for this project, yes
2022-03-18 07743, 2022
EndeavouringCat
🙏 aaaweesommeee
2022-03-18 07710, 2022
ShivamAwasthi
Shubh, we can probably skip the Authors column in the WorkTable in Authors page
2022-03-18 07742, 2022
ShivamAwasthi
the WorkTable component will automatically skip it if we dont pass the authorsData in the props
2022-03-18 07732, 2022
Shubh
Hmm we should probably do writer/translator in place of author
2022-03-18 07727, 2022
ShivamAwasthi
no I meant that since we are on an authors page, and it is listing this author's works, we probably dont need to display a column which lists his name again and again
2022-03-18 07756, 2022
ShivamAwasthi
their*
2022-03-18 07713, 2022
ShivamAwasthi has quit
2022-03-18 07700, 2022
monkey
Well, I would argue that sometimes a work is written by more than one author, in which case we would have some information missing if we didn't show the author(s) column
2022-03-18 07716, 2022
monkey
On a side note, we are also likely to reuse the table later on to show (in a separate tab on the author page) Works that author translated. At which point we'll want to show the author column.
2022-03-18 07738, 2022
reosarevok
We sometimes just pass a showAuthorsColumn kind of variable to the template for those cases
2022-03-18 07755, 2022
monkey
Yeah, i'm guessing we'll want something like that for flexibility
2022-03-18 07709, 2022
reosarevok
One option would be to check whether any of the authors lists has more than just this one, and only show the author in that case
2022-03-18 07712, 2022
monkey
But we don't yet have a use case for this specific one I think
2022-03-18 07713, 2022
reosarevok
IIRC that's what MB does for RGs
2022-03-18 07721, 2022
monkey
Yeah, that's a good point
2022-03-18 07748, 2022
monkey
Although I'm not always keen on automatically changing the layout on the user.
2022-03-18 07757, 2022
monkey
In this case, i guess it would make sense though
2022-03-18 07706, 2022
reosarevok
Oh, seems we always show them all nowadays (except for track artists on releases)
2022-03-18 07709, 2022
monkey
(and won't be too surprising for users)
2022-03-18 07717, 2022
ShivamAwasthi joined the channel
2022-03-18 07718, 2022
reosarevok
I agree with changing the layout, I'm not always a fan
2022-03-18 07729, 2022
reosarevok
But probably worth checking whether some cases look a bit silly or something :)
2022-03-18 07752, 2022
monkey
To be honest, I just want an advanced table library that allows users to sort by and show/hide the columns they want
2022-03-18 07731, 2022
ShivamAwasthi
before this, we were listing relationships of the author only, so we were already kind of missing out on the information that the work is written by multiple authors
2022-03-18 07738, 2022
monkey
I think in most cases the Works displayed on an author's page will have a single author
2022-03-18 07740, 2022
ShivamAwasthi
We can, maybe, display one more tab where the works with multiple authors are listed? (something like Collaborations)
2022-03-18 07722, 2022
monkey
We could, but for now that seems maybe overkill.
2022-03-18 07757, 2022
ShivamAwasthi
hmm. agreed
2022-03-18 07742, 2022
reosarevok
How are translations done?
2022-03-18 07754, 2022
reosarevok
If they'll be in the same table, and translators are under authors, you probably want to show them
2022-03-18 07709, 2022
monkey
author X wrote work Y, + author Z translated work Y
2022-03-18 07719, 2022
monkey
2 relationships
2022-03-18 07738, 2022
reosarevok
Sure, I meant whether they'd show in the authors column :)
I think it should be like this: The WorkTable should have 3 tabs(1 for works written by author, 1 for works translated by other, 1 for other work-author relationships), all the other relationships should be listed after the worktable component
Definitely possible to try a single tab for all author-work relationships, and find a way to make it work. But IMO it would probably be simpler and clearer to have separate tabs so as not to overcrowd the page as first loaded
2022-03-18 07714, 2022
Shubh
but how many tabs are we talking about?
2022-03-18 07755, 2022
monkey
All i can think of for now is 1 for "wrote work", 1 for "translated work", 1 for "others", so 3 in total
2022-03-18 07737, 2022
monkey
We might eventually want to think about showing relationships like "A provided story for W" in the same tab as "A wrote W", and maybe "A translated W" on the same tab as "A worked on W".
2022-03-18 07737, 2022
monkey
I could be convinced either way.
2022-03-18 07711, 2022
Shubh
are we categorizing them on similarity or frequency?
2022-03-18 07741, 2022
monkey
To be honest I haven't thought this far, I'm just throwing some ideas
2022-03-18 07716, 2022
monkey
I do see you point though, it would be easiest to show all author-work rels in a single tab, and have a tab for each entity type the author can have a rel for.
2022-03-18 07723, 2022
oj joined the channel
2022-03-18 07745, 2022
agatzk has quit
2022-03-18 07701, 2022
Shubh
monkey: how bb keep track of user achievement progress?, by counting all prev history revisions?
2022-03-18 07756, 2022
Shubh
how can a user see their progress?
2022-03-18 07745, 2022
monkey
There's currently no way for users to see progress on their achievements (see BB-505)
in unified form, i'm planning to have new revisions for each entity created by user and then another new revision for adding relationships on them . does this sound reasonable?
