since we are using the default label, provided id might not have that label, though we don't even need to fetch it if we know the publisher type id that already exist...
monkey
Right, that's what I was thinking. We could fetch by id only in fetchOrCreatePublisherType (since ids should be unique anyway)
Shubh
in this case label also should be unique, also we might aswell skip fetching publisherType if we know its id since id is the only thing we need anyway
monkey
Right
I've implemented what I think is the final piece for the author credits (the smart join phrases, i.e. "A & B & C & D" -> "A, B, C & D") and deployed that to test.bb
CatQuest: If you want to try it again, I think that was the last missing item?
Oh no, just remembered something: we need to add the same author-credit to the EditionGroup associated with the edition if the EG doesn't already have one (and we can implement an option to replace the current EG's credits, maybe later on?).
Never mind, that first part (add author credit id to auto-created EG) is already implemented and active. ACs are just not shown on the EG page, a quick fix
