#bookbrainz

/

      • monkey
        Shubh: Hi! For when you have time, here are a few extra notes after testing the up-to-date deployment on test:
      • 1. I tried creating a new book to test copying ACs to an existing work (adding relationship) which works really nicely. However a superfluous empty revision was created in the process: https://test.bookbrainz.org/revision/30175
Checked in the DB, there is no author_revision, work_revision, etc. for any entity type, which suggests it's an empty revision with no changes. For info, I didn't add any info other than entering name
      • section, selecting existing work and checking "copy ACs…"
      • 2. If we still have some flexibility to control the order of database operations when submitting the form, I think adding relationships between new Edition and Works should be done in the same revision as creating the new Edition. Meaning these two revisions could be combined: https://test.bookbrainz.org/revision/30176 and https://test.bookbrainz.org/revision/30178
      • ansh
        monkey: I've opened a PR for showing reviews. Currently I have used the beta api for CB, and the avg rating is dummy till my PR gets merged in CB.
      • Shubh
        monkey: for second part, is it really necessary? there might be case where it will try to add relationship for entity which hasn't been yet created causing undefined behaviour.
      • monkey: i added validations on modal sections but i realize it slowdown the modal a lit bit more, possibly due to costly prop comparisions (with old props since memoized). afraid if it would cause even more slow down for form.