#bookbrainz

/

      • oj has quit

        • 2022-08-11 22319, 2022

      • oj joined the channel

        • 2022-08-11 22308, 2022

      • Shubh
        monkey: i somehow overlook this mistake https://github.com/metabrainz/bookbrainz-site/pul…, should have tested.

        • 2022-08-11 22312, 2022

      • Shubh
        Since AC validation need some fixing, might as well this little thing in that as well?

        • 2022-08-11 22337, 2022

      • Shubh
        I will create a PR for that then

        • 2022-08-11 22323, 2022

      • monkey
        Which mistake is that Shubh?

        • 2022-08-11 22334, 2022

      • monkey
        Do feel fre to open a fix PR though

        • 2022-08-11 22315, 2022

      • monkey
        (On my phone rn, can't test the code)

        • 2022-08-11 22319, 2022

      • Shubh
        `const authorBBID = name.authorBBID ?? name.author?.id;`this block should be inside that map function.

        • 2022-08-11 22320, 2022

      • Shubh
        monkey: if i'm on it, should i add warning when user try to add duplicate author in AC?

        • 2022-08-11 22344, 2022

      • Shubh
        also would it be better if we use tooltip for error and warn messages in validation-label component?

        • 2022-08-11 22309, 2022

      • Intdtti joined the channel