monkey: I think we're ready for a PR for work guideline. Thoughts?
smach joined the channel
monkey
pbryan: Definitely !
smach has quit
ShivamAwasthi: should be live, but indeed I see only three at a time. Looking at the network tab in my browser I can see that the autocomplete endpoint is called with "size:3" which would explain it
The result is that this is not necessary at all, like I had guessed.
Properly encoding the entity name once is enough (has not been done at all before that PR), this way we can also drop the `decodeUrlQueryParams` middleware again.
I guess Shubh had run into the same issue with live reloading that component as me while trying to fix it: Changing src/client/components/pages/parts/call-to-action.js and saving has no effect in my browser at all in certain circumstances (not even after refreshing the browser tab) - maybe this happens after the server has already been restarted by
nodemon!?
`decodeUrlQueryParams` was only undoing the unnecessary second encoding pass, the first encoding is already handled by Express.
Now that I've got this working properly I will rebase my changes onto a new branch and create yet another PR for you to review, sorry :)
Probably because the dumps were always including the whole database, even before collections did exist D: