about BB709, the edition-table is used in other places too, such as on the Work Page, Edition-group page, Series of Editions page. Do we want the author column added specifically in the case of publishers only, or do we want it in case of all those other entity pages, too?
Another thing which I want to talk about it is how we display the authors. monkey suggested reconstructing the author credits, but I think we can do something like a list of "Author(s) credited" . (A subtle difference, but I think it would look cleaner)
2023-03-11 07058, 2023
ShivamAwasthi has quit
2023-03-11 07013, 2023
ZaphodBeeblebrox
ShivamAwasthi: I would suggest to loom to how musicbrainz does it
2023-03-11 07024, 2023
stoichy joined the channel
2023-03-11 07006, 2023
Legend11 joined the channel
2023-03-11 07005, 2023
Legend11
monkey I got something interesting I was looking into BB-718 and initially when we hit the add review button we get this
err.. my upload is not working so I had to put them on a drive
2023-03-11 07057, 2023
Legend11
alriight back to the issue , now when I was here I was testing if my changes were being run so I refreshed the page and now without even loggining in to critique brainz I get this https://drive.google.com/file/d/1UHGcK_UdIxqe4mGt…
@ShivamAwasthi thanks for that cool tool.... well that should not happen , I am getting this https://pasteboard.co/faw9N0hdjdKp.png , well the issue was that refreshing the window does overpass the auth check and directly show what needs to been shown after the user has logged into critique brainz
2023-03-11 07057, 2023
Legend11
and sorry you were not there so that sloppy tagging '=D \
monkey I think this has something to be with has permisions variable being defined during the refresh or something , well let me look into this further
2023-03-11 07025, 2023
Legend11
connect.sid does this cookie ring something ??
2023-03-11 07011, 2023
Legend11
Got it ( well what I think atleast ) , so what is happing as getAccessToken awaits the response of /external-service/critiquebrainz/refresh and then gives value to hasPermissions variable the refreshing does this ( as getAccessToken is still waiting to checking the auth side the hasPermissions is not null till then) and thus we our able to see the
2023-03-11 07012, 2023
Legend11
Modal body and footer .... monkey even if we use showModal to prevent the ssr I think this issue will still presist , so any thoughts how to deal with it ??
