#bookbrainz

Hey monkey, should I add API endpoints examples in my proposal for the project "Import other open databases"?

Hi RohanSasne, yes, generally the more details the better !

Cool, thanks for the quick reply:)  would come up with the proposal really soon !

Nice, eager to see it :)

But there is also the (increasingly) pressing matter of moving away from the old version of Knex

I think it would be an improvement to be on the sunset (or perhaps continuing, there is hope…) version of Objection over the current Bookshelf version.

So maybe it's worth the move anyway? It depends on how much time you think the move might take, roughly.

Either that, or deciding now to go for another ORM

I fully agree, maybe we could just use a fork of Bookshelf and bump the knex version ourselves as a short-term solution to give us more time to decide on a long-term solution?

I accidentally did that for Objection by the way, it only expects knex 0.95 but I had already installed 2.4 in my bookbrainz-data-js fork and it worked flawlessly :)

Ah, that's interesting! I was about to say that I would expect lots of compatibility issues between versions, but…

Eek. https://github.com/bookshelf/bookshelf/forks

There already is https://github.com/bookshelf/bookshelf/pull/2120 maybe we have luck with that

Oh, well that looks easy

That would certainly be a good temporary improvement, fixing the vulnerability while we figure out what we want to do (which might involve waiting a bit to see what happens of Objection)

Would it be appropriate to fork this under the metabrainz GH org or does this not matter for a temporary solution?

How about I create it using the BookBrainz user? This used to host the main repos before being moved to the MeB org

Hehe, keeping it away from the official repos ;) Sounds good!

For a temporary solution that makes sense to me :) We can always transfer it if we do end up keeping it longer

master branch only?

Yeah. All stale branches otherwise

Yeah, the others are 8+ years old

https://github.com/bookbrainz/CaliBBre <3 (probably outdated, but still...)

You should receive an invite

Thanks, accepted

👍

Are you already working with the fork? If not, I could prepare the necessary changes in all affected repos.

^ monkey

Haven't done anything with the fork

(y)

And would very much appreciate you preparing for the replacement :)

Thank you