Hey monkey, should I add API endpoints examples in my proposal for the project "Import other open databases"?
2023-03-16 07557, 2023
monkey
Hi RohanSasne, yes, generally the more details the better !
2023-03-16 07534, 2023
RohanSasne
Cool, thanks for the quick reply:) would come up with the proposal really soon !
2023-03-16 07545, 2023
monkey
Nice, eager to see it :)
2023-03-16 07504, 2023
monkey
kellnerd: Not a lot more to say about the ORM discussion, other than I want to avoid moving ORMs twice in a span of a year or two :D
2023-03-16 07505, 2023
monkey
But there is also the (increasingly) pressing matter of moving away from the old version of Knex
2023-03-16 07558, 2023
monkey
I think it would be an improvement to be on the sunset (or perhaps continuing, there is hope…) version of Objection over the current Bookshelf version.
2023-03-16 07525, 2023
monkey
So maybe it's worth the move anyway? It depends on how much time you think the move might take, roughly.
2023-03-16 07539, 2023
monkey
Either that, or deciding now to go for another ORM
2023-03-16 07522, 2023
kellnerd
I fully agree, maybe we could just use a fork of Bookshelf and bump the knex version ourselves as a short-term solution to give us more time to decide on a long-term solution?
2023-03-16 07525, 2023
kellnerd
I accidentally did that for Objection by the way, it only expects knex 0.95 but I had already installed 2.4 in my bookbrainz-data-js fork and it worked flawlessly :)
2023-03-16 07557, 2023
monkey
Ah, that's interesting! I was about to say that I would expect lots of compatibility issues between versions, but…
That would certainly be a good temporary improvement, fixing the vulnerability while we figure out what we want to do (which might involve waiting a bit to see what happens of Objection)
2023-03-16 07545, 2023
kellnerd
Would it be appropriate to fork this under the metabrainz GH org or does this not matter for a temporary solution?
2023-03-16 07534, 2023
monkey
How about I create it using the BookBrainz user? This used to host the main repos before being moved to the MeB org
