Hello monkey I want to participate in the gsoc and the registration have just started I want to ask how should fill my name in it from the bookbrainz I really loved the work and would want to continue it here only
2023-03-21 08035, 2023
monkey
Hello maddy007[m] ! I'm not sure what question you are asking about filling your name
2023-03-21 08047, 2023
kellnerd joined the channel
2023-03-21 08027, 2023
kellnerd
monkey: I think I'm mostly done with BB-530, caching is working now :)
Some of the enforced linter rules were rather annoying, to be honest.
2023-03-21 08027, 2023
kellnerd
Are you open to improvement suggestions which disable rules which were once specifically enabled?
2023-03-21 08040, 2023
monkey
Yes, we can definitely discuss it
2023-03-21 08036, 2023
kellnerd
Great, then I won't fix the remaining linter issues in this PR... some of them are not even reported by CI, I only saw them locally.
2023-03-21 08043, 2023
kellnerd
So I will definitely add linter improvements to my backlog, but first I want to focus on finishing the Wikipedia PR and preparing my GSoC proposal.
2023-03-21 08055, 2023
monkey
Definitely
2023-03-21 08031, 2023
kellnerd
Remaining TODO items: "Collapse extract if it is too long"
2023-03-21 08041, 2023
kellnerd
I have not seen an extarct that was long enough to warrant collapsing, but I can still do this, either in this PR or later in a separate PR if we find a longer extract.
Currently I just use the first Wikidata identifier
2023-03-21 08030, 2023
monkey
Hm. How would we display multiple extracts?
2023-03-21 08012, 2023
monkey
Do you mind asking the MB team in the main channel about the user agent string? They'll have a suitable format I'm sure, and better to harmonize with it
2023-03-21 08018, 2023
kellnerd
I have thought about fetching all WP sites which are linked to both/all items to have more pages (and potentially languages) to select from.
2023-03-21 08046, 2023
kellnerd
But probably that's the 1% case, while the current solution works for 99%.
2023-03-21 08058, 2023
kellnerd
Let's ask the MB team.
2023-03-21 08052, 2023
kellnerd
(So my intention was never to display two extracts for one entity page.)
2023-03-21 08058, 2023
kellnerd
Unless I hear objections in #metabrainz, the user agent will be "bookbrainz-site/latest (bookbrainz.org)" in my dev setup.
2023-03-21 08036, 2023
kellnerd
In production it is supposed to use the current version instead of "latest", which I hope to obtain from $GIT_COMMIT_SHA
2023-03-21 08028, 2023
kellnerd
Does this env variable or the .git-version file contain anything in your dev setup, monkey? For me both are empty...
