#bookbrainz

kellnerd: In dev it is not used so the setup does not have any provision for it, indeed. We could amend the docker-compose file to set the build arg when we build the container as described here: https://docs.docker.com/compose/compose-file/bu...

To make this dynamic, we would need to set an environment variable in a .env file using this git command: https://github.com/metabrainz/bookbrainz-site/b...

So to recap, in .env we have `GIT_COMMIT_SHA=$(git rev-parse --short HEAD)`, and then in docker-compose.yml:

monkey Hi, can I share you GSOC proposal  for review?

Hi Siddhart1o1 ! Do post it on the community forums please :)

Thanks monkey, I will try that once I am back home.

Hey monkey, I have uploaded my proposal on the community forum, can you please review it as and when you get free :)

Sure thing :)

monkey I have uploaded proposal on forums : https://community.metabrainz.org/t/gsoc-2023-ad..., please have a look when you have time. And let me know any changes required. Thanks !

👍

I had a doubt, so as BookBrainz is still in the early stages, would my proposal of building something like a recommendation system for users like listenbrainz has based on user's likes, (also improving the genre system) could be useful to bookbrainz rn?

Hi Sahaj ! At the moment there is no such thing as likes in BookBrainz, and I doubt there are any data points that would be usable for a recommendation system

So should the genre system (and maybe a likes system) be of any importance to bookbrainz?

Genres eventually yes, but based on the same system as MusicBrainz which uses folksonomy, more of a tag system: https://musicbrainz.org/doc/Folksonomy_Tagging

So would it be apt for me to propose a MusicBrainz-like tags system similar to trivia tags like Pulitzer book awards etc. along with UI/UX improvements for gsoc 23 ?

Or are there other priorities to focus on first.

monkey: I've followed your suggestion and almost got it working.

My dev server now has the following inside the footer: "Alpha Software — $(git rev-parse --short HEAD) — Report a Bug"

So .env file values are taken literally and will not be interpolated :/

Also, when passing this as Docker ARG, it is not available during runtime, e.g. via `process.env.GIT_COMMIT_SHA`

This leads to hacky workarounds such as `RUN echo $GIT_COMMIT_SHA > .git-version` and reading that file during runtime...

Wouldn't it be much easier to pass $GIT_COMMIT_SHA as an environment variable in docker-compose.yml?

I will try that now.

Ok, now I have "User-Agent: bookbrainz-site/$(git rev-parse --short HEAD) (bookbrainz.org)", but still not interpolated of course.

I think I've figured out how to approach this, will push my commits soon :)

Testing the changes took me a bit longer, because Docker rebuilds the whole image from scratch every time an ARG changes...

Sorry for force-pushing my branch twice in such a short period, I usually try to avoid that, but I wanted to clarify the commit messages a bit O:3

I think https://github.com/metabrainz/bookbrainz-site/p... and its accompanying type definitions in https://github.com/metabrainz/bookbrainz-data-j... should be ready to review now.

Only some stupid ESLint warnings with which I do not agree have not been fixed/muted so far...

I hope I won't immediately ruin stoichy's efforts from BB-732 with these new warnings.

BB-732: Linter errors when running testing command https://tickets.metabrainz.org/browse/BB-732