kellnerd: In dev it is not used so the setup does not have any provision for it, indeed. We could amend the docker-compose file to set the build arg when we build the container as described here: https://docs.docker.com/compose/compose-file/buil…
I had a doubt, so as BookBrainz is still in the early stages, would my proposal of building something like a recommendation system for users like listenbrainz has based on user's likes, (also improving the genre system) could be useful to bookbrainz rn?
2023-03-22 08144, 2023
monkey
Hi Sahaj ! At the moment there is no such thing as likes in BookBrainz, and I doubt there are any data points that would be usable for a recommendation system
2023-03-22 08123, 2023
Sahaj
So should the genre system (and maybe a likes system) be of any importance to bookbrainz?
So would it be apt for me to propose a MusicBrainz-like tags system similar to trivia tags like Pulitzer book awards etc. along with UI/UX improvements for gsoc 23 ?
2023-03-22 08143, 2023
Sahaj
Or are there other priorities to focus on first.
2023-03-22 08100, 2023
kellnerd joined the channel
2023-03-22 08155, 2023
kellnerd
monkey: I've followed your suggestion and almost got it working.
2023-03-22 08155, 2023
kellnerd
My dev server now has the following inside the footer: "Alpha Software — $(git rev-parse --short HEAD) — Report a Bug"
2023-03-22 08151, 2023
kellnerd
So .env file values are taken literally and will not be interpolated :/
2023-03-22 08121, 2023
kellnerd
Also, when passing this as Docker ARG, it is not available during runtime, e.g. via `process.env.GIT_COMMIT_SHA`
2023-03-22 08122, 2023
kellnerd
This leads to hacky workarounds such as `RUN echo $GIT_COMMIT_SHA > .git-version` and reading that file during runtime...
2023-03-22 08119, 2023
kellnerd
Wouldn't it be much easier to pass $GIT_COMMIT_SHA as an environment variable in docker-compose.yml?
2023-03-22 08145, 2023
kellnerd
I will try that now.
2023-03-22 08154, 2023
kellnerd
Ok, now I have "User-Agent: bookbrainz-site/$(git rev-parse --short HEAD) (bookbrainz.org)", but still not interpolated of course.
2023-03-22 08157, 2023
kellnerd
I think I've figured out how to approach this, will push my commits soon :)
2023-03-22 08102, 2023
Sahaj has quit
2023-03-22 08100, 2023
kellnerd
Testing the changes took me a bit longer, because Docker rebuilds the whole image from scratch every time an ARG changes...
2023-03-22 08110, 2023
kellnerd
Sorry for force-pushing my branch twice in such a short period, I usually try to avoid that, but I wanted to clarify the commit messages a bit O:3
