#bookbrainz

/

      • vysn has quit
      • 2023-05-22 14254, 2023

      • vysn joined the channel
      • 2023-05-22 14256, 2023

      • vysn has quit
      • 2023-05-22 14228, 2023

      • anonn joined the channel
      • 2023-05-22 14213, 2023

      • monkey
        kellnerd: Hi again! I took the liberty of assigning you BB-741 ; looks like one of the new regular expressions breaks all our pages on Safari :/
      • 2023-05-22 14213, 2023

      • monkey
        Happy to help you test things if you don't have access to Safari
      • 2023-05-22 14213, 2023

      • BrainzBot
        BB-741: Regular expression error in Safari https://tickets.metabrainz.org/browse/BB-741
      • 2023-05-22 14256, 2023

      • kellnerd
        I will have a look later 😂
      • 2023-05-22 14207, 2023

      • monkey
        Thanks !
      • 2023-05-22 14216, 2023

      • monkey shakes fist at Safari
      • 2023-05-22 14246, 2023

      • CatQuest joins in
      • 2023-05-22 14225, 2023

      • CatQuest
        ugh i am too out of the loop, what was that ugly merge?
      • 2023-05-22 14237, 2023

      • monkey
      • 2023-05-22 14254, 2023

      • CatQuest
        thanks. i'll look into it
      • 2023-05-22 14212, 2023

      • monkey
        I wasted some hours coming up with a neat SQL query, just to realize it was not going to work out in the end…
      • 2023-05-22 14221, 2023

      • kellnerd
        monkey: Are you sure that the problem in BB-741 is about that specific line of code? It contains no lookbehind expressions, only named groups...
      • 2023-05-22 14222, 2023

      • BrainzBot
        BB-741: Regular expression error in Safari https://tickets.metabrainz.org/browse/BB-741
      • 2023-05-22 14207, 2023

      • kellnerd
      • 2023-05-22 14215, 2023

      • kellnerd
        Tricky to get rid of the lookbehind here, I probably have to refactor the entire function to use a different approach to prefix URLs with a protocol.
      • 2023-05-22 14236, 2023

      • kellnerd
        Ok, I found a way to do it without a regex.
      • 2023-05-22 14251, 2023

      • kellnerd
        As a bonus, the code is also easier to understand now (and that's coming from me 😄)
      • 2023-05-22 14208, 2023

      • monkey
        !m kellnerd
      • 2023-05-22 14208, 2023

      • BrainzBot
        You're doing good work, kellnerd!
      • 2023-05-22 14225, 2023

      • kellnerd
        Thanks, I'm just filling the PR template :)
      • 2023-05-22 14242, 2023

      • kellnerd
        Is it intentional that we not only prefix the href with https:// but also the displayed link? I think it would look better to show it as simply www.example.com nevertheless.
      • 2023-05-22 14217, 2023

      • kellnerd
        s/look better/be more intuitive/
      • 2023-05-22 14245, 2023

      • kellnerd
        That wasn't easily doable with the old approach, but it is with the new one
      • 2023-05-22 14236, 2023

      • monkey
        I agree
      • 2023-05-22 14210, 2023

      • kellnerd
        Ok, I will push that change as a second commit 👍
      • 2023-05-22 14218, 2023

      • kellnerd
        Heh, now the actual change is a one-liner
      • 2023-05-22 14236, 2023

      • kellnerd
        PR is ready for a test in Safari, monkey
      • 2023-05-22 14206, 2023

      • kellnerd
        I've also updated the tickets description
      • 2023-05-22 14225, 2023

      • rdswift has quit
      • 2023-05-22 14244, 2023

      • rdswift joined the channel
      • 2023-05-22 14259, 2023

      • vysn joined the channel
      • 2023-05-22 14211, 2023

      • vysn has quit
      • 2023-05-22 14239, 2023

      • vysn joined the channel
      • 2023-05-22 14237, 2023

      • anonn has quit