Tricky to get rid of the lookbehind here, I probably have to refactor the entire function to use a different approach to prefix URLs with a protocol.
2023-05-22 14236, 2023
kellnerd
Ok, I found a way to do it without a regex.
2023-05-22 14251, 2023
kellnerd
As a bonus, the code is also easier to understand now (and that's coming from me 😄)
2023-05-22 14208, 2023
monkey
!m kellnerd
2023-05-22 14208, 2023
BrainzBot
You're doing good work, kellnerd!
2023-05-22 14225, 2023
kellnerd
Thanks, I'm just filling the PR template :)
2023-05-22 14242, 2023
kellnerd
Is it intentional that we not only prefix the href with https:// but also the displayed link? I think it would look better to show it as simply www.example.com nevertheless.
2023-05-22 14217, 2023
kellnerd
s/look better/be more intuitive/
2023-05-22 14245, 2023
kellnerd
That wasn't easily doable with the old approach, but it is with the new one