Hey monkey, I've nearly completed the work on the alias and identifier section, but I need a little help regarding the PR. I've changed some file names and variable names, for example:
identifierEditor => identifierSection
alias-modal-body.tsx => alias-section-body.tsx
There are almost 80 file changes, where 10-12 are actual changes made by me, and the rest are just renaming. Even though the changes are just three or four lines of code in most of the files due to renaming, will it become hard for you to review the PR? If so, could you suggest some ideas to avoid this problem, please? :]
Maybe I can create the PR without renaming first, so you can review the alias and identifier section. After that, I can create another PR specifically for renaming the variables and files.
Does this sound good ? 🤔
Tarun_0x0 has quit
Tarun_0x0 joined the channel
Tarun_0x0 has quit
Tarun_0x0 joined the channel
monkey[m] joined the channel
monkey[m]
Tarun_0x0 (IRC): the way you describe it, it shouldn't be hard to review the PR. Easy changes like renaming don't make a big difference
Tarun_0x0
"Oh, great!
Also, monkey[m] could you take a look at this design implementation of the identifier section?
Tarun_0x0 (IRC): Looks pretty good, the presentation section (showing the items added) nothing to change. I think we can maybe improve the part where you can add a new item; in the identifiers section it's less of an issue, but in the alias section it's quite big and bulky, I think it can be improved a bit, even if only... (full message at <https://matrix.moviebrainz.org/_matrix/media/v3...>)
Tarun_0x0
Oh nice I didn't think of using that property. Let me give it a try
monkey[m] : though I haven't reduced the size of the input fields because for doing that we will have to make changes in the name section as well, and both the alias and name sections share a common input component, I did manage to bring it into the same line by reducing the button size and changing layout
To me, it looks like it is taking up a little bit more horizontal space. We can make it smaller, but it will look a little bit cramped.
please use this link :https://freeimage.host/i/JS7aK6x
Tarun_0x0 has quit
monkey[m]
Tarun_0x0 (IRC): A little bit of space between the aliases and the new row will help to give it more breathing room. In general I think this is a good direction and we can workshop it a bit during the PR review
Tarun_0x0 joined the channel
Tarun_0x0
yes, I also noticed that later, I already added some space there , I will update the PR by tomorrow ✅
