Tarun_0x0[m] (IRC): I'm not sure I understand the comment you posted above. For existing entities, we won't modify the database but rather rely on our regular entity validation to make sure that next time it is modified the user will have to either select an author for the author credit or set it as "no author"
2024-04-29 12038, 2024
monkey[m]
Not sure what doesn't seem feasible, but basically it only needs to be done next time the entity is edited
2024-04-29 12036, 2024
BrainzGit has quit
2024-04-29 12055, 2024
BrainzGit joined the channel
2024-04-29 12016, 2024
Tarun_0x0 joined the channel
2024-04-29 12033, 2024
Tarun_0x0 has quit
2024-04-29 12055, 2024
Tarun_0x0 joined the channel
2024-04-29 12015, 2024
Tarun_0x0
monkey[m] Hi ! I apologize. Maybe 4 5 days ago, I got confused. I thought that if someone had created a new entity with the 'No author credit' checkbox checked, there should be no warning on the entity page (for pre existing one) , which is not the case. So, I thought we had to edit all those pre-existing editions and edition groups to remove that
2024-04-29 12015, 2024
Tarun_0x0
warning , which was not looking feasible to me as there are many. That's why I asked that question due to the confusion.
2024-04-29 12016, 2024
Tarun_0x0
Sorry again; maybe all the exams and heat in India has taken over my mind. 😵💫
2024-04-29 12037, 2024
monkey[m]
Nothing to apologize for !
2024-04-29 12037, 2024
monkey[m]
I just want to make sure we're talking about the same thing
2024-04-29 12028, 2024
monkey[m]
> if someone had created a new entity with the 'No author credit' checkbox checked, there should be no warning on the entity page (for pre existing one)
2024-04-29 12028, 2024
monkey[m]
That sounds like what we want indeed, but I don't think we can achieve it. To be clear, if someone created an edition a year ago and checked no-author, currently there is no way that we can know if the no-author checkbox was ticked, as we don't store an indication in the database.
2024-04-29 12028, 2024
monkey[m]
So indeed, either we set ALL editions without an author credit as no-author (which would just be bad data) or we pester our users and force them to clarify the data (add an author or tick no-author) before they can save their changes
2024-04-29 12037, 2024
monkey[m]
Eek.
2024-04-29 12041, 2024
monkey[m]
That sounds like what we want indeed, but I don't think we can achieve it. To be clear, if someone created an edition a year ago and checked no-author, currently there is no way that we can know if the no-author checkbox was ticked, as we don't store an indication in the database.
2024-04-29 12041, 2024
monkey[m]
So indeed, either we set ALL editions without an author credit as no-author (which would just be bad data) or we pester our users and force them to clarify the data (add an author or tick no-author) before they can save their changes
2024-04-29 12052, 2024
Tarun_0x0
yes I got that part , That's why in the solution where we were saving the credit_section state in the database for all the pre-existing entities, I set that column as true (signifying that the entity requires author credits, thus the warning should be shown) for ALL the pre-existing entities. But with the new solution (using an empty author
2024-04-29 12052, 2024
Tarun_0x0
credit), we cannot do so. Additionally, as you mentioned:
2024-04-29 12053, 2024
Tarun_0x0
>ALL editions without an author credit as no-author (which would just be bad data)
2024-04-29 12053, 2024
Tarun_0x0
So, I guess we have to rely on users whenever they edit the entity next time.
