#bookbrainz

Tarun_0x0[m] (IRC): I'm not sure I understand the comment you posted above. For existing entities, we won't modify the database but rather rely on our regular entity validation to make sure that next time it is modified the user will have to either select an author for the author credit or set it as "no author"

Not sure what doesn't seem feasible, but basically it only needs to be done next time the entity is edited

monkey[m] Hi ! I apologize. Maybe 4 5 days ago, I got confused. I thought that if someone had created a new entity with the 'No author credit' checkbox checked, there should be no warning on the entity page (for pre existing one) , which is not the case. So, I thought we had to edit all those pre-existing editions and edition groups to remove that

warning , which was not looking feasible to me as there are many. That's why I asked that question due to the confusion.

Sorry again; maybe all the exams and heat in India has taken over my mind. 😵‍💫

Nothing to apologize for !

I just want to make sure we're talking about the same thing

> if someone had created a new entity with the 'No author credit' checkbox checked, there should be no warning on the entity page (for pre existing one)

That sounds like what we want indeed, but I don't think we can achieve it. To be clear, if someone created an edition a year ago and checked no-author, currently there is no way that we can know if the no-author checkbox was ticked, as we don't store an indication in the database.

So indeed, either we set ALL editions without an author credit as no-author (which would just be bad data) or we pester our users and force them to clarify the data (add an author or tick no-author) before they can save their changes

Eek.

That sounds like what we want indeed, but I don't think we can achieve it. To be clear, if someone created an edition a year ago and checked no-author, currently there is no way that we can know if the no-author checkbox was ticked, as we don't store an indication in the database.

So indeed, either we set ALL editions without an author credit as no-author (which would just be bad data) or we pester our users and force them to clarify the data (add an author or tick no-author) before they can save their changes

yes I got that part , That's why in the solution where we were saving the credit_section state in the database for all the pre-existing entities, I set that column as true (signifying that the entity requires author credits, thus the warning should be shown) for ALL the pre-existing entities. But with the new solution (using an empty author

credit), we cannot do so. Additionally, as you mentioned:

>ALL editions without an author credit as no-author (which would just be bad data)

So, I guess we have to rely on users whenever they edit the entity next time.

Thats' where I got to, yes