#bookbrainz

/

      • ansh has quit
      • discordbrainz2 joined the channel
      • discordbrainz has quit
      • discordbrainz2 is now known as discordbrainz
      • anonn joined the channel
      • kellnerd[m]
        My bad, the TS build errors for bb-data are kind of my fault:
      • > src/validators/edition-group.ts(55,88): error TS2339: Property 'size' does not exist on type 'unknown'.
      • > src/validators/edition.ts(130,88): error TS2339: Property 'size' does not exist on type 'unknown'.
      • monkey[m] joined the channel
      • monkey[m]
        Hah I was just looking at those :)
      • I'll commit a fix
      • kellnerd[m]
        Thanks! I copied this code from bb-site and didn't know how to please TS for these two cases. Strange that this wasn't an issue in bb-site already.
      • monkey[m]
        Hm, not obvious
      • It's there in bb-site too
      • (I mean an error)
      • kellnerd[m]
        `(formData.get('authorCreditEditor') as Iterable<unknown, unknown>)` works
      • monkey[m]
        Yeha, I was trying to go for more precise, but it wasn't happy with me
      • kellnerd[m]
        Technically we would need another isIterable check, but then I have no good idea what we should do for the new third case which never happens.
      • * Technically we would need another isIterable check, but then I have no good idea what we should do for the new third case which should never happen.
      • monkey[m]
        Something fishy in those types though.
      • kellnerd: I'm going to head out for the day but can continue looking closer at the type tomorrow. In the meantime: https://github.com/metabrainz/bookbrainz-data-j...
      • This resolves the failing build issue.
      • I won'
      • won't have time to deploy the package today (also fighting the GH workflow to deploy packages) but will do tomorrow
      • kellnerd[m]
        Question for the French readers: In the description of a book I assume "f. de pl. en coul." means "feuilles de pl. en couleur", but which word is abbreviated by "pl." here?
      • It is about coloured (paper) sheets in the book, so I assume it doesn't mean "plastique"
      • discordbrainz
        <10volumetrique> hmmm
      • <10volumetrique> good question
      • bitmap[m]
      • discordbrainz
        <10volumetrique> I've never heard of feuille de planche
      • kellnerd[m]
        BNF slang sounds reasonable at least, the sheets are a bit thicker than a regular page.
      • yvanzo[m] joined the channel
      • yvanzo[m]
        with a final t as in feuillet de planche
      • or plural: feuillets de planches
      • HumanG33k has quit
      • HumanG33k joined the channel
      • anonn has quit