monkey: Does HMR work for you on the BB import pages? I am getting the following warning in my browser when I first attempt to load a page with changes:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/kSIgctGJfuCqoQGlNpuwkRmi>)
2024-07-08 19041, 2024
kellnerd[m]
And when I attempt to reload the page manually, I get React errors for my changes:
2024-07-08 19041, 2024
kellnerd[m]
> Warning: Prop `className` did not match. Server: "margin-top-2 btn-group" Client: "text-center margin-top-2 btn-group"
2024-07-08 19058, 2024
kellnerd[m]
(I am in the process of resolving a few React property issues which are spamming my server logs.)
2024-07-08 19053, 2024
kellnerd[m]
Just in case it wasn't clear: HMR is working for me on other pages, e.g. the statistics page.
2024-07-08 19057, 2024
monkey[m]
Hm, no I hadn't noticed, let me try. There might be some configuration things that have changed since '18
2024-07-08 19032, 2024
kellnerd[m]
Ah, I think I got it.
2024-07-08 19041, 2024
monkey[m]
Yep me too
2024-07-08 19051, 2024
monkey[m]
module.hot.accept thing missing in the controller
2024-07-08 19016, 2024
monkey[m]
was just rebuilding
2024-07-08 19045, 2024
monkey[m]
Hm, still not working
2024-07-08 19047, 2024
kellnerd[m]
I thought that my changes to webpack.client.js were enough, but that line in every controller module is also necessary...
2024-07-08 19021, 2024
monkey[m]
Ah, user error
2024-07-08 19028, 2024
monkey[m]
(modified wrong controller)
2024-07-08 19052, 2024
kellnerd[m]
For me it worked even without restarting the dev server.
2024-07-08 19003, 2024
monkey[m]
Ah I didn't think to check
2024-07-08 19025, 2024
monkey[m]
Yep working
2024-07-08 19004, 2024
kellnerd[m]
Since I had already fixed the button alignment to please React, I also did the message box:
2024-07-08 19011, 2024
kellnerd[m] uploaded an image: (60KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/HfzKMTdEkSSnVnWTdbAnCvlN/image.png >
2024-07-08 19005, 2024
kellnerd[m]
Now both the server logs and the UI are looking better and I can focus on the actual things I wanted to do.
