#bookbrainz

Hmm, I just found out why annotations are not implemented for imported entities, they have last_revision_id INT NOT NULL.

Since an import does not have a revision, it is not possible to create a valid annotation row for it.

So we either have to use a special revision ID 0 or NULL for these imported annotations (and handle the consequences in bb-site), or we just forbid importing annotations (since they are supposed to be CC0 and should not contain potentially copyrighted stuff anyway).

That's unfortunate.

I don't think we should mess with special cased revision ids

Is there any way we could store the text content in a DB column instead?

I mean, there are ways, I mean more "maybe we can investigate..."

Pfff, no great ways to go about it

I feel like annotations will be crucial to allow us at least to put the imported data that does not fit in the current schema somewhere

The code changes to support NULL revision ID look like they would probably be minimal

Yeah, currently we are hiding data which does not fit in a JSON column, exposing (parts of) it in the annotation makes sense.

If we can have NULL values for annotation.last_revision_id that would be great, I already have the necessary ORM importer code ready.

* not fit the schema in a

ORM PR is up, do you want to look into the annotation schema change monkey, then I can focus on the actual importer changes which I wanted to do?

Yes, let's do that

Sorry for slow, there's construction happening in my apartment today, I keep having to stop

Here we go kellnerd, https://github.com/metabrainz/bookbrainz-site/p...

Several small changes across all three repos later importing and (editing and) approving entities with annotations is now working ⏳️

And I've come to the conclusion that it would be better to get rid of the "Edit & Approve" action in favor of just "Approve" and the standard "Edit" function of regular entities.

The small convenience of that action does not justify the two extra code paths to convert from import data to editor form data and the separate form submission handler.

Aside from the extra amount of code/maintenance, there are still disadvantages:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

Especially the third point is not worth solving at the expense of making the separate form submission handler even more complex rather than getting rid of it.