#bookbrainz

/

      • anonn joined the channel
      • 2024-07-29 21109, 2024

      • Guest64 joined the channel
      • 2024-07-29 21119, 2024

      • Guest64 has quit
      • 2024-07-29 21124, 2024

      • kellnerd[m] joined the channel
      • 2024-07-29 21125, 2024

      • kellnerd[m]
        Hello monkey ! I have finally [changed the schema](https://github.com/kellnerd/bookbrainz-si… to merge the `import` into the `entity` table.
      • 2024-07-29 21134, 2024

      • monkey[m] joined the channel
      • 2024-07-29 21134, 2024

      • monkey[m]
        Great, thank you!
      • 2024-07-29 21135, 2024

      • monkey[m]
        I'm finishing a few things today but have planned to review your PRs tomorrow, perfect timing :)
      • 2024-07-29 21108, 2024

      • kellnerd[m]
        While I was at it, I've also [renamed](https://github.com/kellnerd/bookbrainz-s… a few import related columns and a table to give them more descriptive names.
      • 2024-07-29 21103, 2024

      • kellnerd[m]
        Still untested as I would love to have a quick sanity check before I'm going to create migrations and update the ORM.
      • 2024-07-29 21133, 2024

      • monkey[m]
        Yes, the renaming was a good idea, it's clearer now.
      • 2024-07-29 21150, 2024

      • monkey[m]
        Also the right time to be doing any changes on the imports sql
      • 2024-07-29 21151, 2024

      • kellnerd[m]
        Especially if you agree with the new names, I don't want to rename them in all places twice :)
      • 2024-07-29 21124, 2024

      • kellnerd[m]
        s/if/whether/
      • 2024-07-29 21118, 2024

      • monkey[m]
        Here, the difference between import_bbid and entity_bbid is not instantly clear. Is the entity_bbid used once the import has been accepted?
      • 2024-07-29 21145, 2024

      • monkey[m]
      • 2024-07-29 21146, 2024

      • kellnerd[m]
        You are right, they are not 100% clear as I am still not 100% clear how they will be used in the end. Maybe pending_bbid and accepted_bbid would be better names.
      • 2024-07-29 21128, 2024

      • monkey[m]
        I don't mind a verbose accepted_entity_bbid, even
      • 2024-07-29 21153, 2024

      • kellnerd[m]
        I've just drawn a table with all possible scenarios I could come up with because I was no longer sure whether the second BBID column was necessary at all.
      • 2024-07-29 21126, 2024

      • monkey[m]
        I guess if we want to be able to merge an imported entity's data into an existing entity?
      • 2024-07-29 21149, 2024

      • kellnerd[m]
        There are five meaningful cases for the pair (pending_entity_bbid, accepted_entity_bbid):
      • 2024-07-29 21107, 2024

      • kellnerd[m]
        1. (A, null) = new pending import
      • 2024-07-29 21123, 2024

      • kellnerd[m]
        2. (A, A) = accepted import
      • 2024-07-29 21139, 2024

      • kellnerd[m]
        3. (null, null) = discarded import
      • 2024-07-29 21103, 2024

      • kellnerd[m]
        4. (B, A) = update is pending
      • 2024-07-29 21103, 2024

      • kellnerd[m]
        5. (null, A) = theoretical possibility to seed the table with manually added entities which have the external identifier
      • 2024-07-29 21154, 2024

      • kellnerd[m]
        Thanks, I've [renamed these two columns](https://github.com/kellnerd/bookbrainz-s… again.
      • 2024-07-29 21100, 2024

      • monkey[m]
        Thanks for the explanation!
      • 2024-07-29 21155, 2024

      • kellnerd[m]
        I think migrating potentially existing imports into the new schema is not worth the effort, what do you think monkey?
      • 2024-07-29 21112, 2024

      • kellnerd[m]
        Or should I even just adapt the existing migration script again?
      • 2024-07-29 21122, 2024

      • monkey[m]
        I would honestly nuke whatever is there, if any (assuming there is nothing, from what I remember)
      • 2024-07-29 21154, 2024

      • monkey[m]
        As a matter of fact I may have nuked the tables already, or the previous sql migrations scripts were never run against the production DB, because there are no import tables
      • 2024-07-29 21134, 2024

      • ansh joined the channel
      • 2024-07-29 21145, 2024

      • anonn has quit