#bookbrainz

Hello @reosarevok

Hello reosarevok (@_discord_1151240977378463764:chatbrainz.org)

Hi! Matrix is showing this weird but I understand it's for me? :)

Might be for me actually :)

Hi tarunj292

Sir i have a solution for bb-769

To address the issue of deleted editions appearing in the author's page, I suggest two potential solutions:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

I need help in implementation

Shoot your questions :)

To address the issue of deleted editions appearing in the author's page, I suggest two potential solutions:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

tarunj292: I'm looking into the issue now, and I think your suggestions would be good for solving the symptom, but not the cause.

In this case, looking at how we load these editions in the first place here: https://github.com/metabrainz/bookbrainz-site/b...

Looks like the ORM code needs to be amended to ignore Editions that are deleted, in this code here: https://github.com/metabrainz/bookbrainz-data-j...

I guess you'll need to figure out how to filter out deleted editions (as you figured out, it will be the ones that have data_id = NULL) as part of this hasMany relationship. I can point you to the BookshelfJS docs: https://bookshelfjs.org/api.html although I am not sure how to do the requested change

I also see that we have a separate `getEditionsCreditedToAuthor` function that does filter out deleted entities: https://github.com/metabrainz/bookbrainz-data-j...

So alternatively you could find out how to use this function to load the editions instead of the code here https://github.com/metabrainz/bookbrainz-site/b...

Thanks for looking into this! I see your point about addressing the root cause. Amending the ORM code to filter out deleted editions directly would definitely be the cleaner solution.

I'll keep you posted as I dig into this further. Thanks for the pointers!

From what I can tell, the getEditionsCreditedToAuthor is probably easier than trying to filter out editions while using hasMany, but you'll need to figure out how and where to use it

Don't hesitate if you have more questions