#bookbrainz

/

      • elkiensad[m] joined the channel
      • elkiensad[m]
        I just added the book I read to test the site. The UX on mobile is really great and very fast, but the clear documentation is lacking because I had to look at a lot of examples to understand what was what and what I needed to do (and I’m still not sure if I did it right). Anyways: https://bookbrainz.org/work/d20ce032-2b77-45df-...
      • spynxic has quit
      • spynxic joined the channel
      • spynxic has quit
      • spynxic joined the channel
      • spynxic has quit
      • spynxic joined the channel
      • G0d joined the channel
      • kellnerd[m]
        Looking good to me, and yes, the documentation is still sparse.
      • innocuous has quit
      • innocuous joined the channel
      • monika_19[m] joined the channel
      • monika_19[m]
        Was trying to debug #BB-806 Can't submit entries with float values for dimensions - for solution wanted to ask that, Database Modification: Should I adjust the database schema to accept decimal numbers, allowing users to submit float values?
      • Frontend Validation: Alternatively, would it be better to implement frontend validation that informs users that only whole numbers are allowed when they try to input float values?
      • BrainzBot
        BB-806: Can't submit entries with float values for dimensions https://tickets.metabrainz.org/browse/BB-806
      • monkey[m] joined the channel
      • monkey[m]
        monika_.19: The database modification seems like the way to go, integers only is restrictive for no good reason as far as I can tell
      • monika_19[m]
        Thank you for your insight regarding #BB-806! I’ll adjust the schema to accept decimal numbers for dimensions, ensuring users can submit float values without restrictions.
      • BrainzBot
        BB-806: Can't submit entries with float values for dimensions https://tickets.metabrainz.org/browse/BB-806
      • monkey[m]
        Great :) I think a real type with 6 decimal digits should be appropriate for these dimensions values: https://www.postgresql.org/docs/current/datatyp...
      • kellnerd[m]
        Hmm, I wonder if that really makes sense given the unit is mm?
      • I can hardly imagine someone trying to enter micrometer dimensions except for weird edge cases like the smallest book in the world
      • monkey[m]
        Mmm, I misunderstood the issue indeed
      • I guess the issue here is more about being able to input mm or cm (with decimal point) and converting automatically to store in the database as we currently do.
      • There's an issue for that I think, but I have to run to a meeting now
      • kellnerd[m]
        That would be BB-620
      • BrainzBot
        BB-620: Allow measurements in more formats https://tickets.metabrainz.org/browse/BB-620
      • monika_19[m]
        Should I move forward with modifying the database to accept decimal values for dimensions?
      • kellnerd[m]
        Probably not, starting with a simple input validation before potentially moving on to BB-620 sounds more sensible to me.
      • BrainzBot
        BB-620: Allow measurements in more formats https://tickets.metabrainz.org/browse/BB-620
      • monkey[m]
        kellnerd: Got it in in time?
      • G0d has quit
      • G0d joined the channel
      • kellnerd[m]
        monkey: Sure, I already submitted the Google form yesterday. Only the WordPress page behind the link which I submitted with the form still has to be filled with content.
      • aerozol[m]1 joined the channel
      • aerozol[m]1
        I find this last minute submission so stressful, even from a distance 😅
      • kellnerd[m]
        Yeah, for my usual level of perfection I started to late with the blog post.
      • I underestimated how long it would take to get the three PRs ready and opened with a good description.
      • aerozol[m]1
        Let me know if I can help with anything! Maybe you can leverage your good PR descriptions into blog post content
      • kellnerd[m]
        Hehe, I am leveraging everything from my proposal, last year's post, meeting notes, PRs etc. I only have to combine all the ingredients into a fluent text, and as you know me that alone might still take ages.
      • aerozol[m]1
        Well, remember that the Google requirement is not to have a perfect blog post! Though I know you will ;)
      • G0d has quit