I had been thinking about the same idea, although it seemed less than pressing I think it would remove an unnecessary step
2022-09-13 25659, 2022
monkey
There was always the option that the orm could be used in other projzcts, but that hasn't been the case
2022-09-13 25616, 2022
Shubh
monkey: whenever you get time, can you please put early-submit branch on test?
2022-09-13 25654, 2022
monkey
Will do Shubh
2022-09-13 25651, 2022
monkey
Woops, forgot to say test is up to date Shubh
2022-09-13 25609, 2022
monkey
I'm still seeing some small issues in the series section that we'll have to iron out. After creating a new series inline in the content tab, the works don't appear as a list underneath. After you uncheck and recheck "add works to series" then select the series, the works do appear underneath but their names are undefined (the correct disambiguation is shown though): https://usercontent.irccloud-cdn.com/file/7HogZeg…
2022-09-13 25625, 2022
monkey
And it looks like with the act of unchecking/rechecking add works to series and reselecting the new inline series, the series is not part of the entities shown in the submit tab recap.
2022-09-13 25652, 2022
monkey
Just making notes of things that need fixing, but they're all small things at this point :)
2022-09-13 25613, 2022
Shubh
monkey: not able to reproduce unnamed entity issue, any specific steps that i might be missing?
Surely it's just about accessing the right prop, because the disambiguation shows correctly
2022-09-13 25644, 2022
CatQuest
so i have an idea
2022-09-13 25644, 2022
CatQuest
for the new create entity roundabout. how about having both abilities on beta? so that people can use this new editor to add real live empirical data and test it, but also have the old way to fallbakc on incase thereare bugs or someting is broken?
2022-09-13 25641, 2022
CatQuest
I haven't tested it with the latest iteration but I still remembr not being able to add amagazine and not finding out why not
2022-09-13 25605, 2022
CatQuest
I would suspect the old routine being removed after a week or so of testing the new one
2022-09-13 25628, 2022
CatQuest
putting the old ruitine in a different area or "fall bakc old way link" only
2022-09-13 25636, 2022
CatQuest
so people are forced to test this new
2022-09-13 25624, 2022
CatQuest
we should also make bannner on bb to make aware of it, we should post on blog, twitter and community, to ask people to come try break this new thing:D
2022-09-13 25645, 2022
Shubh
once obvious bugs are out of the way (like series section currently), i think then we can go for beta
2022-09-13 25612, 2022
CatQuest
yes I mean. put this on beta, but also keep the old version just in case
2022-09-13 25630, 2022
CatQuest
well i dunno
2022-09-13 25647, 2022
CatQuest
have you made the popup work boxes not have al lthe bits collapsible?
2022-09-13 25639, 2022
Shubh
CatQuest: not sure what you meant by popup work boxes, but i did make some of them opened by default in creation modal.
2022-09-13 25652, 2022
CatQuest
yep that
2022-09-13 25613, 2022
CatQuest
the popup creation of works, there really is no reason that anything thre is "cllapsed"
2022-09-13 25628, 2022
CatQuest
collapsed means "we don't care about this data"
2022-09-13 25649, 2022
CatQuest
and someone (me) who wants to add it will have to uncollaps it Every Time
2022-09-13 25629, 2022
Shubh
let me know what do you think about current popup box.
CatQuest: Regarding the "fallback to existing forms" that was always the goal. We're leaving the existing entity forms as-is, just adding a new 'Book' unified editor, so no worries there.
2022-09-13 25602, 2022
monkey
Shubh: I'll have a look
2022-09-13 25612, 2022
CatQuest
oh! cool!
2022-09-13 25616, 2022
CatQuest
that seems really neat
2022-09-13 25645, 2022
monkey
Shubh: Maybe try adding `defaultAlias.name` in there? Not sure if that will work but worth a try
2022-09-13 25641, 2022
Shubh
tried but no luck, though aliases does seem to have that default alias
2022-09-13 25603, 2022
monkey
Yep, that's what I just saw looking at the props passed to the Relationship component
2022-09-13 25629, 2022
Shubh
also i get defaultAlias from `/search` route using the same relations
2022-09-13 25637, 2022
monkey
And they are surely loaded one way or another, because search indexing does work once the entity is created
Though we can use this but still not sure why defaultAlias thing wasn't working
2022-09-13 25646, 2022
monkey
Yep, same here. perhaps `load` isn't the ORM model function we need, but as far as I understand it it should work
2022-09-13 25638, 2022
monkey has quit
2022-09-13 25602, 2022
monkey joined the channel
2022-09-13 25641, 2022
Shubh
monkey: I fixed the issues, except maybe one which is when we create new work it add itself to series item but relation show series as new entity due to null defaultAlias.
2022-09-13 25623, 2022
Shubh
I suspect function initially captures the null series in its scope and get passed down to child component but once we have series function doesn't get updated in child component (might be due to memoizing?) which resulted in null series in relation.
2022-09-13 25651, 2022
Shubh
I'm not sure how should i go about resolving this issue.
