#bookbrainz

monkey Hi. I fixed the author and Disambiguation in this issue https://tickets.metabrainz.org/browse/BB-703. I also added loadGender middelware in series get request ```router.get('/:bbid', middleware.loadEntityRelationships, middleware.loadSeriesItems,middleware.loadGenders, (req, res) => {

 _setSeriesTitle(res);

BB-703: Series of authors are not displayed correctly

 entityRoutes.displayEntity(req, res);

});``` . can you help me with next steps?

Hi Siddhart1o1, monkey's probably asleep right now.

Do you have a PR that he can review?

yes

monkey told me to make changes. But I have some confusion in Genders Field

OK, I'm not familiar with the code base, so I'm afraid I won't be of much help.

I do see a bunch of ESlint errors though that are probably worth addressing in the meantime.

s/errors/warnings/

Actually both errors and warnings.

yes these will be fixed. Do you know any docs from which i can get understanding of CodeBase?

Siddhart1o1: I'll review the PR on Monday :)

In the meantime, if you were looking for docs, we have: https://bookbrainz-dev-docs.readthedocs.io/en/l... with some description of the schema and other moving parts of the codebase

monkey Thanks.  Actually I Have not made new PR I wanted to some help in gender Field rest I have done. I added ```loadGenders``` middleware as you said, but I am not able to understand further.

I will wait for your further instruction. Meanwhile I will explore codebase, different projects and bugs. Thanks.

Or you can suggest some resources for the framework we are using, or any library. which will help me understand the codebase

Hello guys. I am interested in contributing to bookbrainz. I ran into an issue while setting up the project. I went through the chat backlog and couldnt find a solution.

The issue is that i'm getting the error "/usr/bin/env: ‘bash\r’: No such file or directory" when i run  "/usr/bin/env: ‘bash\r’: No such file or directory"

i'm using wsl on windows

sorry i meant when i run ./scripts/database-init-docker.sh

If anyone could save me some time i'll appreiate

Hi Deogee. Welcome!

What OS are you using?

i'm using wsl on windows

Heh, yeah, just saw you said that. Sorry. Slowpoke here.

OK, so are you in a bash shell when running the script?

haha no worries

yes i am

OK, standby...

Alright

So, you're trying to run the `./scripts/database-init-docker.sh` script?

 yes , i also tried navigating to th bookbrainz-site folder and running yarn install

But i get the same error

How are you trying to run the script?

i went inside the file and manually type the script

The first one is docker-compose up

Thats where i get the error

after running docker-compose up

Oh, definitely do not try to type each line of the script, if that's what you mean.

sorry i did'nt clarify that

You should just let bash execute the script by typing ./scripts/database-init-docker.sh.

 i could'nt run this "`./scripts/database-init-docker.sh`" on wsl

What happens when you try that?

Oh, and exclude the `backticks`.

i still get "/usr/bin/env: ‘bash\r’: No such file or directory"

Hmm.

What happens if you type /usr/bin/env in the bash shell?

Hey Rohan this side, I would love to contribute to BookBrainz this summer :) currently going through the documentation for the project and will come with a draft proposal really soon :))

Hi RohanSasne. Welcome!

i'm trying to send a file of what i get

its basically a bunch of stuffs

You can't send files over IRC. You can paste as a gist in GitHub?

SHELL=/bin/bash

NVM_INC=/home/deogee/.nvm/versions/node/v18.14.2/include/node

WSL2_GUI_APPS_ENABLED=1

WSL_DISTRO_NAME=Ubuntu

WT_SESSION=ea072174-e9d9-4be9-9dff-303c0c1cb9cd

NAME=DESKTOP-GLQ2AJ4

PWD=/mnt/c/Users/ahmad/Desktop/Projects/Web/github/bookbrainz-site

LOGNAME=deogee

HOME=/home/deogee

LANG=C.UTF-8

These are the first few lines

OK, that's good. That tells us that `env` is there.

And if you type `bash` in the command line? (It should seem like it's does nothing with no error.)

No error.. But nothings logged also

Right. OK.

Hmm.

So, let's try typing manually: /usr/bin/env bash

Seems to do nothing, no error?

Exactly. No error, nothing logged

OK, did you modify this script in some way?

I think it's the \r at the end that's the problem.

I suspect you may have edited the file with an editor in Windows, and it modified the script to add CR to the end of lines.

I don't think i did. But just incase i'll clone the repo and try again

OK.

Ah.

Here's another clue.

It seems that git will add CRs to lines.

In Windows.

See this: https://stackoverflow.com/questions/2466959/git...

i'm checking it out

By the way i ran other scripts in the same folder and i get the same error

cloning...

Seems that you'll need to set core.autocrlf to false and clone.

This will be worth noting in the documentation.

let me try so

It'll definatly  help in the documentation

''''''''''''''''''''''

oops that was a mistak

OK, for checking out the files only, core.autocrlf false is safe, but for working on the project, the safest is core.autocrlf input.

This way if any files are committed by you, any CRs will be removed.

 i did core.autocrlf false and now i'm getting  '-bash: /scripts: No such file or directory'

even though i can clealy see the file

Did you put dot in front of scripts? ./scripts/...

i did

and i see the folder when i type ls

So exact command you're entering is?

./scripts/database-init-docker.sh

Hmm.

How did you set core.autocrlf false?

i typed "git config --global core.safecrlf false" on the terminal before cloning

OK.

i'll delete and try cloning again

Just for fun, if it happens again, run "bash" inside of the command line before running the "./scripts/database-init-docker.sh" command.

Alright

Same error(/usr/bin/env: ‘bash\r’: No such file or directory) even after typing "bash" before running the command

That error tells me that the clone is still somehow pulling CRs.

(Inserting CRs.)

Oh, you set core.safecrlf?

core.safecrlf != core.autocrlf

i did these

git config --global core.autocrlf true

git config --global core.safecrlf false

As said here https://stackoverflow.com/questions/2466959/git...

i ran the two commands before cloning

core.autocrlf true is the opposite of what we want here.

I would suggest setting it to input.

what about core.safecrif

Geez, the git docs aren't very clear. Reading...

haha i'm going through them too

OK.

So...

Things are recommending that for Windows, you should checkout with CRLF, but we don't want that here because we're going to run these in docker, which is a Linux environment, which rejects the CRs.