#bookbrainz

Thanks for holding the fort over the weekend pbryan !

monkey: Regarding my comment at https://github.com/metabrainz/bookbrainz-site/p..., I don't think that JIRA automation for GitHub PRs is set up at all for BB currently.

Ah, thanks, I'll have a look

It's definitely set up, I've seen it at work recently, but I think it's not reacting to updates to PR titles.

Interesting, do you have an example for me? I've just tried to find a ticket which has a comment with a link to a PR but had no luck.

Huh, well I must have been thinking about ListenBrainz and been blind to the absence in BookBrainz… Can't find a single example.

Thanks for reporting, I'll see how to set it up properly

Good to know that I'm not just blind :)

But bad to know that I am ! XD

My brain still can't accept the facts.

To your defense: I also assumed it was set up because all(?) other projects have it set up

Hi monkey. So it would seem .gitattributes needs to be adjusted.

I saw your conversation. If you've figured out exactly what needs changing, could you please open a PR?

Looks like whatever I did way back did not work: https://github.com/metabrainz/bookbrainz-site/c...

> Add .gitattributes file to fix cross-platform line-ending issues

OK, the challenge will be testing. I'll see about getting a Windows VM setup so I can prove it works.

Can't help you there I'm afraid, no Windows machines around. If VM is too cumbersome, we could ask assistance from other people on the channel who are on Win

I have a Windows machine, but my Git for Windows autocrlf  option is already set up correctly to avoid CRLF (although I always forget the correct value to achieve this), so I won't be a useful tester.

I've got an ISO around here somewhere. Cue rummaging sounds. 😉

Much appreciated

kellnerd: There's definitely some interaction between GH and JIRA, I wasn't entirely blind after all. See the last comment here: https://tickets.metabrainz.org/browse/BB-667?fo...

However I would expect a "Development" dropdown on the right hand side with the PR listed underneath. Will continue investigating.

BB-667: Bug when modifying Series relationship in Edition

kellnerd: So it turns out everything was working fine with JIRA-Github integration, but 1. I was just not paying enough attention to the formatting of pull request titles and 2. The 'development' dropdown in JIRA is a separate thing to the "Github Bot" comments on the ticket.In your use-case, are the comments on the ticket good enough? https://usercontent.irccloud-cdn.com/file/NpZZ9...

Yay! Comments are usually enough for me. Only if there are multiple PRs or direct commits to main the development dropdown is good to have.

OK, will see where we stand on that, as it's a question for the rest of the MeB projects as well

pbryan: I'm just looking into BB-712. Do you have a good real world example of an entity which has an alias with a comma?

BB-712: Change alias delimiter on entity detail pages https://tickets.metabrainz.org/browse/BB-712

Because a simple change of the alias separator would affect all entity types and what looks good for e.g. authors might not for editions.

For author aliases most separators (including comma and middle dot) are probably fine, but for editions/works the alias titles may contain any punctuation that would fit as alias separator (e.g. slashes, dashes, pipes...)

I'll see if I can find a good example.

kellerd, here are the first 5 examples I've found:

Thanks, so the comma is a problem for elaborate work titles, of course :)

Yes, basically anything with a comma conflicts with the delimiter we're using to separate aliases.

I'm sure there are authors with some kind of title or suffix with a comma as well.

I've attached a demo screenshot to the ticket, if monkey agrees and nobody else objects, I will submit a PR.

It makes a lot of sense with works, for sure. I wasn't originally convinced the author aliases would be an issue, but I can definitely see the value in this improvement

Middle dot works well. I was thinking of the Catalan "punt volant" (or "flying dot") which is a fatter version of the same, if we want something less subtle

We could also make the separator configurable per entity type if we consider some of them unproblematic and better-looking with a comma.

Hm, might be the same character actually

Im in favor of a homogenous solution

+1

+1

Even https://en.wikipedia.org/wiki/Template:Navbox_p... uses the interpunct as separator for the different punctuation marks :')

Hah, it's a mess on this page, but you're right, the fact that it's still usable is a good point in favor fo the interpunct

That wikipedia page is using <ul> and stylesheet to separate entries, so a bit different than how BB displays them.

That's an interesting approach, actually.

It's not a bad solution, to be honest

Hah, devs drooling on other people's CSS solutions :D

🤤

Yeah, I'm currently looking at having proper markup for the individual aliases. I thought about spans but inline lists also work.

It depends on whether we want to keep the simple <h4> markup here: https://github.com/metabrainz/bookbrainz-site/b...

I'm not attached. It doesn't make much sense in terms of HTML hierarchy, so it's probably like that mainly for styling

Which means, if you're reviewing the styling anyway, it can just be scrapped

Ok, I will try to turn this into something like `<ul class="inline-aliases">` then.

Sounds good. Thank you !

Nice!

Almost there, I only have to copy the h4 styling from lobes4.

Should I use the Roboto font of h4 as previously (only used for headings) or should I keep the default Sintony font?

"Keep" as in not overwrite it

Hm.

I don't see much of a reason to use Roboto now that we're moving away from using header tags. I doubt it was on purpose.

But if you think it looks better to have the same font as the main alias just above, we could use Roboto

Ok, I'm experimenting a bit. I guess we definitely want to keep font-size and probably also font-weight (only 300 for headings, while it is 400 elsewhere).

Hmm, interesting. If I use git in WSL, everything is great.

If I use git installed in Windows, I get `\r` line endings. So, reproduced at least.

I'm surprised at how well integration WSL is. Not enough to make me want to switch to Windows, but...

Never have used SCSS before, but TIL that I can simply use `@extend h4;` instead of copying properties or finding the names of the appropriate SCSS variables.

Indeed

monkey: Would it be safe to say we want all text files in GH to be Unix style (never have CRs)?

I… suppose? It's been so long I haven't Windowsed that I don't know what the implications could be

If I have my facts straight, it means most good editors on Windows will be fine with it. Notepad will not work well.

So, VScode, Sublime, etc. should all function.

I think that's a sacrifice worth doing

Heh, OK.

Listenbrainz doesn't have much more than we do in gitattributes, not sure why we never have an issue there: https://github.com/metabrainz/listenbrainz-serv...

But ¯\_(ツ)_ /¯ if you're fixing the repo for Windows users I'd say let's do it.

This currently occurs when one uses Windows git, and tries to run shell scripts inside of WSL.

I'm thinking though, to keep files from bouncing between LF and CRLF, just force LF across the board.

Ahh, with the provided git bash?

Yes. The git bash.

That pesky bash.

Well, it's more git itself realizing it's running on Windows.

"I'll just sprinkle some CRs in these files..."

Well, I don't see why we would need CRLF to be honest

Yeah, same. LF keeps it simple.

OK, testing.

So PR by itself, or open JIRA ticket too?

PR is fine

OK.

Hi monkey can you please Review my PR https://github.com/metabrainz/bookbrainz-site/p...

Hi Siddhart1o1 sorry I didn't get to your PR yet. I'll give it a look now

Thanks!

Hello

I am working on issue BB-705 and i have a question

When adding a new Work entity or any other entity where do the options come from ?

BB-705: Add "Essay" work type https://tickets.metabrainz.org/browse/BB-705

I went through the codebase and it looks like the options(in this case Novel , short story , poem....) are gotten from the database and stored in the redux store

I am trying to add "Essay" to the list of work type options

Do i just need to add "Essay" to the database and that will you suffice ?

Hi Deogee ! Yes unfortunately this can only be aded to the database and I'm the only one with the keys :) Please pick another ticket !

I hadn't seen it was marked as a good first bug, my bad !