#bookbrainz

Hello everyone !!! I hope you're all doing great. I'm currently working on resolving issue BB-768 and trying to make changes in bookbrainz-data-js repository. However, when attempting to commit my changes, I came across thousands of linting errors, none of which were caused by me. I would greatly appreciate it if someone could lend a hand in

helping me navigate past this hurdle so that I can proceed with making a pull request. Thank you very much!

BB-768: Unset Author Credit leads to bugs https://tickets.metabrainz.org/browse/BB-768

Hi Tarun_0x0

Let me see if I can reproduce the same issue

Where do you see the linting errors exactly?

So, from a fresh repo on master branch, running `npm run lint` (the command we use for linting), I'm faced with 13 warnings, 0 errors.

All the warnings are about "todo" comments in the code

So far off from what you're seeing :)

I suspect your code editor might not be taking the ESLint rules we have in place?

just when i am trying to commit my changes from my local branch it shows a git lint error , then in terminal whenever i run npm run lint it shows

✖ 15321 problems (15308 errors, 13 warnings)

  15202 errors and 0 warnings potentially fixable with the `--fix` option.

i.e. the .eslintrc.js file in the root of the project is the configuration. Try to see why it's not respecting that. maybe expecting .eslintrc, without the .js at the end?

Huh

Well, um. Do you have a whole bunch of file changes if you run `git status`?

no i only modified two file , those two are only in my git status

I have no idea what could be going on, to be honest.

well almost all errors are about this

 1:51 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

Ahhh, that's a good clue :)

Line endings issue between unix and windows

Hang in there for a sec

maybe i should also retry from a fresh repo

Hang on

Ahhaa

read the part that starts with "[/usr/bin/env: 'bash\r': No such file or directory] "

I think the command we're looking for is `git config --global core.autocrlf input` as described there. Let me check quickly that it's right

Reading https://docs.github.com/en/get-started/getting-...

Huh, when has our RTD theme changed?

Yep, looks about right. Please do read that GH docs page Tarun_0x0, it has all the answers you should need

kellnerd: January, during docsprint. I updated some dependencies, came with snazzy new theme

Ah, it will take me some time to get used to it, I kind of miss the previous colors :)

truly appreciate your help monkey and let me give this a try =D

kellnerd: We can always revert, I'm neutral on the subject. Is it just the change you don't like?

The only thing which is worse UX wise is that the navigation sidebar is no longer sticky, that left column is just wasting screen space and makes it harder to navigate.

I can get behind that. I had other issues with teh previous sidebar, but I did like the stickiness

wait bookbrainz changed colours?

No, the user developer guide readthedocs did

uh ok? but isn't that user(per thingy) set?

als othat wasn't gone throug for reasonstoo wasn't it :(

Sorry, I didn't understand any of that

uh read the docs can have the colours set by whoever makede the whatever isntance o read the docs it is. so colours are customisable

Ah, yes.