kepstin: can you help me understand why the magicisrc login cookie timeout is so short? surely it doesn't matter if... uh... someone... who.. gains... access... to my computer ... can ... submit ISRCs without logging in?
2025-01-15 01542, 2025
derwin
"external links" seems to be reliably not loading when adding artists from the release editor
2025-01-15 01539, 2025
vardhan_ has quit
2025-01-15 01557, 2025
vardhan_ joined the channel
2025-01-15 01554, 2025
vardhan_ has quit
2025-01-15 01516, 2025
vardhan_ joined the channel
2025-01-15 01554, 2025
yano has quit
2025-01-15 01554, 2025
atticf joined the channel
2025-01-15 01552, 2025
yano joined the channel
2025-01-15 01515, 2025
kepstinbrainz joined the channel
2025-01-15 01515, 2025
kepstinbrainz
derwin (IRC): it's because i haven't implemented support for oauth refresh tokens. so the login cookie is limited by the length of time that the oauth token received from musicbrainz lasts for
2025-01-15 01508, 2025
kepstinbrainz
i haven't bothered fixing it since it's pretty quick to relogin since musicbrainz remembers your login, at least :)
2025-01-15 01521, 2025
derwin
oh, that makes sense. yeah, it's only annoying if you're editing on and off over the course of multiple hours and have to log in multiple times.
2025-01-15 01543, 2025
d4rk-ph0enix has quit
2025-01-15 01558, 2025
d4rk-ph0enix joined the channel
2025-01-15 01522, 2025
reosarevok[m]
Oh, I was wondering the same :)
2025-01-15 01550, 2025
MeatPupp3t21 has quit
2025-01-15 01539, 2025
MeatPupp3t21 joined the channel
2025-01-15 01559, 2025
thuna` has quit
2025-01-15 01552, 2025
JadedBlueEyes has quit
2025-01-15 01504, 2025
JadedBlueEyes joined the channel
2025-01-15 01501, 2025
_justin_kelly0 joined the channel
2025-01-15 01546, 2025
_justin_kelly has quit
2025-01-15 01546, 2025
_justin_kelly0 is now known as _justin_kelly
2025-01-15 01509, 2025
minimal joined the channel
2025-01-15 01555, 2025
theracermaster2 has quit
2025-01-15 01536, 2025
texke has quit
2025-01-15 01540, 2025
texke joined the channel
2025-01-15 01557, 2025
d4rk-ph0enix has quit
2025-01-15 01524, 2025
d4rk-ph0enix joined the channel
2025-01-15 01528, 2025
sentriz has quit
2025-01-15 01536, 2025
vardhan_ has quit
2025-01-15 01547, 2025
duckfromdisc[m] joined the channel
2025-01-15 01548, 2025
duckfromdisc[m]
it doesnt remember mine
2025-01-15 01554, 2025
duckfromdisc[m]
i have to relog basically every time i use it
2025-01-15 01500, 2025
duckfromdisc[m]
might be user error tho who knows
2025-01-15 01534, 2025
kellnerd[m] has quit
2025-01-15 01514, 2025
yvanzo[m] has quit
2025-01-15 01514, 2025
spynxic has quit
2025-01-15 01515, 2025
Cheezmo_ has quit
2025-01-15 01515, 2025
wileyfoxyx[m] has quit
2025-01-15 01515, 2025
mven97 has quit
2025-01-15 01515, 2025
apetresc has quit
2025-01-15 01515, 2025
antlarr has quit
2025-01-15 01515, 2025
xoip has quit
2025-01-15 01516, 2025
duncaen has quit
2025-01-15 01516, 2025
reosarevok has quit
2025-01-15 01517, 2025
moviuro has quit
2025-01-15 01518, 2025
nsbdfl has quit
2025-01-15 01518, 2025
Evergreen has quit
2025-01-15 01524, 2025
yvanzo[m] joined the channel
2025-01-15 01524, 2025
spynxic joined the channel
2025-01-15 01524, 2025
wileyfoxyx[m] joined the channel
2025-01-15 01524, 2025
Cheezmo_ joined the channel
2025-01-15 01524, 2025
mven97 joined the channel
2025-01-15 01524, 2025
apetresc joined the channel
2025-01-15 01524, 2025
antlarr joined the channel
2025-01-15 01524, 2025
xoip joined the channel
2025-01-15 01524, 2025
duncaen joined the channel
2025-01-15 01524, 2025
reosarevok joined the channel
2025-01-15 01524, 2025
moviuro joined the channel
2025-01-15 01524, 2025
nsbdfl joined the channel
2025-01-15 01524, 2025
Evergreen joined the channel
2025-01-15 01527, 2025
moviuro has quit
2025-01-15 01545, 2025
moviuro joined the channel
2025-01-15 01557, 2025
sentriz joined the channel
2025-01-15 01502, 2025
bwbuhse has left the channel
2025-01-15 01527, 2025
ErBear is now known as Erin
2025-01-15 01506, 2025
aerozol[m] has quit
2025-01-15 01526, 2025
iconoclasthero[m has quit
2025-01-15 01551, 2025
logistic-bot joined the channel
2025-01-15 01516, 2025
logistic-bot has quit
2025-01-15 01536, 2025
logistic-bot joined the channel
2025-01-15 01512, 2025
Island_ joined the channel
2025-01-15 01533, 2025
UltimateRiff[m] has quit
2025-01-15 01553, 2025
aerozol[m] joined the channel
2025-01-15 01554, 2025
aerozol[m]
This has come up before, but +1 to not having to login every time! I know it’s ‘just a few clicks’ but when you’re importing a lot of releases it adds up. But obviously it’s just kepstin doing the actual work on their free tool so we can’t be too demanding :P
2025-01-15 01524, 2025
kepstinbrainz
yeah, the problem is that it's really not easy to fix
2025-01-15 01515, 2025
kepstinbrainz
(i don't get what's up with oauth and refresh tokens anyways - what's the point of giving me a long-lived token that can be used to get new temporary tokens - just give me a long-lived token from the start)
2025-01-15 01525, 2025
aerozol[m]
Vaguely related: I’d love to have a page where users can donate into “buckets” of donations for certain features, e.g. third party tools, userscripts (or even core features, when not done by paid devs)
2025-01-15 01505, 2025
aerozol[m]
Because maintaining and updating tools starts out fun… but quickly turns into an expectation
2025-01-15 01518, 2025
kepstinbrainz
ah - i see why i'm not using the refresh token. to get that you have to explicitly request "offline" access
2025-01-15 01510, 2025
kepstinbrainz
honestly, the fix should be done on musicbrainz side - they should hand out access tokens for online access with longer lifetimes.
2025-01-15 01545, 2025
kepstinbrainz
if musicbrainz does that, magicisrc will automatically stay logged in for longer (it checks the expiry time of the returned access token)
2025-01-15 01541, 2025
kepstinbrainz
but yeah - it would be possible to make magicisrc use the "offline access" request, store the refresh token, and generate new temporary access tokens when needed for submission.
2025-01-15 01521, 2025
kepstinbrainz
I'd want to add a "stay logged in" or similar checkbox to make requesting offline access conditional.
2025-01-15 01528, 2025
kepstinbrainz
… it actually might also be possible for me to simply hide the fact that it's occasionally re-authenticating
2025-01-15 01501, 2025
kepstinbrainz
by remembering your user info, and having the submit button silently re-authenticate you (with approval_prompt=auto) when needed
2025-01-15 01506, 2025
kepstinbrainz
... well, i've thrown up a one-line hack for power users on https://magicisrc-beta.kepstin.ca/ which i'll expand on later. The "Login" button is now one-click, it doesn't re-prompt for permissions if you're previously allowed magicisrc on your account.
2025-01-15 01531, 2025
Island_ has quit
2025-01-15 01512, 2025
kepstinbrainz
The full fix will be to make it have a "remember me" option to make it save your username, and a step hidden in the submission process to pop you through the one-click authentication flow if needed before submitting.
2025-01-15 01553, 2025
Island_ joined the channel
2025-01-15 01505, 2025
logistic-bot has quit
2025-01-15 01514, 2025
Maxr1998 joined the channel
2025-01-15 01505, 2025
Maxr1998_ has quit
2025-01-15 01531, 2025
aerozol[m]
Amazing!! I would make a ticket re. longer access tokens but it’s all a bit over my head I’m afraid. Let me know if I can help with anything