Actually, let’s go ahead anyway. If we can reach agreement without bitmap, we can do so. I highly doubt he has any objections.
Mr_Monkey
</intermission>
Freso
And BrainzBot is still here so bitmap can reference logs if he does come back on, and I don’t want to keep the meeting going for 20 minutes, when I feel like this topic can be resolved in 2. :p
adhawkins joined the channel
So anyway, we discussed this a couple of years back, and while there was no general disagreement expressed with blocking the addition of new CD stubs, there was also no actual formal agreement to do so, AFAICT.
bitmap joined the channel
killme joined the channel
loujine joined the channel
fs joined the channel
VxJasonxV joined the channel
ruaok
adhawkins: hi. yes, that hiccup in your logs is known and has been resolved. :)
Freso: About the Jira project for bot tasks, does naming it MBBE for MB Batch Edits and organizing it by entity type seems sensible to you?
Mr_Monkey
Freso: Fingers crossed !
Freso
yvanzo: That seems fine.
yvanzo
Ok, thanks, will create it this week (for good).
Freso
:)
Thanks yvanzo
Chinmay3199
I had a look into the database and there aren't many. I only see 11 entries so not a tough job ig
Mr_Monkey
👍
Probably much quicker than figuring out that query :p
Chinmay3199
Yeah XD
Cyna
damn missed the reviews again
iliekcomputers
alastairp: hey
alastairp
hi
I'm... conflicted about semver on BU
that is, the apparently clear answer is to bump the major version because there's an API change
however, the counter to that is that we're using an internal implementation detail in order to optimise our tests, this doesn't affect any prod code, and we know exactly the thing to change
so my recommendation is to just bump the .x version as normal and release it. do you have any strong opposition to that?
iliekcomputers
alastairp: not specifically, I'm happy to defer to your best judgement
alastairp
cool, I'll do that then, thanks
iliekcomputers
👍🏽👍🏽
alastairp
btw, I tagged you on an AB ticket around our dockerfile rewrite. would appreciate your feedback on that
iliekcomputers
Ah, sure, I'll take a look
On jira?
Can you link it?
alastairp
no, a PR, I tagged you for review
sounds like you're on mobile ;)
iliekcomputers
Haha, yeah. :D
alastairp
Mr_Monkey: I tried optimize-css-plugin, it got the css down about 5-10% smaller by removing newlines, I'm not sure it's worth it given how little css we have
alastairp: Oh, speaking of semver, I saw you were using versioneer for something. Did you ever look at `setuptools_scm`?
alastairp
Freso: mm, no. is that _yet another_ tool for this kind of thing?
adhawkins has quit
Freso: ah. it seems familiar. I can't remember specifically why I went for versioneer in that case
I think it was because I didn't want to create pyproject.toml, because I was sick of the proliferation of project-level config files (and then I went and added versioneer.py anyway...
Freso
alastairp: I guess? I feel like it’s been around since forever. I hadn’t heard of versioneer before and use _scm for several projects myself.
setuptools_scm just uses setup.py, no additional files, and no need to remember to run any external programs or anything. It doesn’t work well if you don’t make a proper Python package of it and also don’t run it directly from its git clone though.
but if you build a package and install that package it's fine?
oh, I see
interesting
Freso
Running straight from git clone is fine, packaging is also fine. Downloading a .zip of the git archive (without the .git folder) and trying to run that works… less fine.
alastairp
sure, but the argument there is that you should be downloading a proper source bundle and running setup.py install anyway, I could live with that
I guess it means that it's not vendorable any more, though?
Freso
Not sure what vendorable means?
alastairp
e.g. there are many apps that vendor pymbngs because released versions are a bit out of date
adhawkins joined the channel
copying the dependency into the source tree of your other program
Freso
Ah, yeah, that might possibly not work.
alastairp
anyway, looking into it further, setuptools_scm looks good for BU, I'll set that up. thanks for the suggestion
Freso
(Since that would basically be the same as downloading a .zip without the .git.)
alastairp
yeah, exactly
Freso
It might work if they use git submoduling, maybe.
I haven’t played with that, so no idea about how that would behave.
alastairp: If the css plugin is set up and no extra hassle, I'd leave it there. 5-10% savings is always good for the servers I guess.
alastairp
yeah, it didn't take a lot to set up, and it seems to be a documented best-practise
Mr_Monkey
I might add it to BB's setup too
alastairp
what confuses me (in a "why on earth would it work like that?" way) is that you can set up webpack with some defaults, but the moment that you add in something else those defaults go away
so, webpack minifies js by default it seems, but if you use the css optimisation package and set it as an optimiser, you have to add in a js optimiser too! but, the one in their example isn't the same optimiser used by default!