(I'm putting this on the meeting rather than just talking to MB devs because maybe it is relevant for Mr_Monkey / BB too at least)
bitmap
yes, I checked and it seems we don't store any urls with non-ascii characters in the DB (we canonicalize IDNs to punycode already)
reosarevok
Do we canonicalize them actively, or did we just block the non-ASCII chars by accident so that nobody could send them? :)
That's what I was not sure about
Mr_Monkey
Interesting
bitmap
we do URI->new($url)->canonical in find_or_insert so it's done right before they're added
reosarevok
If we do it intentionally (or we ever agreed we should do that) then we should be allowing the URL to be submitted but just store it encoded
CatQuest
huh but I could have sworn I had added unicode (japanese glyphs) style urls before
reosarevok
Yes, that's different :)
CatQuest
oh
reosarevok
(but IIRC those do get encoded too)
CatQuest
yea they do. ugly af too
bitmap
but yeah, we should accept either as input, but continue to store as punycode
reosarevok
Ok. So I guess we should be able to tell it's a duplicate and block the submission then? :)
(which I assume we can't do now)
bitmap
yup, if we code it
reosarevok
Sure, I mean, we want to do that, I assume. Ok. So, always store as ASCII, always display as unicode? :)
CatQuest
yes plox
and for things like edit notes too?
bitmap
+1 to 'store as ASCII, always display as unicode'
CatQuest
+1 too
(again)
Freso
As reporter of MBS-9674, +1 :p
reosarevok
CatQuest: I assume for edit notes they'll just be displayed as they get pasted, I don't think we currently do anything to URLs there now - if you think we should, maybe that's a separate ticket (and would also be relevant to stuff like the JP ones you mentioned)
Thank you everyone for your time! Stay hydrated, and do something kind to/for yourselves! 😄
</BANG>
Mr_Monkey
Ciao !
CatQuest
reosarevok: tbh my one gripe with links in edit notes is that they get shorted ... visually so i can't copy-paste edit notes fro msoemwhere to somewhere else beasue links don't get copied proerly
you too freso
reosarevok
Yes, I hate that too tbh
Although I get why we do it
sumedh has quit
CatQuest
i wish there was a prefrence for it tbh
Freso
I wish it could be toggle per-message. Most of the time I’m fine with them being truncated, but every so often I’d really like to just copy/paste a message.
abhinavohri: right, that's strange that it works for you but not online. No problem. I'll check out the code myself and see if I can work out what is going on