Yes, it's mainly just me reviewing PRs at the moment, so it usually takes some time for me to get to it
2021-11-29 33332, 2021
monkey
Usually within the week, but I do ask for your patience
2021-11-29 33320, 2021
Shubh
and also in first one lint checks failed so can i fix it in github without pulling it?
2021-11-29 33322, 2021
monkey
Possibly yes, although I usually find it's easier to make the modifications locally so I can check if the tests and linting passes
2021-11-29 33340, 2021
Shubh
i was kinda nervous as its my first contribution to open-source and though i messed that simple task
2021-11-29 33329, 2021
monkey
Don't you worry ! We all start somewhere :)
2021-11-29 33303, 2021
Shubh
although i passed most of the linter check but there was one related to inconsistent return
2021-11-29 33350, 2021
Shubh
so what should i do to fix that like return something if entity only deleted once or just remove the lint check for that line?
2021-11-29 33327, 2021
monkey
So you can run the linter locally before committing changes: if you have NodeJS on your machine you can use the command `npm run lint` (after installing dependencies with `npm install`)
2021-11-29 33345, 2021
monkey
Alternatively you can run it in a docker container, le me find the command
2021-11-29 33323, 2021
monkey
`docker-compose run --rm bookbrainz-site npm run lint` I believe
2021-11-29 33317, 2021
Shubh
How should i fix that inconsistent return check ?
2021-11-29 33343, 2021
monkey
Which PR is that?
2021-11-29 33312, 2021
Shubh
first one that entity delete twice bug
2021-11-29 33326, 2021
monkey
Right. I think for all those route you can use `next(new ConflictError(…` instead of `return next(new ConflictError(…`
2021-11-29 33320, 2021
monkey
It's complaining because in one condition you `return` something, but in other conditions nothing is returned. But in this case we don't need to return explicitly, so we can just use next(…)
2021-11-29 33343, 2021
Shubh
lemme try without return then
2021-11-29 33326, 2021
Shubh
umm..
2021-11-29 33314, 2021
Shubh
if i dont return it then wont the other things run as well like displayEntity ..
2021-11-29 33307, 2021
monkey
Ah yes, correct.
2021-11-29 33339, 2021
CatQuest
oh man, here both Shubh and monkey are the same colour, it makes it difficukt to read conversation :D
2021-11-29 33355, 2021
Shubh
what will happen if i return that displayEntity thingy?
2021-11-29 33302, 2021
CatQuest
difficult*
2021-11-29 33309, 2021
Shubh
im purple
2021-11-29 33315, 2021
monkey
I guess you can put the rest of the processing inside an `else { }` block
I don't see a fix for 429 so probably still an issue
2021-11-29 33320, 2021
Shubh
but I don't see any related warning during build process
2021-11-29 33321, 2021
monkey
570 looks fixed to me
2021-11-29 33339, 2021
monkey
Ah, right, then if you don't see that warning anyomre consider it fixed
2021-11-29 33322, 2021
Shubh
are those instructions related to setting up docker fixed ?
2021-11-29 33302, 2021
monkey
If you mean the issues you encountered when you were setting up, not yet, something I'm working on now
2021-11-29 33346, 2021
Shubh
if you are busy then i can also fix those thingy , if you don't mind ..
2021-11-29 33300, 2021
monkey
These setup issues I'd like to do myself, there's something pretty crucial gone wrong.
2021-11-29 33300, 2021
monkey
But other than that feel free to take any ticket you are interested in
2021-11-29 33341, 2021
Shubh
Hmm on it !
2021-11-29 33302, 2021
Shubh
Hello ..
2021-11-29 33313, 2021
monkey
Don't hesitate to write your questions without waiting for me to be here Shubh, I receive alerts and read the logs
2021-11-29 33344, 2021
Shubh
i just wanted to ask how page routing works in BB ?
2021-11-29 33346, 2021
monkey
I might need a more precise question, that one is a bit broad :p We use ExpressJS as a framework to handle routing, if that answers part of the question
i put in a user css to fix it so i'll try and disable this and see if i get it again
2021-11-29 33316, 2021
monkey
I wonder if it was just a superposition of the dropdown and the text box underneath
2021-11-29 33307, 2021
CatQuest
it no longer looks like that because the annotation box is further dows. but the lowest line in the drop down in the "type" dropdown *is* thinner and less visible than eg "language"
