#bookbrainz

CatQuest: The section *is* there, even if there are search results! :) Look at the bottom of the page.

> oh. also "series" should be added

Yep, I realized that was missing when I read the ticket again, will fix !

monkey: Hey!, finally userscript working with firefox ( https-> http ), also i added all the necessary options (identifiers included) to prefill edition entity.

when you get time please have a look and let me know if it fine with you.

Ace !

monkey: ooh! it wasn't there yesterday! must have been a chace issue or something great to see it

and ace on the series thing!

BenOckmore: Found one last thing to amend after the BS4 migration, and found a simple solution for the wrapping navbar menu items. That's really all I can see (apart from the nicer green color of the validation labels, let's keep that), I think that migration can be considered finished after this !

I'm deploying that to test.BB

Oh what's going on with the navbar items?

A picture being worth 1000 words: https://github.com/metabrainz/bookbrainz-site/p...

It was also terrible pre-BS4, to be fair.

Just a different flavor of terrible :p

I wonder if we should change the navbar breakpoint so it collapses a little wider

Pre-BS4 is worse, the whole navbar just wraps: https://usercontent.irccloud-cdn.com/file/ufoOL...

Oh yeah wow!

I'd suggest trying it out on test once I've deployed, it works quite well as-is without the need to change the breakpoint

Weird about the date inputs, that's definitely an issue I fixed at some point, maybe I lost the CSS when I went through and tidied up the style.scss commits

An easy one to miss, as it looks quite neat when it takes the whole width , looking like the fields above/below.

OK, deployed to test.bb

I was going to mention - I've started going through replacing CustomInput. It was a component added to make the transition from an older version of react-bootstrap easier - there used to be an Input component. In most cases, the replacement is just a Form.Group, Form.Label and Form.Control, which makes it easier to see what's going on

Ah nice ! Yes it seemed like a lot of wrapper for not a lot of use

Although there is so much going on in there that it's hard to tell…

honestly i prefer wrappnavbar over horizontal scrolling ffiw

is thre any way to create a "paste a date here and it will autofill the date bits" incorporated into the date format thing?

like that mb userscript

it could be simple and accept only YYYY-MM-DD or DD-MM-YYYY formats at first

i can priveide a lsit of formats

provide

YYYY/MM/DD DD/MM/YYYY DD $month YYYY

Ticket please :)

and that script was pretty brilliant for when it was not clear if it was DD-YY-MM or DD-MM-YY or YY-DD-MM or YY-MM-DD it would simply ask: this is unclear please chose one"

oh hmm

I thoguht i did add one

Also, do you see a horizontal scroll with the navbar? Shouldn't happen

i dunno. i cant really see what was worng with the new image in that first link

so i made an assumption

OK, then rest assured, no scrolling.

bra

monkey: https://tickets.metabrainz.org/browse/BB-641

BB-641: Date Format Parser

tadaa

sorry it took hours