Hello! First time talking here. Just solved BB-583 issue. Can someone specify if the the button dimensions are right? If not please specify preferences. Also solved issue BB-716 regarding the developer docs.
ShivamAwasthi: Hi! Regarding BB-709 I think we want the authors to be shown the same way across the website (especially with regards to a component that is used in multiple places)
So do you think we should reconstruct the author-credits using the AuthorCreditDisplay component, or should we list the authors being credited(without mentioning their aliases, etc) just like we do in case of the WorkTable?
2023-03-13 07207, 2023
monkey
I fit's for an edition or edition group, we should use author credits (and the AuthorCreditsDisplay component). If it's a work with relationships to author(s) then we should display them like the work table
2023-03-13 07225, 2023
monkey
Author credits and "author wrote work" relationships are not the same :)
2023-03-13 07255, 2023
monkey
It makes sense to display full reconstituted author credits for Editions
2023-03-13 07200, 2023
monkey
(& EGs)
2023-03-13 07220, 2023
ShivamAwasthi95 joined the channel
2023-03-13 07235, 2023
ShivamAwasthi95 has quit
2023-03-13 07203, 2023
ShivamAwasthi has quit
2023-03-13 07204, 2023
ShivamAwasthi50 joined the channel
2023-03-13 07226, 2023
ShivamAwasthi50 has quit
2023-03-13 07245, 2023
ShivamAwasthi joined the channel
2023-03-13 07256, 2023
ShivamAwasthi
got it monkey, thanks!
2023-03-13 07203, 2023
monkey
👍
2023-03-13 07220, 2023
ShivamAwasthi has quit
2023-03-13 07206, 2023
kellnerd joined the channel
2023-03-13 07226, 2023
stoichy has quit
2023-03-13 07215, 2023
Legend11 joined the channel
2023-03-13 07220, 2023
Legend11 is now known as mrigeshThakur
2023-03-13 07227, 2023
Legend11 joined the channel
2023-03-13 07242, 2023
Legend11 is now known as mrigeshThakur11
2023-03-13 07243, 2023
mrigeshThakur has quit
2023-03-13 07226, 2023
mrigeshThakur11 has quit
2023-03-13 07228, 2023
Legend11 joined the channel
2023-03-13 07240, 2023
Legend11 is now known as mrigeshThakur
2023-03-13 07239, 2023
Aditi joined the channel
2023-03-13 07243, 2023
mrigeshThakur
Hi guys could anyone help me with Live Reloading , what does Mount the src folder to the bookbrainz-site service mentioned in the doc means ??
monkey I had another wild idea about a feature that could be added to bb , a guide bot that would help users to get started ( basically do job of these docs https://bookbrainz-user-guide.readthedocs.io/en/l…) and also help to create tickets , like if a user finds a bug he/she could report it and it automatically becomes a ticket .( It could
2023-03-13 07239, 2023
mrigeshThakur
also be used for reporting spam content if found any )
2023-03-13 07203, 2023
monkey
Help wizard style ! Not a bad idea, although it might double up a bit on the simplified book editor from last year's GSOC that already simplifies the process. What would be its features, other than helping report bugs?
2023-03-13 07253, 2023
Aditi has quit
2023-03-13 07254, 2023
mrigeshThakur
Yup initially it would provide a guide tour of bb, like how the stuff works and how to contribute , then for particular pages it could be used as an assistant , like for example you are adding a new author or a book ( so sometimes we need to look up in web for certain info , like I added a new author had to google some details regarding him , about
2023-03-13 07255, 2023
mrigeshThakur
this place of birth and dob , so I had to switch tabs ( and it ended up me having going to netflix '=D ), so it would be very subtle , but would add on to the user experience , next it would also help users to check if a author or book already exits ( like before adding a book or author as mentioned in docs we need to check for duplication ) so
2023-03-13 07255, 2023
mrigeshThakur
it would help with that too.
2023-03-13 07248, 2023
mrigeshThakur
These were a few features I had in my mind , would tinker more about it , like what other features it could have
2023-03-13 07238, 2023
monkey
I don't understand the part about switching tabs for searching for info. What would the guide thing do?
2023-03-13 07238, 2023
monkey
All in all I'm not convinced it would be a lot easier than improving and adding the right help text in the right place in the entity forms
2023-03-13 07254, 2023
Leftmost has quit
2023-03-13 07210, 2023
Leftmost joined the channel
2023-03-13 07241, 2023
mrigeshThakur
Oh sorry by tabs I meant chrome tabs , It was that I was adding an Indian author (Ankur Warikoo) , so firstly I had to search if that author was previously there( so the wizard could help with that ) , then while adding info about him , https://pasteboard.co/QE5OZeyUXuIx.png I had to look up his place of birth and dob , and I guide would be like
I understand what the wizard would look like, what I don't understand is how exactly it would help with searching for the extra information (dob, etc.)As for avoiding duplicates, we have this system in place; what would the wizard do differently? How do you see it working? https://usercontent.irccloud-cdn.com/file/oiYneNC…
2023-03-13 07209, 2023
ShivamAwasthi joined the channel
2023-03-13 07241, 2023
mrigeshThakur has quit
2023-03-13 07214, 2023
aadil25 joined the channel
2023-03-13 07254, 2023
aadil2522 joined the channel
2023-03-13 07212, 2023
aadil2522 has quit
2023-03-13 07217, 2023
aadil25 has quit
2023-03-13 07220, 2023
Aditi has quit
2023-03-13 07246, 2023
Legend11 joined the channel
2023-03-13 07257, 2023
Legend11 is now known as mrigeshThakur
2023-03-13 07259, 2023
mrigeshThakur
it would just provide a searching functionality , that at the end would give the corresponding google results , just a simple feature , so that someone does not need to change their chrome tabs and search those things ( a little snub at user experience ) '=D ,
2023-03-13 07227, 2023
mrigeshThakur
Also like if someone wants to know about a particular thing about a book or a author , they can ask questions like " What books did this author wrote " and then get the results ...
2023-03-13 07202, 2023
mrigeshThakur
again instead of searching for the whole thing ( it would add to the overall user experience)
Made one more change https://pasteboard.co/k53Q42Z5Y3xs.png I have removed the indentation for relationships with depth 1 because the icon itself kind of provides an indentation
2023-03-13 07202, 2023
kellnerd
That's what I'd have suggested too.
2023-03-13 07255, 2023
kellnerd
But to be honest, I'm not really convinced by the arrow icon itself, no matter how light it is...
2023-03-13 07259, 2023
ShivamAwasthi
I see. Do you have any suggestion/alternative in mind?
2023-03-13 07248, 2023
ShivamAwasthi
Perhaps something thinner(akin to the square corner in the original mockup) would look better?
2023-03-13 07252, 2023
kellnerd
It draws too much attention, IMO, I would expect something more subtle as in mockup 7 or 8.
2023-03-13 07207, 2023
kellnerd
Thinner, definitely.
2023-03-13 07241, 2023
ShivamAwasthi
Maybe aerozol can help
2023-03-13 07222, 2023
kellnerd
We can probably ask him in #metabrainz after today's meeting.
2023-03-13 07249, 2023
ShivamAwasthi
hmm sure
2023-03-13 07238, 2023
ShivamAwasthi has quit
2023-03-13 07236, 2023
kellnerd
My personal favourite would be a combination of 7 and 8, i.e. the arrows/angles from 8 but with the continuous vertical line from 7. That would require some precise tiling, but it should be possible.
Hello! Just noticed that when running the command for the test suite I get a warning saying that my typescript version is too new(4.5.2 and i need < 4.5.0). After the warning I only get linter errors and no other test is being run. Is that what should happen and can I skip it so that the other tests can run?
2023-03-13 07230, 2023
Aditi joined the channel
2023-03-13 07251, 2023
Aditi has quit
2023-03-13 07226, 2023
kellnerd
stoichy: If the linter is blocking the test suite from being run, I would either fix the issues reported by the linter or run the test command without the linter.
2023-03-13 07254, 2023
kellnerd
i.e. chnaging the test command in package.json from "npm run lint-errors && cross-env NODE_ENV=test mocha -r jsdom-global/register" to "cross-env NODE_ENV=test mocha -r jsdom-global/register"
2023-03-13 07259, 2023
kellnerd
*changing
2023-03-13 07246, 2023
kellnerd
Alternatively you can also run the modified command with npx, so you don't have to alter package.json
