Tarun_0x0 (IRC): I'm looking at BB#1051 again as I was re-reading one of your comments I had an idea. It's late to realize it, but I think we might be able to fix the issue without having to modify the database:
> it means that the author_credits section exists but with empty author credits
I suppose all we really need is to create an empty author credit (an AC without any items in it) when the "empty author credit" checkbox is checked
monkey[m] checks the database schema
Yeah, I think that would work, an existing author_credit without any author_credit_name attached can be considered an empty author credit (i.e. one where the "no AC" checkbox was checked)
There is also an author_count column in the author_credit table, which we don't currently use. Perhaps manually setting it to 0 could serve the same purpose
Will copy those comments on the PR
Tarun_0x0 joined the channel
Tarun_0x0 has quit
Tarun_0x0 joined the channel
Tarun_0x0
hmmmm , this should do the trick
but me may not need to set the author_count in author_credit table if we use empty author_credit name as primary check
MohamedAli00949 joined the channel
monkey[m] , also any validation checks u know of which may not allow us to save an empty author_credit
Tarun_0x0 looking at form validators
After having taken a high-level look at it, we may need to make some small changes in validators. However, overall, I think this approach would be better than creating extra columns.
Additionally, we may not need to make any changes in bookbrainz-data-js using this approach
but, will our author_credit table will be having meaningless credit ids , not sure about this🤔
munishk has quit
prout has quit
prout joined the channel
monkey[m]
I don't think they're completely meaningless, but I had the same thought. I don't think that would be a big issue
Tarun_0x0
ok let me try this out , i'll let you know when its done (y)
